First step in improving test coverage.

This commit is contained in:
James Cole
2018-08-30 20:58:07 +02:00
parent e158b9b64e
commit 33fe6dbfa3
19 changed files with 517 additions and 29 deletions

View File

@@ -172,9 +172,16 @@ class StageImportDataHandlerTest extends TestCase
->andReturn($deposit)->once();
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data =0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-last-transaction-1234', 0])->andReturn($lastPref)->once();
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
$handler = new StageImportDataHandler;
@@ -239,9 +246,16 @@ class StageImportDataHandlerTest extends TestCase
$payment->shouldReceive('listing')->once()->andReturn($list);
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data =0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-last-transaction-1234', 0])->andReturn($lastPref)->once();
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
$handler = new StageImportDataHandler;
$handler->setImportJob($job);
@@ -290,9 +304,16 @@ class StageImportDataHandlerTest extends TestCase
$pointer = new Pointer('iban', 'ES2364265841767173822054', 'Test Site');
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data =0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-last-transaction-1234', 0])->andReturn($lastPref)->once();
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
// ignore the deprecated fields:
@@ -447,9 +468,9 @@ class StageImportDataHandlerTest extends TestCase
$list = new BunqResponsePaymentList($value, [], null);
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data =0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-last-transaction-1234', 0])->andReturn($lastPref)->once();
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->once();
$expectedTransactions = [
[
@@ -510,6 +531,18 @@ class StageImportDataHandlerTest extends TestCase
$accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::ASSET]])->once()->andReturn($asset);
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(1);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
$handler = new StageImportDataHandler;
$handler->setImportJob($job);
try {