Fix negative budget limits

app/Console/Commands/Correction/CorrectDatabase.php

@@ -61,6 +61,7 @@ class CorrectDatabase extends Command
             'firefly-iii:create-link-types',
             'firefly-iii:create-access-tokens',
             'firefly-iii:remove-bills',
+            'firefly-iii:fix-negative-limits',
             'firefly-iii:enable-currencies',
             'firefly-iii:fix-transfer-budgets',
             'firefly-iii:fix-uneven-amount',

app/Console/Commands/Correction/FixBudgetLimits.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use DB;
+use FireflyIII\Models\BudgetLimit;
+use Illuminate\Console\Command;
+
+/**
+ * Class CorrectionSkeleton
+ */
+class FixBudgetLimits extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Fixes negative budget limits';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:fix-negative-limits';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+        $set = BudgetLimit::where('amount', '<', '0')->get();
+        if (0 === $set->count()) {
+            $this->info('All budget limits are OK.');
+            return 0;
+        }
+        $count = BudgetLimit::where('amount', '<', '0')->update(['amount' => DB::raw('amount * -1')]);
+
+        $this->info(sprintf('Fixed %d budget limit(s)', $count));
+
+        return 0;
+    }
+}

app/Console/Commands/Upgrade/UpgradeDatabase.php

@@ -82,6 +82,7 @@ class UpgradeDatabase extends Command
             'firefly-iii:create-link-types',
             'firefly-iii:create-access-tokens',
             'firefly-iii:remove-bills',
+            'firefly-iii:fix-negative-limits',
             'firefly-iii:enable-currencies',
             'firefly-iii:fix-transfer-budgets',
             'firefly-iii:fix-uneven-amount',

app/Http/Controllers/Budget/BudgetLimitController.php

@@ -160,6 +160,9 @@ class BudgetLimitController extends Controller
         if ((int) $amount > 268435456) {
             $amount = '268435456';
         }
+        if((float) $amount < 0.0) {
+            $amount = bcmul($amount, '-1');
+        }
 
         if (null !== $limit) {
             $limit->amount = $amount;
@@ -226,6 +229,9 @@ class BudgetLimitController extends Controller
         if ((int) $amount > 268435456) { // 268 million
             $amount = '268435456';
         }
+        if((float) $amount < 0.0) {
+            $amount = bcmul($amount, '-1');
+        }
 
         $limit = $this->blRepository->update($budgetLimit, ['amount' => $amount]);
         $array = $limit->toArray();

app/Http/Controllers/System/InstallController.php

@@ -93,6 +93,7 @@ class InstallController extends Controller
             'firefly-iii:create-link-types'            => [],
             'firefly-iii:create-access-tokens'         => [],
             'firefly-iii:remove-bills'                 => [],
+            'firefly-iii:fix-negative-limits'          => [],
             'firefly-iii:enable-currencies'            => [],
             'firefly-iii:fix-transfer-budgets'         => [],
             'firefly-iii:fix-uneven-amount'            => [],