Fixed some basic tests.

app/Http/Controllers/HomeController.php

@@ -3,6 +3,7 @@
 use Auth;
 use Cache;
 use Carbon\Carbon;
+use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use Input;
 use Preferences;
 use Redirect;
@@ -51,9 +52,10 @@ class HomeController extends Controller
     /**
      * @return \Illuminate\View\View
      */
-    public function index()
+    public function index(AccountRepositoryInterface $repository)
     {
-        $count         = Auth::user()->accounts()->accountTypeIn(['Asset account', 'Default account'])->count();
+
+        $count         = $repository->countAssetAccounts();
         $title         = 'Firefly';
         $subTitle      = 'What\'s playing?';
         $mainTitleIcon = 'fa-fire';
@@ -61,26 +63,10 @@ class HomeController extends Controller
         $frontPage     = Preferences::get('frontPageAccounts', []);
         $start         = Session::get('start', Carbon::now()->startOfMonth());
         $end           = Session::get('end', Carbon::now()->endOfMonth());
-
-
-        if ($frontPage->data == []) {
-            $accounts = Auth::user()->accounts()->accountTypeIn(['Default account', 'Asset account'])->orderBy('accounts.name', 'ASC')->get(['accounts.*']);
-        } else {
-            $accounts = Auth::user()->accounts()->whereIn('id', $frontPage->data)->get(['accounts.*']);
-        }
+        $accounts      = $repository->getFrontpageAccounts($frontPage);
 
         foreach ($accounts as $account) {
-            $set = Auth::user()
-                       ->transactionjournals()
-                       ->with(['transactions', 'transactioncurrency', 'transactiontype'])
-                       ->leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id')
-                       ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id')->where('accounts.id', $account->id)
-                       ->before($end)
-                       ->after($start)
-                       ->orderBy('transaction_journals.date', 'DESC')
-                       ->orderBy('transaction_journals.id', 'DESC')
-                       ->take(10)
-                       ->get(['transaction_journals.*']);
+            $set = $repository->getFrontpageTransactions($account, $start, $end);
             if (count($set) > 0) {
                 $transactions[] = [$set, $account];
             }

app/Repositories/Account/AccountRepository.php

@@ -10,10 +10,12 @@ use FireflyIII\Models\Account;
 use FireflyIII\Models\AccountMeta;
 use FireflyIII\Models\AccountType;
 use FireflyIII\Models\PiggyBank;
+use FireflyIII\Models\Preference;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionJournal;
 use FireflyIII\Models\TransactionType;
 use Illuminate\Pagination\LengthAwarePaginator;
+use Illuminate\Support\Collection;
 use Log;
 use Session;
 
@@ -25,6 +27,14 @@ use Session;
 class AccountRepository implements AccountRepositoryInterface
 {
 
+    /**
+     * @return int
+     */
+    public function countAssetAccounts()
+    {
+        return Auth::user()->accounts()->accountTypeIn(['Asset account', 'Default account'])->count();
+    }
+
     /**
      * @param Account $account
      *
@@ -37,6 +47,44 @@ class AccountRepository implements AccountRepositoryInterface
         return true;
     }
 
+    /**
+     * @param Preference $preference
+     *
+     * @return Collection
+     */
+    public function getFrontpageAccounts(Preference $preference)
+    {
+        if ($preference->data == []) {
+            $accounts = Auth::user()->accounts()->accountTypeIn(['Default account', 'Asset account'])->orderBy('accounts.name', 'ASC')->get(['accounts.*']);
+        } else {
+            $accounts = Auth::user()->accounts()->whereIn('id', $preference->data)->orderBy('accounts.name', 'ASC')->get(['accounts.*']);
+        }
+
+        return $accounts;
+    }
+
+    /**
+     * @param Account $account
+     * @param Carbon  $start
+     * @param Carbon  $end
+     *
+     * @return mixed
+     */
+    public function getFrontpageTransactions(Account $account, Carbon $start, Carbon $end)
+    {
+        return Auth::user()
+                   ->transactionjournals()
+                   ->with(['transactions', 'transactioncurrency', 'transactiontype'])
+                   ->leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id')
+                   ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id')->where('accounts.id', $account->id)
+                   ->before($end)
+                   ->after($start)
+                   ->orderBy('transaction_journals.date', 'DESC')
+                   ->orderBy('transaction_journals.id', 'DESC')
+                   ->take(10)
+                   ->get(['transaction_journals.*']);
+    }
+
     /**
      * @param Account $account
      * @param int     $page

app/Repositories/Account/AccountRepositoryInterface.php

@@ -4,7 +4,9 @@ namespace FireflyIII\Repositories\Account;
 
 use FireflyIII\Models\Account;
 use FireflyIII\Models\TransactionJournal;
-
+use FireflyIII\Models\Preference;
+use Illuminate\Support\Collection;
+use Carbon\Carbon;
 /**
  * Interface AccountRepositoryInterface
  *
@@ -19,6 +21,27 @@ interface AccountRepositoryInterface
      */
     public function destroy(Account $account);
 
+    /**
+     * @return int
+     */
+    public function countAssetAccounts();
+
+    /**
+     * @param Preference $preference
+     *
+     * @return Collection
+     */
+    public function getFrontpageAccounts(Preference $preference);
+
+    /**
+     * @param Account $account
+     * @param Carbon  $start
+     * @param Carbon  $end
+     *
+     * @return mixed
+     */
+    public function getFrontpageTransactions(Account $account, Carbon $start, Carbon $end);
+
     /**
      * @param Account $account
      * @param string  $range

app/Support/Preferences.php

@@ -45,12 +45,12 @@ class Preferences
         if (is_null($pref)) {
             $pref       = new Preference;
             $pref->name = $name;
-            $pref->user()->associate(Auth::user());
-
         }
         $pref->data = $value;
-        $pref->save();
-
+        if (!is_null(Auth::user()->id)) {
+            $pref->user()->associate(Auth::user());
+            $pref->save();
+        }
 
         return $pref;