property_exists doesn't seem to work

This commit is contained in:
James Cole
2020-08-02 18:58:44 +02:00
parent 839ba9d109
commit 3fa5694bb8

View File

@@ -596,8 +596,8 @@ class TransactionJournalFactory
$this->accountValidator->setTransactionType($transactionType);
// validate source account.
$sourceId = property_exists($data, 'source_id') ? (int) $data['source_id'] : null;
$sourceName = property_exists($data, 'source_name') ? (string) $data['source_name'] : null;
$sourceId = $data['source_id'] ? (int) $data['source_id'] : null;
$sourceName = $data['source_name'] ? (string) $data['source_name'] : null;
$validSource = $this->accountValidator->validateSource($sourceId, $sourceName, null);
// do something with result:
@@ -606,8 +606,8 @@ class TransactionJournalFactory
}
Log::debug('Source seems valid.');
// validate destination account
$destinationId = property_exists($data, 'destination_id') ? (int) $data['destination_id'] : null;
$destinationName = property_exists($data, 'destination_name') ? (string) $data['destination_name'] : null;
$destinationId = $data['destination_id'] ? (int) $data['destination_id'] : null;
$destinationName = $data['destination_name'] ? (string) $data['destination_name'] : null;
$validDestination = $this->accountValidator->validateDestination($destinationId, $destinationName, null);
// do something with result:
if (false === $validDestination) {