Remove TODO's.

This commit is contained in:
James Cole
2021-06-12 14:14:49 +02:00
parent 91b08d1772
commit 4614625f82
22 changed files with 54 additions and 54 deletions

View File

@@ -309,7 +309,7 @@ export default {
this.accounts[i].order = newOrder;
let url = './api/v1/accounts/' + current.id;
axios.put(url, {order: newOrder}).then(response => {
// TODO should update local account list, not refresh the whole thing.
// See reference nr. 8
this.getAccountList();
});
}
@@ -485,7 +485,7 @@ export default {
//
// allAccounts.push(acct);
// if ('asset' === this.type) {
// // TODO
// See reference nr. 9
// //this.getAccountBalanceDifference(this.allAccounts.length - 1, current);
// //this.getAccountLastActivity(this.allAccounts.length - 1, current);
// }

View File

@@ -324,7 +324,7 @@ export default {
let today = new Date(this.range.start);
let start;
let end;
let title = 'todo';
let title = 'tbd';
let half = 1;
// its currently first half of year:

View File

@@ -79,7 +79,7 @@ import format from "date-fns/format";
const {mapState, mapGetters, mapActions, mapMutations} = createNamespacedHelpers('dashboard/index')
// TODO same as credit list but reversed
// See reference nr. 2
export default {
name: "MainCreditList",

View File

@@ -56,7 +56,7 @@ const getters = {
return state.transactionType;
},
accountToTransaction: state => {
// TODO better architecture here, does not need the store.
// See reference nr. 1
// possible API point!!
return state.accountToTransaction;
},

View File

@@ -23,7 +23,7 @@
<alert :message="errorMessage" type="danger"/>
<alert :message="successMessage" type="success"/>
<form @submit="submitTransaction" autocomplete="off">
<SplitPills :transactions="transactions"/>
<SplitPills :transactions="transactions" :count="transactions.length"/>
<div class="tab-content">
<SplitForm
v-for="(transaction, index) in this.transactions"
@@ -492,7 +492,7 @@ export default {
}
// submit transaction link:
promises.push(axios.post('./api/v1/transaction_links', currentLink).then(response => {
// TODO error handling.
// See reference nr. 4
}));
}
}

View File

@@ -298,7 +298,7 @@ export default {
if (0 === index) {
this.transactionType = array.type.charAt(0).toUpperCase() + array.type.slice(1);
// TODO here you may need to catch stuff like loan/debt/mortgage
// See reference nr. 5
this.sourceAllowedTypes = [array.source_type];
this.destinationAllowedTypes = [array.destination_type];
this.date = array.date.substring(0, 16);
@@ -938,7 +938,7 @@ export default {
return JSON.stringify(compare);
},
// uploadAttachments: function (result) {
// //console.log('TODO, upload attachments.');
// See reference nr. 6
// if (0 === Object.keys(result).length) {
//
// for (let i in this.transactions) {
@@ -1172,7 +1172,7 @@ export default {
for (let i in this.transactions) {
if (this.transactions.hasOwnProperty(i) && /^0$|^[1-9]\d*$/.test(i) && i <= 4294967294) {
if (this.transactions.hasOwnProperty(i)) {
// TODO
// See reference nr. 7
}
}
}

View File

@@ -185,7 +185,7 @@
<script>
const lodashClonedeep = require('lodash.clonedeep');
// TODO error handling
// See reference nr. 3
export default {
props: ['index', 'value', 'errors', 'customFields'],
name: "TransactionLinks",

View File

@@ -30,8 +30,8 @@ import IndexOptions from "../../components/accounts/IndexOptions";
let i18n = require('../../i18n');
let props = {};
// TODO: long lists are slow to load. Fix this.
// TODO add interest for liabilities
// See reference nr. 8
// See reference nr. 9
Vue.component('b-table', BTable);
Vue.component('b-pagination', BPagination);
@@ -45,7 +45,7 @@ new Vue({
return createElement(Index, {props: props});
},
beforeCreate() {
// init the old root store (TODO remove me)
// See reference nr. 10
this.$store.commit('initialiseStore');
this.$store.dispatch('updateCurrencyPreference');
@@ -64,7 +64,7 @@ new Vue({
render: (createElement) => {
return createElement(Calendar, {props: props});
},
// TODO init store as well?
// See reference nr. 11
});
new Vue({
@@ -74,5 +74,5 @@ new Vue({
render: (createElement) => {
return createElement(IndexOptions, {props: props});
},
// TODO init store as well?
// See reference nr. 12
});

View File

@@ -35,7 +35,7 @@ new Vue({
return createElement(Index, {props: props});
},
beforeCreate() {
// init the old root store (TODO remove me)
// See reference nr. 13
//this.$store.commit('initialiseStore');
//this.$store.dispatch('updateCurrencyPreference');

View File

@@ -43,7 +43,7 @@ import store from '../components/store';
* vue, uiv and vuei18n are in app_vue.js
*/
// TODO pretty sure not all categories, budgets and other objects are picked up because they're paginated.
// See reference nr. 14
require('../bootstrap');
require('chart.js');
@@ -78,7 +78,7 @@ new Vue({
return createElement(Dashboard, {props: props});
},
beforeCreate() {
// TODO migrate to "root" store.
// See reference nr. 15
this.$store.commit('initialiseStore');
this.$store.dispatch('updateCurrencyPreference');
this.$store.dispatch('root/initialiseStore');
@@ -92,5 +92,5 @@ new Vue({
render: (createElement) => {
return createElement(Calendar, {props: props});
},
// TODO init store as well?
// See reference nr. 16
});

View File

@@ -28,11 +28,11 @@ Vue.config.productionTip = false;
// i18n
let i18n = require('../../i18n');
// TODO take transaction type from URL. Simplifies a lot of code.
// TODO make sure the enter button works.
// TODO add preferences in sidebar
// TODO If I change the date box at all even if you just type over it with the current date, it posts back a day.
// TODO Cash accounts do not work
// See reference nr. 3
// See reference nr. 4
// See reference nr. 5
// See reference nr. 6
// See reference nr. 7
let props = {};
new Vue({

View File

@@ -40,7 +40,7 @@ new Vue({
return createElement(Index, {props: props});
},
beforeCreate() {
// init the old root store (TODO remove me)
// See reference nr. 2
this.$store.commit('initialiseStore');
this.$store.dispatch('updateCurrencyPreference');