kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-29 18:20:01 +00:00
Code Issues Projects Releases Wiki Activity

Remove TODO's.

Browse Source
This commit is contained in:
James Cole
2021-06-12 14:14:49 +02:00
parent 91b08d1772
commit 4614625f82
22 changed files with 54 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
routes/api.php
View File

@@ -121,10 +121,10 @@ Route::group(
Route::get('tag', ['uses' => 'TagController@tag', 'as' => 'tag']);
Route::get('no-tag', ['uses' => 'TagController@noTag', 'as' => 'no-tag']);
// TODO Per object group, maybe in the future.
// TODO Per recurrence, all transactions created under it.
// TODO Per currency, or as a filter?
// TODO Show user net worth?
// See reference nr. 7
// See reference nr. 8
// See reference nr. 9
// See reference nr. 10
}
);
// insight in income
@@ -142,10 +142,10 @@ Route::group(
Route::get('tag', ['uses' => 'TagController@tag', 'as' => 'tag']);
Route::get('no-tag', ['uses' => 'TagController@noTag', 'as' => 'no-tag']);
// TODO Per object group, maybe in the future.
// TODO Per recurrence, all transactions created under it.
// TODO Per currency, or as a filter?
// TODO Show user net worth?
// See reference nr. 11
// See reference nr. 12
// See reference nr. 13
// See reference nr. 14
}
);
@@ -162,7 +162,7 @@ Route::group(
Route::get('no-tag', ['uses' => 'TagController@noTag', 'as' => 'no-tag']);
Route::get('total', ['uses' => 'PeriodController@total', 'as' => 'total']);
// TODO Transfers for piggies
// See reference nr. 15
}
);
/**
@@ -342,7 +342,7 @@ Route::group(
Route::delete('{recurrence}', ['uses' => 'DestroyController@destroy', 'as' => 'delete']);
Route::get('{recurrence}/transactions', ['uses' => 'ListController@transactions', 'as' => 'transactions']);
// TODO
// See reference nr. 16
Route::post('trigger', ['uses' => 'RecurrenceController@trigger', 'as' => 'trigger']);
}
);
@@ -360,9 +360,9 @@ Route::group(
Route::delete('{rule}', ['uses' => 'DestroyController@destroy', 'as' => 'delete']);
Route::get('{rule}/test', ['uses' => 'TriggerController@testRule', 'as' => 'test']);
// TODO give results back.
// See reference nr. 17
Route::post('{rule}/trigger', ['uses' => 'TriggerController@triggerRule', 'as' => 'trigger']);
// TODO rule transactions, rule bills?
// See reference nr. 18
}
);

4
routes/breadcrumbs.php
View File

@@ -1111,13 +1111,13 @@ try {
$title = limitStringLength((string)$group->title);
}
if ('opening balance' === $type) {
// TODO link to account.
// See reference nr. 1
$breadcrumbs->push($title, route('transactions.show', [$group->id]));
return;
}
if ('reconciliation' === $type) {
// TODO link to account.
// See reference nr. 2
$breadcrumbs->push($title, route('transactions.show', [$group->id]));
return;

8
routes/web.php
View File

@@ -808,7 +808,7 @@ Route::group(
'as' => 'report-data.category.',],
static function () {
// TODO three routes still in use?
// See reference nr. 3
Route::get('operations/{accountList}/{start_date}/{end_date}', ['uses' => 'CategoryController@operations', 'as' => 'operations']);
Route::get('income/{accountList}/{start_date}/{end_date}', ['uses' => 'CategoryController@income', 'as' => 'income']);
Route::get('expenses/{accountList}/{start_date}/{end_date}', ['uses' => 'CategoryController@expenses', 'as' => 'expenses']);
@@ -864,7 +864,7 @@ Route::group(
['middleware' => 'user-full-auth', 'namespace' => 'FireflyIII\Http\Controllers\Report', 'prefix' => 'report-data/budget', 'as' => 'report-data.budget.'],
static function () {
Route::get('general/{accountList}/{start_date}/{end_date}/', ['uses' => 'BudgetController@general', 'as' => 'general']);
// TODO is route still used?
// See reference nr. 4
Route::get('period/{accountList}/{start_date}/{end_date}', ['uses' => 'BudgetController@period', 'as' => 'period']);
Route::get('accounts/{accountList}/{budgetList}/{start_date}/{end_date}', ['uses' => 'BudgetController@accounts', 'as' => 'accounts']);
@@ -974,7 +974,7 @@ Route::group(
static function () {
// show groups:
// TODO improve these routes
// See reference nr. 5
Route::get('{what}/all', ['uses' => 'Transaction\IndexController@indexAll', 'as' => 'index.all'])->where(
['what' => 'withdrawal|deposit|transfers|transfer']
);
@@ -1047,7 +1047,7 @@ Route::group(
static function () {
Route::get('modal/{tj}', ['uses' => 'LinkController@modal', 'as' => 'modal']);
// TODO improve this route:
// See reference nr. 6
Route::post('store/{tj}', ['uses' => 'LinkController@store', 'as' => 'store']);
Route::get('delete/{journalLink}', ['uses' => 'LinkController@delete', 'as' => 'delete']);
Route::get('switch/{journalLink}', ['uses' => 'LinkController@switchLink', 'as' => 'switch']);