General cleanup.

app/Events/JournalCreated.php

@@ -19,7 +19,8 @@ class JournalCreated extends Event
     /**
      * Create a new event instance.
      *
-     * @return void
+     * @param TransactionJournal $journal
+     * @param                    $piggyBankId
      */
     public function __construct(TransactionJournal $journal, $piggyBankId)
     {

app/Events/JournalDeleted.php

@@ -2,6 +2,11 @@
 
 use Illuminate\Queue\SerializesModels;
 
+/**
+ * Class JournalDeleted
+ *
+ * @package FireflyIII\Events
+ */
 class JournalDeleted extends Event
 {
 
@@ -10,7 +15,6 @@ class JournalDeleted extends Event
     /**
      * Create a new event instance.
      *
-     * @return void
      */
     public function __construct()
     {

app/Events/JournalSaved.php

@@ -3,6 +3,11 @@
 use FireflyIII\Models\TransactionJournal;
 use Illuminate\Queue\SerializesModels;
 
+/**
+ * Class JournalSaved
+ *
+ * @package FireflyIII\Events
+ */
 class JournalSaved extends Event
 {
 
@@ -13,7 +18,7 @@ class JournalSaved extends Event
     /**
      * Create a new event instance.
      *
-     * @return void
+     * @param TransactionJournal $journal
      */
     public function __construct(TransactionJournal $journal)
     {

app/Helpers/Help/Help.php

@@ -54,7 +54,9 @@ class Help implements HelpInterface
     }
 
     /**
-     * @return boolean
+     * @param $route
+     *
+     * @return bool
      */
     public function hasRoute($route)
     {
@@ -62,10 +64,10 @@ class Help implements HelpInterface
     }
 
     /**
-     * @param       $title
+     * @param       $route
      * @param array $content
      *
-     * @return void
+     * @internal param $title
      */
     public function putInCache($route, array $content)
     {

app/Helpers/Help/HelpInterface.php

@@ -17,11 +17,6 @@ interface HelpInterface
      */
     public function getFromCache($key);
 
-    /**
-     * @return boolean
-     */
-    public function hasRoute($route);
-
     /**
      * @param $route
      *
@@ -31,11 +26,10 @@ interface HelpInterface
 
     /**
      * @param $route
-     * @param array $content
      *
-     * @return void
+     * @return bool
      */
-    public function putInCache($route, array $content);
+    public function hasRoute($route);
 
     /**
      * @param $route
@@ -43,4 +37,12 @@ interface HelpInterface
      * @return bool
      */
     public function inCache($route);
+
+    /**
+     * @param       $route
+     * @param array $content
+     *
+     * @return void
+     */
+    public function putInCache($route, array $content);
 }

app/Http/Controllers/AccountController.php

@@ -92,7 +92,7 @@ class AccountController extends Controller
      *
      * @return View
      */
-    public function edit(AccountRepositoryInterface $repository,Account $account)
+    public function edit(AccountRepositoryInterface $repository, Account $account)
     {
 
         $what           = Config::get('firefly.shortNamesByFullName')[$account->accountType->type];

app/Http/Controllers/BudgetController.php

@@ -267,7 +267,7 @@ class BudgetController extends Controller
         $date   = Session::get('start', Carbon::now()->startOfMonth())->format('FY');
         $amount = Preferences::get('budgetIncomeTotal' . $date, 1000);
 
-        return view('budgets.income',compact('amount'));
+        return view('budgets.income', compact('amount'));
     }
 
 }

app/Http/Controllers/CategoryController.php

@@ -97,8 +97,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * @return $this
+     * @param CategoryRepositoryInterface $repository
      *
+     * @return $this
      */
     public function index(CategoryRepositoryInterface $repository)
     {
@@ -114,6 +115,8 @@ class CategoryController extends Controller
     }
 
     /**
+     * @param CategoryRepositoryInterface $repository
+     *
      * @return \Illuminate\View\View
      */
     public function noCategory(CategoryRepositoryInterface $repository)

app/Http/Controllers/CurrencyController.php

@@ -133,6 +133,8 @@ class CurrencyController extends Controller
     }
 
     /**
+     * @param CurrencyRepositoryInterface $repository
+     *
      * @return \Illuminate\View\View
      */
     public function index(CurrencyRepositoryInterface $repository)
@@ -146,6 +148,9 @@ class CurrencyController extends Controller
     /**
      * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind.
      *
+     * @param CurrencyFormRequest         $request
+     * @param CurrencyRepositoryInterface $repository
+     *
      * @return $this|\Illuminate\Http\RedirectResponse
      */
     public function store(CurrencyFormRequest $request, CurrencyRepositoryInterface $repository)

app/Http/Controllers/GoogleChartController.php

@@ -245,6 +245,9 @@ class GoogleChartController extends Controller
     /**
      * @param GChart                     $chart
      *
+     * @param BillRepositoryInterface    $repository
+     * @param AccountRepositoryInterface $accounts
+     *
      * @return \Symfony\Component\HttpFoundation\Response
      */
     public function billsOverview(GChart $chart, BillRepositoryInterface $repository, AccountRepositoryInterface $accounts)
@@ -494,7 +497,7 @@ class GoogleChartController extends Controller
      *
      * @return \Symfony\Component\HttpFoundation\Response
      */
-    public function yearInExp(GChart $chart, ReportQueryInterface $query,$year)
+    public function yearInExp(GChart $chart, ReportQueryInterface $query, $year)
     {
         $start = new Carbon('01-01-' . $year);
         $chart->addColumn('Month', 'date');

app/Http/Controllers/HelpController.php

@@ -13,6 +13,7 @@ class HelpController extends Controller
 {
 
     /**
+     * @param HelpInterface $help
      * @param               $route
      *
      * @return \Illuminate\Http\JsonResponse

app/Http/Controllers/JsonController.php

@@ -30,6 +30,8 @@ class JsonController extends Controller
     /**
      * @param BillRepositoryInterface    $repository
      *
+     * @param AccountRepositoryInterface $accountRepository
+     *
      * @return \Symfony\Component\HttpFoundation\Response
      */
     public function boxBillsPaid(BillRepositoryInterface $repository, AccountRepositoryInterface $accountRepository)
@@ -149,6 +151,8 @@ class JsonController extends Controller
     /**
      * Returns a list of categories.
      *
+     * @param CategoryRepositoryInterface $repository
+     *
      * @return \Illuminate\Http\JsonResponse
      */
     public function categories(CategoryRepositoryInterface $repository)
@@ -166,6 +170,8 @@ class JsonController extends Controller
     /**
      * Returns a JSON list of all beneficiaries.
      *
+     * @param AccountRepositoryInterface $accountRepository
+     *
      * @return \Illuminate\Http\JsonResponse
      */
     public function expenseAccounts(AccountRepositoryInterface $accountRepository)
@@ -183,6 +189,8 @@ class JsonController extends Controller
     /**
      * Returns a JSON list of all beneficiaries.
      *
+     * @param TagRepositoryInterface $tagRepository
+     *
      * @return \Illuminate\Http\JsonResponse
      */
     public function tags(TagRepositoryInterface $tagRepository)
@@ -198,6 +206,8 @@ class JsonController extends Controller
     }
 
     /**
+     * @param AccountRepositoryInterface $accountRepository
+     *
      * @return \Illuminate\Http\JsonResponse
      */
     public function revenueAccounts(AccountRepositoryInterface $accountRepository)

app/Http/Controllers/PiggyBankController.php

@@ -40,6 +40,7 @@ class PiggyBankController extends Controller
     /**
      * Add money to piggy bank
      *
+     * @param AccountRepositoryInterface $repository
      * @param PiggyBank                  $piggyBank
      *
      * @return $this
@@ -55,6 +56,8 @@ class PiggyBankController extends Controller
     }
 
     /**
+     * @param AccountRepositoryInterface $repository
+     *
      * @return mixed
      */
     public function create(AccountRepositoryInterface $repository)
@@ -337,10 +340,11 @@ class PiggyBankController extends Controller
     }
 
     /**
+     * @param PiggyBankRepositoryInterface $repository
+     * @param PiggyBankFormRequest         $request
      * @param PiggyBank                    $piggyBank
      *
      * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind.
-     *
      * @return $this
      */
     public function update(PiggyBankRepositoryInterface $repository, PiggyBankFormRequest $request, PiggyBank $piggyBank)

app/Http/Controllers/PreferencesController.php

@@ -26,6 +26,8 @@ class PreferencesController extends Controller
     }
 
     /**
+     * @param AccountRepositoryInterface $repository
+     *
      * @return $this|\Illuminate\View\View
      */
     public function index(AccountRepositoryInterface $repository)

app/Http/Controllers/ProfileController.php

@@ -46,6 +46,8 @@ class ProfileController extends Controller
     }
 
     /**
+     * @param ProfileFormRequest $request
+     *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View
      */
     public function postChangePassword(ProfileFormRequest $request)
@@ -91,7 +93,10 @@ class ProfileController extends Controller
     }
 
     /**
+     * @param DeleteAccountFormRequest $request
      *
+     * @return \Illuminate\Http\RedirectResponse
+     * @throws \Exception
      */
     public function postDeleteAccount(DeleteAccountFormRequest $request)
     {

app/Http/Controllers/ReminderController.php

@@ -1,7 +1,5 @@
 <?php namespace FireflyIII\Http\Controllers;
 
-use Auth;
-use FireflyIII\Helpers\Reminders\ReminderHelperInterface;
 use FireflyIII\Models\Reminder;
 use FireflyIII\Repositories\Reminder\ReminderRepositoryInterface;
 use Redirect;
@@ -19,6 +17,8 @@ class ReminderController extends Controller
 
     /**
      * @param Reminder $reminder
+     *
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function act(Reminder $reminder)
     {
@@ -36,6 +36,8 @@ class ReminderController extends Controller
 
     /**
      * @param Reminder $reminder
+     *
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function dismiss(Reminder $reminder)
     {
@@ -48,7 +50,9 @@ class ReminderController extends Controller
     }
 
     /**
+     * @param ReminderRepositoryInterface $repository
      *
+     * @return \Illuminate\View\View
      */
     public function index(ReminderRepositoryInterface $repository)
     {
@@ -67,6 +71,8 @@ class ReminderController extends Controller
 
     /**
      * @param Reminder $reminder
+     *
+     * @return \Illuminate\View\View
      */
     public function show(Reminder $reminder)
     {

app/Http/Controllers/ReportController.php

@@ -1,7 +1,6 @@
 <?php namespace FireflyIII\Http\Controllers;
 
 use Carbon\Carbon;
-use Exception;
 use FireflyIII\Helpers\Report\ReportHelperInterface;
 use FireflyIII\Helpers\Report\ReportQueryInterface;
 use FireflyIII\Models\Account;
@@ -107,9 +106,9 @@ class ReportController extends Controller
     }
 
     /**
-     * @param ReportHelperInterface $helper
-     *
      * @return View
+     * @internal param ReportHelperInterface $helper
+     *
      */
     public function index()
     {
@@ -147,9 +146,10 @@ class ReportController extends Controller
      * @param Account $account
      * @param string  $year
      * @param string  $month
-     * @param ReportQueryInterface $query
      *
      * @return View
+     * @internal param ReportQueryInterface $query
+     *
      */
     public function modalLeftUnbalanced(Account $account, $year = '2014', $month = '1')
     {
@@ -164,6 +164,8 @@ class ReportController extends Controller
                 if ($count == 0) {
                     return $journal;
                 }
+
+                return null;
             }
         );
 

app/Http/Controllers/SearchController.php

@@ -12,6 +12,10 @@ class SearchController extends Controller
 {
     /**
      * Results always come in the form of an array [results, count, fullCount]
+     *
+     * @param SearchInterface $searcher
+     *
+     * @return $this
      */
     public function index(SearchInterface $searcher)
     {

app/Http/Controllers/TagController.php

@@ -92,7 +92,7 @@ class TagController extends Controller
      *
      * @return \Illuminate\Http\RedirectResponse
      */
-    public function destroy(TagRepositoryInterface $repository,Tag $tag)
+    public function destroy(TagRepositoryInterface $repository, Tag $tag)
     {
 
         $tagName = $tag->tag;
@@ -150,7 +150,7 @@ class TagController extends Controller
                 $count++;
             }
         }
-        if($count > 1) {
+        if ($count > 1) {
             $allowToAdvancePayment = false;
         }
 
@@ -170,12 +170,12 @@ class TagController extends Controller
                 $count++;
             }
         }
-        if($count > 0) {
+        if ($count > 0) {
             $allowToBalancingAct = false;
         }
 
 
-        // edit tagoptions:
+        // edit tag options:
         if ($allowToAdvancePayment === false) {
             unset($tagOptions['advancePayment']);
         }
@@ -195,6 +195,8 @@ class TagController extends Controller
 
     /**
      * @param $state
+     *
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function hideTagHelp($state)
     {
@@ -235,6 +237,10 @@ class TagController extends Controller
 
     /**
      * @param TagFormRequest         $request
+     *
+     * @param TagRepositoryInterface $repository
+     *
+     * @return $this|\Illuminate\Http\RedirectResponse
      */
     public function store(TagFormRequest $request, TagRepositoryInterface $repository)
     {

app/Http/breadcrumbs.php

@@ -9,9 +9,10 @@ use FireflyIII\Models\Category;
 use FireflyIII\Models\LimitRepetition;
 use FireflyIII\Models\PiggyBank;
 use FireflyIII\Models\Reminder;
+use FireflyIII\Models\Tag;
 use FireflyIII\Models\TransactionCurrency;
 use FireflyIII\Models\TransactionJournal;
-use FireflyIII\Models\Tag;
+
 /*
  * Back home.
  */
@@ -176,13 +177,13 @@ Breadcrumbs::register(
 Breadcrumbs::register(
     'currency.edit', function (Generator $breadcrumbs, TransactionCurrency $currency) {
     $breadcrumbs->parent('currency.index');
-    $breadcrumbs->push('Edit '.$currency->name, route('currency.edit', $currency->id));
+    $breadcrumbs->push('Edit ' . $currency->name, route('currency.edit', $currency->id));
 }
 );
 Breadcrumbs::register(
     'currency.delete', function (Generator $breadcrumbs, TransactionCurrency $currency) {
     $breadcrumbs->parent('currency.index');
-    $breadcrumbs->push('Delete '.$currency->name, route('currency.delete', $currency->id));
+    $breadcrumbs->push('Delete ' . $currency->name, route('currency.delete', $currency->id));
 }
 );
 

app/Http/routes.php

@@ -145,8 +145,8 @@ Route::bind(
     if (Auth::check()) {
         /** @var \FireflyIII\Models\Reminder $object */
         $object = Reminder::find($value);
-        if($object) {
+        if ($object) {
-            if($object->remindersable->account->user_id == Auth::user()->id) {
+            if ($object->remindersable->account->user_id == Auth::user()->id) {
                 return $object;
             }
         }
@@ -350,8 +350,13 @@ Route::group(
 
     // pop ups for budget report:
     Route::get('/reports/modal/{account}/{year}/{month}/no-budget', ['uses' => 'ReportController@modalNoBudget', 'as' => 'reports.no-budget']);
-    Route::get('/reports/modal/{account}/{year}/{month}/balanced-transfers', ['uses' => 'ReportController@modalBalancedTransfers', 'as' => 'reports.balanced-transfers']);
+    Route::get(
-    Route::get('/reports/modal/{account}/{year}/{month}/left-unbalanced', ['uses' => 'ReportController@modalLeftUnbalanced', 'as' => 'reports.left-unbalanced']);
+        '/reports/modal/{account}/{year}/{month}/balanced-transfers',
+        ['uses' => 'ReportController@modalBalancedTransfers', 'as' => 'reports.balanced-transfers']
+    );
+    Route::get(
+        '/reports/modal/{account}/{year}/{month}/left-unbalanced', ['uses' => 'ReportController@modalLeftUnbalanced', 'as' => 'reports.left-unbalanced']
+    );
 
     /**
      * Search Controller

app/Models/Account.php

@@ -51,7 +51,7 @@ class Account extends Model
         $account = Account::create($fields);
         if (is_null($account->id)) {
             // could not create account:
-            App::abort(500, 'Could not create new account with data: ' . json_encode($fields).' because ' . json_encode($account->getErrors()));
+            App::abort(500, 'Could not create new account with data: ' . json_encode($fields) . ' because ' . json_encode($account->getErrors()));
 
 
         }

app/Models/Category.php

@@ -1,9 +1,10 @@
 <?php namespace FireflyIII\Models;
 
+use App;
 use Crypt;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\SoftDeletes;
-use App;
+
 /**
  * Class Category
  *

app/Models/PiggyBank.php

@@ -14,7 +14,7 @@ class PiggyBank extends Model
     use SoftDeletes;
 
     protected $fillable
-        = ['name', 'account_id','order', 'reminder_skip', 'targetamount', 'startdate', 'targetdate', 'reminder', 'remind_me'];
+        = ['name', 'account_id', 'order', 'reminder_skip', 'targetamount', 'startdate', 'targetdate', 'reminder', 'remind_me'];
 
     /**
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo

app/Models/Reminder.php

@@ -78,6 +78,11 @@ class Reminder extends Model
         return $query->where('reminders.startdate', '=', $start->format('Y-m-d 00:00:00'))->where('reminders.enddate', '=', $end->format('Y-m-d 00:00:00'));
     }
 
+    /**
+     * @param EloquentBuilder $query
+     *
+     * @return $this
+     */
     public function scopeToday(EloquentBuilder $query)
     {
         $today = new Carbon;

app/Models/TransactionJournal.php

@@ -66,8 +66,13 @@ class TransactionJournal extends Model
                 return floatval($t->amount);
             }
         }
+
+        return 0;
     }
 
+    /**
+     * @return Account|mixed
+     */
     public function getAssetAccountAttribute()
     {
         $positive = true; // the asset account is in the transaction with the positive amount.

app/Providers/ConfigServiceProvider.php

@@ -173,7 +173,7 @@ class ConfigServiceProvider extends ServiceProvider
                             ],
                             'Form'         => [
                                 'is_safe' => [
-                                    'input', 'select', 'checkbox', 'model', 'open','radio','textarea'
+                                    'input', 'select', 'checkbox', 'model', 'open', 'radio', 'textarea'
                                 ]
                             ],
                         ],

app/Providers/EventServiceProvider.php

@@ -6,6 +6,7 @@ use FireflyIII\Models\BudgetLimit;
 use FireflyIII\Models\LimitRepetition;
 use FireflyIII\Models\PiggyBank;
 use FireflyIII\Models\PiggyBankRepetition;
+use FireflyIII\Models\Reminder;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionJournal;
 use FireflyIII\Support\Facades\Navigation;
@@ -13,7 +14,6 @@ use Illuminate\Contracts\Events\Dispatcher as DispatcherContract;
 use Illuminate\Database\QueryException;
 use Illuminate\Foundation\Support\Providers\EventServiceProvider as ServiceProvider;
 use Log;
-use FireflyIII\Models\Reminder;
 
 /**
  * Class EventServiceProvider

app/Repositories/Journal/JournalRepository.php

@@ -231,7 +231,7 @@ class JournalRepository implements JournalRepositoryInterface
             DB::table('tag_transaction_journal')->where('transaction_journal_id', $journal->id)->whereNotIn('tag_id', $ids)->delete();
         }
         // if count is zero, delete them all:
-        if(count($ids) == 0) {
+        if (count($ids) == 0) {
             DB::table('tag_transaction_journal')->where('transaction_journal_id', $journal->id)->delete();
         }
 

app/Repositories/Tag/TagRepositoryInterface.php

@@ -1,6 +1,7 @@
 <?php
 
 namespace FireflyIII\Repositories\Tag;
+
 use FireflyIII\Models\Tag;
 use FireflyIII\Models\TransactionJournal;
 use Illuminate\Support\Collection;
@@ -11,7 +12,8 @@ use Illuminate\Support\Collection;
  *
  * @package FireflyIII\Repositories\Tag
  */
-interface TagRepositoryInterface {
+interface TagRepositoryInterface
+{
 
     /**
      * @param array $data

app/Support/Twig/PiggyBank.php

@@ -2,9 +2,9 @@
 
 namespace FireflyIII\Support\Twig;
 
+use FireflyIII\Models\PiggyBank as PB;
 use Twig_Extension;
 use Twig_SimpleFunction;
-use FireflyIII\Models\PiggyBank as PB;
 
 /**
  * Class PiggyBank
@@ -26,6 +26,7 @@ class PiggyBank extends Twig_Extension
             return $piggyBank->currentRelevantRep()->currentamount;
         }
         );
+
         return $functions;
     }