kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Add feature: Firefly III can create account of the right type if you submit ID of the wrong type.

Browse Source
This commit is contained in:
James Cole
2023-01-14 07:39:51 +01:00
parent 3033b0fa7f
commit 4ccdd8f322
3 changed files with 99 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Validation/Account/DepositValidation.php
View File

@@ -106,7 +106,11 @@ trait DepositValidation
$accountIban = array_key_exists('iban', $array) ? $array['iban'] : null;
$accountNumber = array_key_exists('number', $array) ? $array['number'] : null;
Log::debug('Now in validateDepositSource', $array);
// null = we found nothing at all or didnt even search
// false = invalid results
$result = null;
// source can be any of the following types.
$validTypes = array_keys($this->combinations[$this->transactionType]);
if (null === $accountId && null === $accountName && false === $this->canCreateTypes($validTypes)) {
@@ -123,7 +127,7 @@ trait DepositValidation
$search = $this->accountRepository->find($accountId);
if (null !== $search && !in_array($search->accountType->type, $validTypes, true)) {
Log::debug(sprintf('User submitted an ID (#%d), which is a "%s", so this is not a valid source.', $accountId, $search->accountType->type));
$result = false;
Log::debug(sprintf('Firefly III accepts ID #%d as valid account data.', $accountId));
}
}