kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-22 20:16:22 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup

Browse Source
This commit is contained in:
James Cole
2022-12-31 15:54:55 +01:00
parent 7722ca2bf0
commit 4d0ff86bfa
4 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Repositories/Journal/JournalAPIRepository.php
View File

@@ -54,6 +54,8 @@ class JournalAPIRepository implements JournalAPIRepositoryInterface
}
/**
* TODO pretty sure method duplicated.
*
* Return all attachments for journal.
*
* @param TransactionJournal $journal
@@ -71,7 +73,7 @@ class JournalAPIRepository implements JournalAPIRepositoryInterface
static function (Attachment $attachment) use ($disk) {
$notes = $attachment->notes()->first();
$attachment->file_exists = $disk->exists($attachment->fileName());
$attachment->notes = $notes ? $notes->text : '';
$attachment->notes = $notes ? $notes->text : ''; // TODO should not set notes like this.
return $attachment;
}