kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-29 18:20:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix some issues that triggered in scrutinizer.

Browse Source
This commit is contained in:
James Cole
2018-07-22 21:32:58 +02:00
parent 67ea825d4a
commit 4fa5f4e5a3
42 changed files with 81 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Repositories/ImportJob/ImportJobRepository.php
View File

@@ -300,7 +300,7 @@ class ImportJobRepository implements ImportJobRepositoryInterface
$attachment->filename = $name;
$attachment->mime = 'plain/txt';
$attachment->size = \strlen($content);
$attachment->uploaded = 0;
$attachment->uploaded = false;
$attachment->save();
$encrypted = Crypt::encrypt($content);
@@ -351,7 +351,7 @@ class ImportJobRepository implements ImportJobRepositoryInterface
$attachment->filename = $name;
$attachment->mime = $file->getMimeType();
$attachment->size = $file->getSize();
$attachment->uploaded = 0;
$attachment->uploaded = false;
$attachment->save();
$fileObject = $file->openFile('r');
$fileObject->rewind();

6
app/Repositories/Rule/RuleRepository.php
View File

@@ -288,7 +288,7 @@ class RuleRepository implements RuleRepositoryInterface
$rule->rule_group_id = $data['rule_group_id'];
$rule->order = ($order + 1);
$rule->active = 1;
$rule->active = true;
$rule->strict = $data['strict'] ?? false;
$rule->stop_processing = 1 === (int)$data['stop-processing'];
$rule->title = $data['title'];
@@ -316,7 +316,7 @@ class RuleRepository implements RuleRepositoryInterface
$ruleAction = new RuleAction;
$ruleAction->rule()->associate($rule);
$ruleAction->order = $values['order'];
$ruleAction->active = 1;
$ruleAction->active = true;
$ruleAction->stop_processing = $values['stopProcessing'];
$ruleAction->action_type = $values['action'];
$ruleAction->action_value = $values['value'] ?? '';
@@ -336,7 +336,7 @@ class RuleRepository implements RuleRepositoryInterface
$ruleTrigger = new RuleTrigger;
$ruleTrigger->rule()->associate($rule);
$ruleTrigger->order = $values['order'];
$ruleTrigger->active = 1;
$ruleTrigger->active = true;
$ruleTrigger->stop_processing = $values['stopProcessing'];
$ruleTrigger->trigger_type = $values['action'];
$ruleTrigger->trigger_value = $values['value'] ?? '';