More PHP8.4 updates

This commit is contained in:
James Cole
2025-05-04 13:47:00 +02:00
parent e42107c03c
commit 51e86448c7
195 changed files with 524 additions and 715 deletions

View File

@@ -59,7 +59,7 @@ class ForgotPasswordController extends Controller
*
* @return Factory|RedirectResponse|View
*/
public function sendResetLinkEmail(Request $request, UserRepositoryInterface $repository)
public function sendResetLinkEmail(Request $request, ?UserRepositoryInterface $repository = null)
{
app('log')->info('Start of sendResetLinkEmail()');
if ('web' !== config('firefly.authentication_guard')) {

View File

@@ -89,7 +89,7 @@ class LoginController extends Controller
try {
$this->validateLogin($request);
} catch (ValidationException $e) {
} catch (ValidationException) {
// basic validation exception.
// report the failed login to the user if the count is 2 or 5.
// TODO here be warning.
@@ -220,7 +220,7 @@ class LoginController extends Controller
*
* @throws FireflyException
*/
public function showLoginForm(Request $request)
public function showLoginForm(?Request $request = null)
{
Log::channel('audit')->info('Show login form (1.1).');

View File

@@ -121,7 +121,7 @@ class RegisterController extends Controller
try {
$singleUserMode = app('fireflyconfig')->get('single_user_mode', config('firefly.configuration.single_user_mode'))->data;
} catch (ContainerExceptionInterface|NotFoundExceptionInterface $e) {
} catch (ContainerExceptionInterface|NotFoundExceptionInterface) {
$singleUserMode = true;
}
$userCount = User::count();
@@ -175,7 +175,7 @@ class RegisterController extends Controller
*
* @throws FireflyException
*/
public function showRegistrationForm(Request $request)
public function showRegistrationForm(?Request $request = null)
{
$isDemoSite = app('fireflyconfig')->get('is_demo_site', config('firefly.configuration.is_demo_site'))->data;
$pageTitle = (string) trans('firefly.register_page_title');