Fixed the last issues. Now onto code complexity.

This commit is contained in:
James Cole
2015-07-06 18:48:17 +02:00
parent cd08484a13
commit 52df2edc8f
2 changed files with 12 additions and 6 deletions

View File

@@ -143,7 +143,9 @@ class JournalRepository implements JournalRepositoryInterface
foreach ($array as $name) {
if (strlen(trim($name)) > 0) {
$tag = Tag::firstOrCreateEncrypted(['tag' => $name, 'user_id' => $journal->user_id]);
$tagRepository->connect($journal, $tag);
if (!is_null($tag)) {
$tagRepository->connect($journal, $tag);
}
}
}
}
@@ -186,19 +188,19 @@ class JournalRepository implements JournalRepositoryInterface
}
// store accounts (depends on type)
list($from, $to) = $this->storeAccounts($transactionType, $data);
list($fromAccount, $toAccount) = $this->storeAccounts($transactionType, $data);
// store accompanying transactions.
Transaction::create( // first transaction.
[
'account_id' => $from->id,
'account_id' => $fromAccount->id,
'transaction_journal_id' => $journal->id,
'amount' => $data['amount'] * -1
]
);
Transaction::create( // second transaction.
[
'account_id' => $to->id,
'account_id' => $toAccount->id,
'transaction_journal_id' => $journal->id,
'amount' => $data['amount']
]