kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Fix sloppy variable names

Browse Source
This commit is contained in:
James Cole
2022-10-02 20:23:11 +02:00
parent 6dfe93bc19
commit 536e054961
19 changed files with 85 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/TransactionRules/Actions/MoveDescriptionToNotes.php
View File

@@ -52,35 +52,35 @@ class MoveDescriptionToNotes implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var TransactionJournal $journal */
$journal = TransactionJournal::where('user_id', $journal['user_id'])->find($journal['transaction_journal_id']);
if (null === $journal) {
/** @var TransactionJournal $object */
$object = TransactionJournal::where('user_id', $journal['user_id'])->find($journal['transaction_journal_id']);
if (null === $object) {
Log::error(sprintf('No journal #%d belongs to user #%d.', $journal['transaction_journal_id'], $journal['user_id']));
return false;
}
$note = $journal->notes()->first();
$note = $object->notes()->first();
if (null === $note) {
$note = new Note;
$note->noteable()->associate($journal);
$note->noteable()->associate($object);
$note->text = '';
}
$before = $note->text;
$beforeDescription = $journal->description;
$beforeDescription = $object->description;
if ('' !== $note->text) {
$note->text = trim(sprintf("%s \n%s", $note->text, $journal->description));
$journal->description = '(no description)';
$note->text = trim(sprintf("%s \n%s", $note->text, $object->description));
$object->description = '(no description)';
}
if ('' === $note->text) {
$note->text = (string) $journal->description;
$journal->description = '(no description)';
$note->text = (string) $object->description;
$object->description = '(no description)';
}
$after = $note->text;
event(new TriggeredAuditLog($this->action->rule, $journal, 'update_description', $beforeDescription, $journal->description));
event(new TriggeredAuditLog($this->action->rule, $journal, 'update_notes', $before, $after));
event(new TriggeredAuditLog($this->action->rule, $object, 'update_description', $beforeDescription, $object->description));
event(new TriggeredAuditLog($this->action->rule, $object, 'update_notes', $before, $after));
$note->save();
$journal->save();
$object->save();
return true;
}
}