From 541d9ebdd9cbe5ecdc9c66dfd0093f49c2092be3 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 30 Jul 2016 16:29:04 +0200 Subject: [PATCH] Optimised some code. --- app/Crud/Account/AccountCrud.php | 152 ++- app/Helpers/Report/BalanceReportHelper.php | 3 +- .../Controllers/Chart/BudgetController.php | 151 ++- app/Import/Converter/AccountId.php | 13 +- app/Import/Converter/CurrencySymbol.php | 2 +- app/Import/ImportEntry.php | 11 +- public/result.html | 1195 +++++++++-------- 7 files changed, 862 insertions(+), 665 deletions(-) diff --git a/app/Crud/Account/AccountCrud.php b/app/Crud/Account/AccountCrud.php index 682b8bc162..f81bbb3263 100644 --- a/app/Crud/Account/AccountCrud.php +++ b/app/Crud/Account/AccountCrud.php @@ -11,6 +11,7 @@ declare(strict_types = 1); namespace FireflyIII\Crud\Account; +use Carbon\Carbon; use DB; use FireflyIII\Models\Account; use FireflyIII\Models\AccountMeta; @@ -233,21 +234,8 @@ class AccountCrud implements AccountCrudInterface $this->storeMetadata($newAccount, $data); } - // continue with the opposing account: if ($data['openingBalance'] != 0) { - $opposingData = [ - 'user' => $data['user'], - 'accountType' => 'initial', - 'virtualBalance' => 0, - 'name' => $data['name'] . ' initial balance', - 'active' => false, - 'iban' => '', - ]; - $opposing = $this->storeAccount($opposingData); - if (!is_null($opposing) && !is_null($newAccount)) { - $this->storeInitialBalance($newAccount, $opposing, $data); - } - + $this->storeInitialBalance($newAccount, $data); } return $newAccount; @@ -282,35 +270,7 @@ class AccountCrud implements AccountCrudInterface $account->save(); $this->updateMetadata($account, $data); - $openingBalance = $this->openingBalanceTransaction($account); - if ($data['openingBalance'] != 0) { - if (!is_null($openingBalance->id)) { - $this->updateInitialBalance($account, $openingBalance, $data); - - return $account; - } - - $type = $data['openingBalance'] < 0 ? 'expense' : 'revenue'; - $opposingData = [ - 'user' => $data['user'], - 'accountType' => $type, - 'name' => $data['name'] . ' initial balance', - 'active' => false, - 'iban' => '', - 'virtualBalance' => 0, - ]; - $opposing = $this->storeAccount($opposingData); - if (!is_null($opposing)) { - $this->storeInitialBalance($account, $opposing, $data); - } - - return $account; - - } - - if ($openingBalance) { // opening balance is zero, should we delete it? - $openingBalance->delete(); // delete existing opening balance. - } + $this->updateInitialBalance($account, $data); return $account; } @@ -359,19 +319,21 @@ class AccountCrud implements AccountCrudInterface /** * @param Account $account - * @param Account $opposing * @param array $data * * @return TransactionJournal */ - protected function storeInitialBalance(Account $account, Account $opposing, array $data): TransactionJournal + protected function storeInitialBalance(Account $account, array $data): TransactionJournal { + $amount = $data['openingBalance']; + $user = $data['user']; + $name = $data['name']; + $opposing = $this->storeOpposingAccount($amount, $user, $name); $transactionType = TransactionType::whereType(TransactionType::OPENING_BALANCE)->first(); $journal = TransactionJournal::create( [ 'user_id' => $data['user'], 'transaction_type_id' => $transactionType->id, - 'bill_id' => null, 'transaction_currency_id' => $data['openingBalanceCurrency'], 'description' => 'Initial balance for "' . $account->name . '"', 'completed' => true, @@ -382,24 +344,22 @@ class AccountCrud implements AccountCrudInterface $firstAccount = $account; $secondAccount = $opposing; - $firstAmount = $data['openingBalance']; - $secondAmount = $data['openingBalance'] * -1; + $firstAmount = $amount; + $secondAmount = $amount * -1; if ($data['openingBalance'] < 0) { $firstAccount = $opposing; $secondAccount = $account; - $firstAmount = $data['openingBalance'] * -1; - $secondAmount = $data['openingBalance']; + $firstAmount = $amount * -1; + $secondAmount = $amount; } $one = new Transaction(['account_id' => $firstAccount->id, 'transaction_journal_id' => $journal->id, 'amount' => $firstAmount]); $one->save();// first transaction: from - $two = new Transaction(['account_id' => $secondAccount->id, 'transaction_journal_id' => $journal->id, 'amount' => $secondAmount]); $two->save(); // second transaction: to return $journal; - } /** @@ -425,30 +385,32 @@ class AccountCrud implements AccountCrudInterface } /** - * @param Account $account - * @param TransactionJournal $journal - * @param array $data + * @param Account $account + * @param array $data * - * @return TransactionJournal + * @return bool */ - protected function updateInitialBalance(Account $account, TransactionJournal $journal, array $data): TransactionJournal + protected function updateInitialBalance(Account $account, array $data): bool { - $journal->date = $data['openingBalanceDate']; - $journal->save(); + $openingBalance = $this->openingBalanceTransaction($account); + if ($data['openingBalance'] != 0) { + if (!is_null($openingBalance->id)) { + $date = $data['openingBalanceDate']; + $amount = $data['openingBalance']; - /** @var Transaction $transaction */ - foreach ($journal->transactions()->get() as $transaction) { - if ($account->id == $transaction->account_id) { - $transaction->amount = $data['openingBalance']; - $transaction->save(); - } - if ($account->id != $transaction->account_id) { - $transaction->amount = $data['openingBalance'] * -1; - $transaction->save(); + return $this->updateJournal($account, $openingBalance, $date, $amount); } + + $this->storeInitialBalance($account, $data); + + return true; + } + // else, delete it: + if ($openingBalance) { // opening balance is zero, should we delete it? + $openingBalance->delete(); // delete existing opening balance. } - return $journal; + return true; } /** @@ -501,4 +463,56 @@ class AccountCrud implements AccountCrudInterface return $journal; } + + /** + * @param float $amount + * @param int $user + * @param string $name + * + * @return Account + */ + private function storeOpposingAccount(float $amount, int $user, string $name):Account + { + $type = $amount < 0 ? 'expense' : 'revenue'; + $opposingData = [ + 'user' => $user, + 'accountType' => $type, + 'name' => $name . ' initial balance', + 'active' => false, + 'iban' => '', + 'virtualBalance' => 0, + ]; + + return $this->storeAccount($opposingData); + } + + /** + * @param Account $account + * @param TransactionJournal $journal + * @param Carbon $date + * @param float $amount + * + * @return bool + */ + private function updateJournal(Account $account, TransactionJournal $journal, Carbon $date, float $amount): bool + { + // update date: + $journal->date = $date; + $journal->save(); + // update transactions: + /** @var Transaction $transaction */ + foreach ($journal->transactions()->get() as $transaction) { + if ($account->id == $transaction->account_id) { + $transaction->amount = $amount; + $transaction->save(); + } + if ($account->id != $transaction->account_id) { + $transaction->amount = $amount * -1; + $transaction->save(); + } + } + + return true; + + } } \ No newline at end of file diff --git a/app/Helpers/Report/BalanceReportHelper.php b/app/Helpers/Report/BalanceReportHelper.php index 7f936119d8..b9d37064e5 100644 --- a/app/Helpers/Report/BalanceReportHelper.php +++ b/app/Helpers/Report/BalanceReportHelper.php @@ -58,8 +58,7 @@ class BalanceReportHelper implements BalanceReportHelperInterface */ public function getBalanceReport(Carbon $start, Carbon $end, Collection $accounts): Balance { - $balance = new Balance; - // build a balance header: + $balance = new Balance; $header = new BalanceHeader; $limitRepetitions = $this->budgetRepository->getAllBudgetLimitRepetitions($start, $end); foreach ($accounts as $account) { diff --git a/app/Http/Controllers/Chart/BudgetController.php b/app/Http/Controllers/Chart/BudgetController.php index 60cc1931e6..b6a80a0b7f 100644 --- a/app/Http/Controllers/Chart/BudgetController.php +++ b/app/Http/Controllers/Chart/BudgetController.php @@ -32,9 +32,12 @@ use Response; class BudgetController extends Controller { - /** @var \FireflyIII\Generator\Chart\Budget\BudgetChartGeneratorInterface */ + /** @var BudgetChartGeneratorInterface */ protected $generator; + /** @var BudgetRepositoryInterface */ + protected $repository; + /** * */ @@ -43,6 +46,8 @@ class BudgetController extends Controller parent::__construct(); // create chart generator: $this->generator = app(BudgetChartGeneratorInterface::class); + + $this->repository = app(BudgetRepositoryInterface::class); } /** @@ -136,11 +141,9 @@ class BudgetController extends Controller /** * Shows a budget list with spent/left/overspent. * - * @param BudgetRepositoryInterface $repository - * * @return \Symfony\Component\HttpFoundation\Response */ - public function frontpage(BudgetRepositoryInterface $repository) + public function frontpage() { $start = session('start', Carbon::now()->startOfMonth()); $end = session('end', Carbon::now()->endOfMonth()); @@ -153,54 +156,26 @@ class BudgetController extends Controller if ($cache->has()) { return Response::json($cache->get()); } - $budgets = $repository->getActiveBudgets(); - $repetitions = $repository->getAllBudgetLimitRepetitions($start, $end); + $budgets = $this->repository->getActiveBudgets(); + $repetitions = $this->repository->getAllBudgetLimitRepetitions($start, $end); $allEntries = new Collection; - $format = strval(trans('config.month_and_day')); /** @var Budget $budget */ foreach ($budgets as $budget) { // get relevant repetitions: - $name = $budget->name; - $reps = $repetitions->filter( - function (LimitRepetition $repetition) use ($budget, $start, $end) { - if ($repetition->startdate < $end && $repetition->enddate > $start && $repetition->budget_id === $budget->id) { - return $repetition; - } - } - ); + $reps = $this->filterRepetitions($repetitions, $budget, $start, $end); + if ($reps->count() === 0) { - $amount = '0'; - $left = '0'; - $spent = $repository->spentInPeriod(new Collection([$budget]), new Collection, $start, $end); - $overspent = '0'; - $allEntries->push([$name, $left, $spent, $overspent, $amount, $spent]); - } - /** @var LimitRepetition $repetition */ - foreach ($reps as $repetition) { - $expenses = $repository->spentInPeriod(new Collection([$budget]), new Collection, $repetition->startdate, $repetition->enddate); - if ($reps->count() > 1) { - $name = $budget->name . ' ' . trans( - 'firefly.between_dates', - ['start' => $repetition->startdate->formatLocalized($format), 'end' => $repetition->enddate->formatLocalized($format)] - ); - } - $amount = $repetition->amount; - $left = bccomp(bcadd($amount, $expenses), '0') < 1 ? '0' : bcadd($amount, $expenses); - $spent = bccomp(bcadd($amount, $expenses), '0') < 1 ? bcmul($amount, '-1') : $expenses; - $overspent = bccomp(bcadd($amount, $expenses), '0') < 1 ? bcadd($amount, $expenses) : '0'; - $allEntries->push([$name, $left, $spent, $overspent, $amount, $spent]); + $collection = $this->spentInPeriodSingle($budget, $start, $end); + $allEntries = $allEntries->merge($collection); + continue; } + $collection = $this->spentInPeriodMulti($budget, $reps); + $allEntries = $allEntries->merge($collection); } - - $list = $repository->journalsInPeriodWithoutBudget(new Collection, $start, $end); - $sum = '0'; - /** @var TransactionJournal $entry */ - foreach ($list as $entry) { - $sum = bcadd(TransactionJournal::amount($entry), $sum); - } - $allEntries->push([trans('firefly.no_budget'), '0', '0', $sum, '0', '0']); + $entry = $this->spentInPeriodWithout($start, $end); + $allEntries->push($entry); $data = $this->generator->frontpage($allEntries); $cache->store($data); @@ -335,4 +310,94 @@ class BudgetController extends Controller return Response::json($data); } + + /** + * @param Collection $repetitions + * @param Budget $budget + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + private function filterRepetitions(Collection $repetitions, Budget $budget, Carbon $start, Carbon $end): Collection + { + + return $repetitions->filter( + function (LimitRepetition $repetition) use ($budget, $start, $end) { + if ($repetition->startdate < $end && $repetition->enddate > $start && $repetition->budget_id === $budget->id) { + return $repetition; + } + } + ); + } + + /** + * @param Budget $budget + * @param Collection $repetitions + * + * @return Collection + */ + private function spentInPeriodMulti(Budget $budget, Collection $repetitions): Collection + { + $format = strval(trans('config.month_and_day')); + $collection = new Collection; + $name = $budget->name; + /** @var LimitRepetition $repetition */ + foreach ($repetitions as $repetition) { + $expenses = $this->repository->spentInPeriod(new Collection([$budget]), new Collection, $repetition->startdate, $repetition->enddate); + + if ($repetitions->count() > 1) { + $name = $budget->name . ' ' . trans( + 'firefly.between_dates', + ['start' => $repetition->startdate->formatLocalized($format), 'end' => $repetition->enddate->formatLocalized($format)] + ); + } + $amount = $repetition->amount; + $left = bccomp(bcadd($amount, $expenses), '0') < 1 ? '0' : bcadd($amount, $expenses); + $spent = bccomp(bcadd($amount, $expenses), '0') < 1 ? bcmul($amount, '-1') : $expenses; + $overspent = bccomp(bcadd($amount, $expenses), '0') < 1 ? bcadd($amount, $expenses) : '0'; + $array = [$name, $left, $spent, $overspent, $amount, $spent]; + $collection->push($array); + } + + return $collection; + } + + /** + * @param Budget $budget + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + private function spentInPeriodSingle(Budget $budget, Carbon $start, Carbon $end): Collection + { + $collection = new Collection; + $amount = '0'; + $left = '0'; + $spent = $this->repository->spentInPeriod(new Collection([$budget]), new Collection, $start, $end); + $overspent = '0'; + $array = [$budget->name, $left, $spent, $overspent, $amount, $spent]; + $collection->push($array); + + return $collection; + } + + /** + * @param Carbon $start + * @param Carbon $end + * + * @return array + */ + private function spentInPeriodWithout(Carbon $start, Carbon $end):array + { + $list = $this->repository->journalsInPeriodWithoutBudget(new Collection, $start, $end); + $sum = '0'; + /** @var TransactionJournal $entry */ + foreach ($list as $entry) { + $sum = bcadd(TransactionJournal::amount($entry), $sum); + } + + return [trans('firefly.no_budget'), '0', '0', $sum, '0', '0']; + } } diff --git a/app/Import/Converter/AccountId.php b/app/Import/Converter/AccountId.php index 221f5e4c84..7fd0b56cf2 100644 --- a/app/Import/Converter/AccountId.php +++ b/app/Import/Converter/AccountId.php @@ -32,17 +32,13 @@ class AccountId extends BasicConverter implements ConverterInterface { $value = intval(trim($value)); Log::debug('Going to convert using AssetAccountId', ['value' => $value]); - if ($value === 0) { $this->setCertainty(0); return new Account; } - /** @var AccountCrudInterface $repository */ $repository = app(AccountCrudInterface::class, [$this->user]); - - if (isset($this->mapping[$value])) { Log::debug('Found account in mapping. Should exist.', ['value' => $value, 'map' => $this->mapping[$value]]); $account = $repository->find(intval($this->mapping[$value])); @@ -54,20 +50,15 @@ class AccountId extends BasicConverter implements ConverterInterface return $account; } } - - // not mapped? Still try to find it first: - $account = $repository->find($value); + $account = $repository->find($value);// not mapped? Still try to find it first: if (!is_null($account->id)) { $this->setCertainty(90); - Log::debug('Found account by ID ', ['id' => $account->id]); return $account; } + $this->setCertainty(0); // should not really happen. If the ID does not match FF, what is FF supposed to do? - $this->setCertainty(0); - - // should not really happen. If the ID does not match FF, what is FF supposed to do? return new Account; } diff --git a/app/Import/Converter/CurrencySymbol.php b/app/Import/Converter/CurrencySymbol.php index 00977f3349..83b86dded2 100644 --- a/app/Import/Converter/CurrencySymbol.php +++ b/app/Import/Converter/CurrencySymbol.php @@ -33,7 +33,7 @@ class CurrencySymbol extends BasicConverter implements ConverterInterface $value = trim($value); Log::debug('Going to convert using CurrencySymbol', ['value' => $value]); - if ($value === 0) { + if (strlen($value) === 0) { $this->setCertainty(0); return new TransactionCurrency; } diff --git a/app/Import/ImportEntry.php b/app/Import/ImportEntry.php index d23310646e..1cfc657669 100644 --- a/app/Import/ImportEntry.php +++ b/app/Import/ImportEntry.php @@ -24,6 +24,8 @@ class ImportEntry public $amount; + + /** * @param string $role * @param string $value @@ -34,6 +36,8 @@ class ImportEntry */ public function importValue(string $role, string $value, int $certainty, $convertedValue) { + Log::debug('Going to import', ['role' => $role, 'value' => $value, 'certainty' => $certainty]); + switch ($role) { default: Log::error('Import entry cannot handle object.', ['role' => $role]); @@ -41,11 +45,12 @@ class ImportEntry break; case 'amount': + /* + * Easy enough. + */ $this->setAmount($convertedValue); - return; - case 'account-id': - break; + return; } } diff --git a/public/result.html b/public/result.html index d28b8ce89d..db161648c9 100644 --- a/public/result.html +++ b/public/result.html @@ -4,929 +4,1052 @@ 1 /sites/firefly-iii/app/Crud/Account/AccountCrud.php -192 -The method update() has an NPath complexity of 210. The configured NPath complexity threshold is 200. +32 +The class AccountCrud has an overall complexity of 52 which is very high. The configured complexity threshold is 50. 2 -/sites/firefly-iii/app/Crud/Account/AccountCrud.php -192 -The method update() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. +/sites/firefly-iii/app/Handlers/Events/UpdateJournalConnection.php +33 +The method handle() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. 3 -/sites/firefly-iii/app/Crud/Account/AccountCrud.php -192 -The method update() has an NPath complexity of 210. The configured NPath complexity threshold is 128. - - -4 -/sites/firefly-iii/app/Crud/Account/AccountCrud.php -192 -The method update() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. - - -5 -/sites/firefly-iii/app/Helpers/Csv/Specifix/AbnAmroDescription.php -41 -The method fix() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - - -6 -/sites/firefly-iii/app/Helpers/Csv/Specifix/AbnAmroDescription.php -119 -The method parseSepaDescription() has a Cyclomatic Complexity of 9. The configured cyclomatic complexity threshold is 5. - - -7 -/sites/firefly-iii/app/Helpers/Csv/Specifix/AbnAmroDescription.php -119 -The method parseSepaDescription() has 49 lines of code. Current threshold is set to 40. Avoid really long methods. - - -8 -/sites/firefly-iii/app/Helpers/Csv/Specifix/AbnAmroDescription.php -174 -The method parseTRTPDescription() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. - - -9 -/sites/firefly-iii/app/Helpers/Csv/Specifix/AbnAmroDescription.php -174 -The method parseTRTPDescription() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 5. - - -10 -/sites/firefly-iii/app/Helpers/Csv/Specifix/AbnAmroDescription.php -174 -The method parseTRTPDescription() has 51 lines of code. Current threshold is set to 40. Avoid really long methods. - - -11 /sites/firefly-iii/app/Helpers/Report/BalanceReportHelper.php 34 The class BalanceReportHelper has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. -12 +4 /sites/firefly-iii/app/Helpers/Report/BalanceReportHelper.php -268 +267 The method removeUnusedBudgets() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -13 +5 /sites/firefly-iii/app/Helpers/Report/BudgetReportHelper.php -50 +51 +The method budgetYearOverview() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. + + +6 +/sites/firefly-iii/app/Helpers/Report/BudgetReportHelper.php +51 +The method budgetYearOverview() has 59 lines of code. Current threshold is set to 40. Avoid really long methods. + + +7 +/sites/firefly-iii/app/Helpers/Report/BudgetReportHelper.php +118 The method getBudgetReport() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -14 +8 /sites/firefly-iii/app/Helpers/Report/BudgetReportHelper.php -50 +118 The method getBudgetReport() has 57 lines of code. Current threshold is set to 40. Avoid really long methods. -15 +9 /sites/firefly-iii/app/Http/Controllers/Admin/UserController.php -30 +54 The method index() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -16 +10 /sites/firefly-iii/app/Http/Controllers/AttachmentController.php -33 -The class AttachmentController has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. +34 +The class AttachmentController has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13. -17 +11 /sites/firefly-iii/app/Http/Controllers/Auth/AuthController.php -36 -The class AuthController has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. +37 +The class AuthController has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. -18 +12 /sites/firefly-iii/app/Http/Controllers/Auth/AuthController.php -64 +65 The method login() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. -19 +13 /sites/firefly-iii/app/Http/Controllers/Auth/PasswordController.php 60 The method sendResetLinkEmail() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. -20 +14 /sites/firefly-iii/app/Http/Controllers/Auth/TwoFactorController.php 75 Avoid unused parameters such as '$request'. -21 -/sites/firefly-iii/app/Http/Controllers/CategoryController.php -34 -The class CategoryController has 11 public methods. Consider refactoring CategoryController to keep number of public methods under 10. - - -22 -/sites/firefly-iii/app/Http/Controllers/CategoryController.php -34 -The class CategoryController has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. - - -23 -/sites/firefly-iii/app/Http/Controllers/CategoryController.php -164 -The method show() has 61 lines of code. Current threshold is set to 40. Avoid really long methods. - - -24 +15 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php 32 The class BudgetController has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. - -25 -/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -56 -The method budget() has 40 lines of code. Current threshold is set to 40. Avoid really long methods. - -26 +16 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -144 -The method frontpage() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. - - -27 -/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -144 -The method frontpage() has an NPath complexity of 8036. The configured NPath complexity threshold is 200. - - -28 -/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -144 -The method frontpage() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 5. - - -29 -/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -144 -The method frontpage() has an NPath complexity of 8036. The configured NPath complexity threshold is 128. - - -30 -/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -144 -The method frontpage() has 66 lines of code. Current threshold is set to 40. Avoid really long methods. - - -31 -/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -222 +196 The method multiYear() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. - -32 + +17 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -222 +196 The method multiYear() has 60 lines of code. Current threshold is set to 40. Avoid really long methods. - -33 + +18 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -222 +196 The method multiYear has 5 parameters. Consider to reduce parameter number under 5. - -34 + +19 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -292 +266 The method period() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -35 + +20 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -292 +266 The method period() has 47 lines of code. Current threshold is set to 40. Avoid really long methods. - -36 + +21 /sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php -292 +266 The method period has 5 parameters. Consider to reduce parameter number under 5. + +22 +/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php +340 +The method spentInPeriodMulti() has an NPath complexity of 251. The configured NPath complexity threshold is 200. + -37 -/sites/firefly-iii/app/Http/Controllers/Chart/CategoryController.php -158 -The method multiYear() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. +23 +/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php +340 +The method spentInPeriodMulti() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. -38 -/sites/firefly-iii/app/Http/Controllers/Chart/CategoryController.php -158 -The method multiYear() has 63 lines of code. Current threshold is set to 40. Avoid really long methods. +24 +/sites/firefly-iii/app/Http/Controllers/Chart/BudgetController.php +340 +The method spentInPeriodMulti() has an NPath complexity of 251. The configured NPath complexity threshold is 128. -39 +25 /sites/firefly-iii/app/Http/Controllers/Chart/ReportController.php 101 The method yearInOut() has 43 lines of code. Current threshold is set to 40. Avoid really long methods. -40 +26 /sites/firefly-iii/app/Http/Controllers/Chart/ReportController.php 101 The method yearInOut has 5 parameters. Consider to reduce parameter number under 5. -41 +27 /sites/firefly-iii/app/Http/Controllers/Chart/ReportController.php 154 The method yearInOutSummarized() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. -42 +28 /sites/firefly-iii/app/Http/Controllers/Chart/ReportController.php 154 The method yearInOutSummarized has 5 parameters. Consider to reduce parameter number under 5. -43 +29 /sites/firefly-iii/app/Http/Controllers/Controller.php 30 -The class Controller has 21 children. Consider to rebalance this class hierarchy to keep number of children under 15. +The class Controller has 20 children. Consider to rebalance this class hierarchy to keep number of children under 15. -44 +30 /sites/firefly-iii/app/Http/Controllers/CurrencyController.php 31 The class CurrencyController has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. -45 +31 +/sites/firefly-iii/app/Http/Controllers/ImportController.php +50 +Avoid unused local variables such as '$importer'. + + +32 +/sites/firefly-iii/app/Http/Controllers/ImportController.php +243 +The method upload() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. + + +33 +/sites/firefly-iii/app/Http/Controllers/ImportController.php +294 +The method jobInCorrectStep() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. + + +34 /sites/firefly-iii/app/Http/Controllers/RuleController.php 36 The class RuleController has 13 public methods. Consider refactoring RuleController to keep number of public methods under 10. - -46 + +35 /sites/firefly-iii/app/Http/Controllers/RuleController.php 36 The class RuleController has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. - -47 + +36 /sites/firefly-iii/app/Http/Controllers/RuleController.php 326 Avoid using short method names like RuleController::up(). The configured minimum method name length is 3. - -48 + +37 /sites/firefly-iii/app/Http/Controllers/TagController.php 41 The class TagController has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. - -49 + +38 /sites/firefly-iii/app/Http/Controllers/TagController.php 181 The method index() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -50 + +39 /sites/firefly-iii/app/Http/Controllers/TagController.php 181 The method index() has an NPath complexity of 131. The configured NPath complexity threshold is 128. - -51 + +40 /sites/firefly-iii/app/Http/Middleware/AuthenticateTwoFactor.php 36 The method handle() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. - -52 + +41 /sites/firefly-iii/app/Http/Middleware/IsConfirmed.php 36 The method handle() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -53 + +42 /sites/firefly-iii/app/Http/Middleware/IsNotConfirmed.php 36 The method handle() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -54 + +43 /sites/firefly-iii/app/Http/Middleware/Range.php -61 +62 The method handle() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. + +44 +/sites/firefly-iii/app/Http/Middleware/Range.php +95 +The method datePicker() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. + -55 +45 +/sites/firefly-iii/app/Http/Middleware/Range.php +95 +The method datePicker() has 48 lines of code. Current threshold is set to 40. Avoid really long methods. + + +46 /sites/firefly-iii/app/Http/Middleware/RedirectIfTwoFactorAuthenticated.php 35 The method handle() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -56 + +47 /sites/firefly-iii/app/Http/Requests/Request.php 21 -The class Request has 18 children. Consider to rebalance this class hierarchy to keep number of children under 15. +The class Request has 19 children. Consider to rebalance this class hierarchy to keep number of children under 15. + + +48 +/sites/firefly-iii/app/Import/Converter/AccountId.php +31 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +49 +/sites/firefly-iii/app/Import/Converter/Amount.php +30 +The method convert() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. + + +50 +/sites/firefly-iii/app/Import/Converter/AssetAccountIban.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +51 +/sites/firefly-iii/app/Import/Converter/AssetAccountIban.php +32 +The method convert() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. + + +52 +/sites/firefly-iii/app/Import/Converter/AssetAccountName.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +53 +/sites/firefly-iii/app/Import/Converter/AssetAccountName.php +32 +The method convert() has 43 lines of code. Current threshold is set to 40. Avoid really long methods. + + +54 +/sites/firefly-iii/app/Import/Converter/AssetAccountNumber.php +33 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +55 +/sites/firefly-iii/app/Import/Converter/AssetAccountNumber.php +33 +The method convert() has 41 lines of code. Current threshold is set to 40. Avoid really long methods. + + +56 +/sites/firefly-iii/app/Import/Converter/BasicConverter.php +22 +The class BasicConverter has 26 children. Consider to rebalance this class hierarchy to keep number of children under 15. 57 +/sites/firefly-iii/app/Import/Converter/BillId.php +31 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +58 +/sites/firefly-iii/app/Import/Converter/BillId.php +31 +The method convert() has 41 lines of code. Current threshold is set to 40. Avoid really long methods. + + +59 +/sites/firefly-iii/app/Import/Converter/BillName.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +60 +/sites/firefly-iii/app/Import/Converter/BillName.php +32 +The method convert() has 53 lines of code. Current threshold is set to 40. Avoid really long methods. + + +61 +/sites/firefly-iii/app/Import/Converter/BudgetId.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +62 +/sites/firefly-iii/app/Import/Converter/BudgetName.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +63 +/sites/firefly-iii/app/Import/Converter/BudgetName.php +32 +The method convert() has 43 lines of code. Current threshold is set to 40. Avoid really long methods. + + +64 +/sites/firefly-iii/app/Import/Converter/CategoryId.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +65 +/sites/firefly-iii/app/Import/Converter/CategoryName.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +66 +/sites/firefly-iii/app/Import/Converter/CategoryName.php +32 +The method convert() has 43 lines of code. Current threshold is set to 40. Avoid really long methods. + + +67 +/sites/firefly-iii/app/Import/Converter/CurrencyId.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +68 +/sites/firefly-iii/app/Import/Converter/CurrencyName.php +31 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +69 +/sites/firefly-iii/app/Import/Converter/CurrencyName.php +31 +The method convert() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. + + +70 +/sites/firefly-iii/app/Import/Converter/CurrencySymbol.php +31 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +71 +/sites/firefly-iii/app/Import/Converter/CurrencySymbol.php +31 +The method convert() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. + + +72 +/sites/firefly-iii/app/Import/Converter/OpposingAccountIban.php +31 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +73 +/sites/firefly-iii/app/Import/Converter/OpposingAccountIban.php +31 +The method convert() has 45 lines of code. Current threshold is set to 40. Avoid really long methods. + + +74 +/sites/firefly-iii/app/Import/Converter/OpposingAccountName.php +31 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +75 +/sites/firefly-iii/app/Import/Converter/OpposingAccountName.php +31 +The method convert() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. + + +76 +/sites/firefly-iii/app/Import/Converter/OpposingAccountNumber.php +32 +The method convert() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +77 +/sites/firefly-iii/app/Import/Converter/OpposingAccountNumber.php +32 +The method convert() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. + + +78 +/sites/firefly-iii/app/Import/Converter/TagsComma.php +31 +The method convert() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. + + +79 +/sites/firefly-iii/app/Import/Converter/TagsComma.php +31 +The method convert() has 56 lines of code. Current threshold is set to 40. Avoid really long methods. + + +80 +/sites/firefly-iii/app/Import/Converter/TagsSpace.php +31 +The method convert() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. + + +81 +/sites/firefly-iii/app/Import/Converter/TagsSpace.php +31 +The method convert() has 57 lines of code. Current threshold is set to 40. Avoid really long methods. + + +82 /sites/firefly-iii/app/Jobs/MailError.php 67 The method handle() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -58 + +83 /sites/firefly-iii/app/Models/Account.php -91 +93 The method firstOrCreateEncrypted() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + +84 +/sites/firefly-iii/app/Models/Account.php +186 +The method getIbanAttribute() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + -59 +85 /sites/firefly-iii/app/Models/TransactionJournal.php 94 The class TransactionJournal has 23 public methods. Consider refactoring TransactionJournal to keep number of public methods under 10. -60 +86 /sites/firefly-iii/app/Providers/AccountServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -61 +87 /sites/firefly-iii/app/Providers/AttachmentServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -62 +88 /sites/firefly-iii/app/Providers/BillServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -63 +89 /sites/firefly-iii/app/Providers/BudgetServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -64 +90 /sites/firefly-iii/app/Providers/CategoryServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -65 +91 /sites/firefly-iii/app/Providers/CrudServiceProvider.php -46 +48 The method registerAccount() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -66 +92 /sites/firefly-iii/app/Providers/CrudServiceProvider.php -64 +68 The method registerJournal() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -67 +93 /sites/firefly-iii/app/Providers/ExportJobServiceProvider.php -32 -The method boot() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. +52 +The method exportJob() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -68 -/sites/firefly-iii/app/Providers/FireflyServiceProvider.php -36 -The class FireflyServiceProvider has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. +94 +/sites/firefly-iii/app/Providers/ExportJobServiceProvider.php +70 +The method importJob() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. -69 +95 /sites/firefly-iii/app/Providers/FireflyServiceProvider.php -58 -The method register() has 53 lines of code. Current threshold is set to 40. Avoid really long methods. +37 +The class FireflyServiceProvider has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. -70 +96 +/sites/firefly-iii/app/Providers/FireflyServiceProvider.php +59 +The method register() has 58 lines of code. Current threshold is set to 40. Avoid really long methods. + + +97 /sites/firefly-iii/app/Providers/JournalServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -71 + +98 /sites/firefly-iii/app/Providers/PiggyBankServiceProvider.php 42 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -72 + +99 /sites/firefly-iii/app/Providers/RuleGroupServiceProvider.php 42 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -73 + +100 /sites/firefly-iii/app/Providers/RuleServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -74 + +101 /sites/firefly-iii/app/Providers/TagServiceProvider.php 41 The method register() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -75 + +102 /sites/firefly-iii/app/Repositories/Account/AccountRepository.php 35 The class AccountRepository has 14 public methods. Consider refactoring AccountRepository to keep number of public methods under 10. - -76 + +103 /sites/firefly-iii/app/Repositories/Account/AccountRepository.php 41 Avoid unused private fields such as '$validFields'. - -77 -/sites/firefly-iii/app/Repositories/Account/AccountRepository.php -240 -The method getPiggyBankAccounts() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - - -78 -/sites/firefly-iii/app/Repositories/Account/AccountRepository.php -282 -The method getSavingsAccounts() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. - - -79 -/sites/firefly-iii/app/Repositories/Account/AccountRepository.php -282 -The method getSavingsAccounts() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. - - -80 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -32 -The class BudgetRepository has 11 public methods. Consider refactoring BudgetRepository to keep number of public methods under 10. - - -81 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -84 -The method firstUseDate() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - - -82 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -184 -The method journalsInPeriod() has 60 lines of code. Current threshold is set to 40. Avoid really long methods. - - -83 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -252 -The method journalsInPeriodWithoutBudget() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - - -84 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -252 -The method journalsInPeriodWithoutBudget() has 49 lines of code. Current threshold is set to 40. Avoid really long methods. - - -85 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -310 -The method spentInPeriod() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - - -86 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -310 -The method spentInPeriod() has 51 lines of code. Current threshold is set to 40. Avoid really long methods. - - -87 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -446 -The method updateLimitAmount() has 43 lines of code. Current threshold is set to 40. Avoid really long methods. - - -88 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php -446 -The method updateLimitAmount has 5 parameters. Consider to reduce parameter number under 5. - - -89 -/sites/firefly-iii/app/Repositories/Budget/BudgetRepositoryInterface.php -138 -The method updateLimitAmount has 5 parameters. Consider to reduce parameter number under 5. - - -90 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -28 -The class CategoryRepository has 13 public methods. Consider refactoring CategoryRepository to keep number of public methods under 10. - - -91 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -28 -The class CategoryRepository has an overall complexity of 52 which is very high. The configured complexity threshold is 50. - - -92 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -110 -The method firstUseDate() has a Cyclomatic Complexity of 9. The configured cyclomatic complexity threshold is 5. - - -93 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -110 -The method firstUseDate() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. - - -94 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -132 -Avoid excessively long variable names like $firstTransactionQuery. Keep variable name length under 20. - - -95 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -225 -The method journalsInPeriod() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. - - -96 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -225 -The method journalsInPeriod() has an NPath complexity of 128. The configured NPath complexity threshold is 128. - - -97 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -225 -The method journalsInPeriod() has 54 lines of code. Current threshold is set to 40. Avoid really long methods. - - -98 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -225 -The method journalsInPeriod has 5 parameters. Consider to reduce parameter number under 5. - - -99 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -288 -The method journalsInPeriodWithoutCategory() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - - -100 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -288 -The method journalsInPeriodWithoutCategory() has 53 lines of code. Current threshold is set to 40. Avoid really long methods. - - -101 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -348 -The method lastUseDate() has a Cyclomatic Complexity of 9. The configured cyclomatic complexity threshold is 5. - - -102 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -348 -The method lastUseDate() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. - - -103 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -464 -The method sumInPeriod() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. - 104 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -464 -The method sumInPeriod() has 58 lines of code. Current threshold is set to 40. Avoid really long methods. +/sites/firefly-iii/app/Repositories/Account/AccountRepository.php +247 +The method getPiggyBankAccounts() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. 105 -/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php -464 -The method sumInPeriod has 5 parameters. Consider to reduce parameter number under 5. +/sites/firefly-iii/app/Repositories/Account/AccountRepository.php +289 +The method getSavingsAccounts() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. 106 -/sites/firefly-iii/app/Repositories/Category/CategoryRepositoryInterface.php -95 -The method journalsInPeriod has 5 parameters. Consider to reduce parameter number under 5. +/sites/firefly-iii/app/Repositories/Account/AccountRepository.php +289 +The method getSavingsAccounts() has 44 lines of code. Current threshold is set to 40. Avoid really long methods. 107 -/sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -39 -The class JournalRepository has an overall complexity of 51 which is very high. The configured complexity threshold is 50. +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +32 +The class BudgetRepository has 13 public methods. Consider refactoring BudgetRepository to keep number of public methods under 10. 108 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +116 +The method firstUseDate() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +109 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +216 +The method journalsInPeriod() has 60 lines of code. Current threshold is set to 40. Avoid really long methods. + + +110 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +284 +The method journalsInPeriodWithoutBudget() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +111 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +284 +The method journalsInPeriodWithoutBudget() has 49 lines of code. Current threshold is set to 40. Avoid really long methods. + + +112 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +342 +The method spentInPeriod() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. + + +113 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +342 +The method spentInPeriod() has 51 lines of code. Current threshold is set to 40. Avoid really long methods. + + +114 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +478 +The method updateLimitAmount() has 43 lines of code. Current threshold is set to 40. Avoid really long methods. + + +115 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepository.php +478 +The method updateLimitAmount has 5 parameters. Consider to reduce parameter number under 5. + + +116 +/sites/firefly-iii/app/Repositories/Budget/BudgetRepositoryInterface.php +152 +The method updateLimitAmount has 5 parameters. Consider to reduce parameter number under 5. + + +117 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +28 +The class CategoryRepository has 14 public methods. Consider refactoring CategoryRepository to keep number of public methods under 10. + + +118 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +28 +The class CategoryRepository has an overall complexity of 55 which is very high. The configured complexity threshold is 50. + + +119 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +129 +The method firstUseDate() has a Cyclomatic Complexity of 9. The configured cyclomatic complexity threshold is 5. + + +120 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +129 +The method firstUseDate() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. + + +121 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +151 +Avoid excessively long variable names like $firstTransactionQuery. Keep variable name length under 20. + + +122 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +244 +The method journalsInPeriod() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. + + +123 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +244 +The method journalsInPeriod() has an NPath complexity of 128. The configured NPath complexity threshold is 128. + + +124 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +244 +The method journalsInPeriod() has 54 lines of code. Current threshold is set to 40. Avoid really long methods. + + +125 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +244 +The method journalsInPeriod has 5 parameters. Consider to reduce parameter number under 5. + + +126 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +307 +The method journalsInPeriodWithoutCategory() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. + + +127 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +307 +The method journalsInPeriodWithoutCategory() has 52 lines of code. Current threshold is set to 40. Avoid really long methods. + + +128 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +366 +The method lastUseDate() has a Cyclomatic Complexity of 9. The configured cyclomatic complexity threshold is 5. + + +129 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +366 +The method lastUseDate() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. + + +130 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +482 +The method sumInPeriod() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. + + +131 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +482 +The method sumInPeriod() has 58 lines of code. Current threshold is set to 40. Avoid really long methods. + + +132 +/sites/firefly-iii/app/Repositories/Category/CategoryRepository.php +482 +The method sumInPeriod has 5 parameters. Consider to reduce parameter number under 5. + + +133 +/sites/firefly-iii/app/Repositories/Category/CategoryRepositoryInterface.php +104 +The method journalsInPeriod has 5 parameters. Consider to reduce parameter number under 5. + + +134 +/sites/firefly-iii/app/Repositories/Journal/JournalRepository.php +39 +The class JournalRepository has an overall complexity of 50 which is very high. The configured complexity threshold is 50. + + +135 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php 39 The class JournalRepository has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13. - -109 + +136 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -227 +222 The method getTransactions() has 57 lines of code. Current threshold is set to 40. Avoid really long methods. - -110 + +137 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -290 +285 The method store() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -111 + +138 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -290 +285 The method store() has 64 lines of code. Current threshold is set to 40. Avoid really long methods. - -112 + +139 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -392 +387 The method update() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. - -113 + +140 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -392 +387 The method update() has 55 lines of code. Current threshold is set to 40. Avoid really long methods. - -114 + +141 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -482 +477 The method storeAccounts() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -115 + +142 /sites/firefly-iii/app/Repositories/Journal/JournalRepository.php -581 +576 The method updateTags() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -116 + +143 /sites/firefly-iii/app/Repositories/Rule/RuleRepository.php 26 The class RuleRepository has 12 public methods. Consider refactoring RuleRepository to keep number of public methods under 10. - -117 + +144 /sites/firefly-iii/app/Repositories/Tag/TagRepository.php 49 The method connect() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -118 + +145 /sites/firefly-iii/app/Repositories/Tag/TagRepository.php -150 +183 The method connectAdvancePayment() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. - -119 + +146 /sites/firefly-iii/app/Repositories/Tag/TagRepository.php -195 +228 The method connectBalancingAct() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -120 + +147 /sites/firefly-iii/app/Repositories/Tag/TagRepository.php -235 +268 The method matchAll() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. - -121 + +148 /sites/firefly-iii/app/Rules/Processor.php 179 The method triggered() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -122 + +149 /sites/firefly-iii/app/Rules/TransactionMatcher.php 57 The method findMatchingTransactions() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -123 + +150 /sites/firefly-iii/app/Rules/TransactionMatcher.php 57 The method findMatchingTransactions() has 49 lines of code. Current threshold is set to 40. Avoid really long methods. - -124 + +151 /sites/firefly-iii/app/Support/Binder/Date.php 36 The method routeBinder() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. - -125 + +152 /sites/firefly-iii/app/Support/CacheProperties.php 95 The method md5() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -126 + +153 /sites/firefly-iii/app/Support/ExpandedForm.php 29 The class ExpandedForm has 18 public methods. Consider refactoring ExpandedForm to keep number of public methods under 10. - -127 + +154 /sites/firefly-iii/app/Support/ExpandedForm.php 211 The method makeSelectList() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -128 + +155 /sites/firefly-iii/app/Support/ExpandedForm.php 236 The method makeSelectListWithEmpty() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -129 + +156 /sites/firefly-iii/app/Support/ExpandedForm.php 442 The method fillFieldValue() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. - -130 + +157 /sites/firefly-iii/app/Support/Models/TagSupport.php 31 The method tagAllowAdvance() has a Cyclomatic Complexity of 8. The configured cyclomatic complexity threshold is 5. - -131 + +158 /sites/firefly-iii/app/Support/Navigation.php 73 The method endOfPeriod() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -132 + +159 /sites/firefly-iii/app/Support/Navigation.php 73 The method endOfPeriod() has 55 lines of code. Current threshold is set to 40. Avoid really long methods. - -133 + +160 /sites/firefly-iii/app/Support/Navigation.php 213 The method startOfPeriod() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -134 + +161 /sites/firefly-iii/app/Support/Navigation.php 213 The method startOfPeriod() has 42 lines of code. Current threshold is set to 40. Avoid really long methods. - -135 + +162 /sites/firefly-iii/app/Support/Navigation.php 264 The method subtractPeriod() has 52 lines of code. Current threshold is set to 40. Avoid really long methods. - -136 + +163 /sites/firefly-iii/app/Support/Twig/Journal.php 37 The method formatAccountPerspective() has a Cyclomatic Complexity of 7. The configured cyclomatic complexity threshold is 5. - -137 + +164 /sites/firefly-iii/app/Support/Twig/Journal.php 37 The method formatAccountPerspective() has 46 lines of code. Current threshold is set to 40. Avoid really long methods. - -138 + +165 /sites/firefly-iii/app/Support/Twig/Journal.php 87 The method formatBudgetPerspective() has a Cyclomatic Complexity of 6. The configured cyclomatic complexity threshold is 5. - -139 + +166 /sites/firefly-iii/app/Support/Twig/Journal.php 239 The method journalBudgets() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -140 + +167 /sites/firefly-iii/app/Support/Twig/Journal.php 276 The method journalCategories() has a Cyclomatic Complexity of 5. The configured cyclomatic complexity threshold is 5. - -141 + +168 /sites/firefly-iii/app/User.php -58 -The class User has 16 public methods. Consider refactoring User to keep number of public methods under 10. - - -142 -/sites/firefly-iii/database/migrations/2016_02_04_144117_changes_for_v380.php -29 -Avoid using short method names like ChangesForV380::up(). The configured minimum method name length is 3. - - -143 -/sites/firefly-iii/database/migrations/2016_02_04_144117_changes_for_v380.php -29 -The method up() has 41 lines of code. Current threshold is set to 40. Avoid really long methods. - - -144 -/sites/firefly-iii/database/migrations/2016_02_24_172426_create_jobs_table.php -18 -Avoid using short method names like CreateJobsTable::up(). The configured minimum method name length is 3. - - -145 -/sites/firefly-iii/database/migrations/2016_04_08_181054_changes_for_v383.php -29 -Avoid using short method names like ChangesForV383::up(). The configured minimum method name length is 3. - - -146 -/sites/firefly-iii/database/migrations/2016_04_25_093451_changes_for_v390.php -59 -Avoid using short method names like ChangesForV390::up(). The configured minimum method name length is 3. - - -147 -/sites/firefly-iii/database/migrations/2016_04_25_093451_changes_for_v390.php -59 -The method up() has 75 lines of code. Current threshold is set to 40. Avoid really long methods. +61 +The class User has 17 public methods. Consider refactoring User to keep number of public methods under 10.

Processing errors

- - - - - - - - - - - - - + + + + + - + - + - - + + - + - - - - - - - - - - - - + + + + + + + + + + + + + + + + +
FileProblem
/sites/firefly-iii/app/Console/Commands/UpgradeFireflyInstructions.phpUnexpected token: ??, line: 56, col: 38, file: /sites/firefly-iii/app/Console/Commands/UpgradeFireflyInstructions.php.
/sites/firefly-iii/app/Helpers/Collection/Balance.phpUnexpected token: ??, line: 51, col: 37, file: /sites/firefly-iii/app/Helpers/Collection/Balance.php.
/sites/firefly-iii/app/Helpers/Collection/BalanceLine.phpUnexpected token: ??, line: 82, col: 30, file: /sites/firefly-iii/app/Helpers/Collection/BalanceLine.php.
/sites/firefly-iii/app/Helpers/Collection/BillLine.phpUnexpected token: ??, line: 45, col: 30, file: /sites/firefly-iii/app/Helpers/Collection/BillLine.php.
/sites/firefly-iii/app/Helpers/Collection/BudgetLine.phpUnexpected token: ??, line: 43, col: 30, file: /sites/firefly-iii/app/Helpers/Collection/BudgetLine.php.
/sites/firefly-iii/app/Helpers/Csv/Converter/AssetAccountIban.phpUnexpected token: DEFAULT, line: 59, col: 55, file: /sites/firefly-iii/app/Helpers/Csv/Converter/AssetAccountIban.php.
/sites/firefly-iii/app/Helpers/Csv/Converter/AssetAccountName.phpUnexpected token: DEFAULT, line: 39, col: 55, file: /sites/firefly-iii/app/Helpers/Csv/Converter/AssetAccountName.php.
/sites/firefly-iii/app/Helpers/Csv/Converter/AssetAccountNumber.phpUnexpected token: ??, line: 40, col: 31, file: /sites/firefly-iii/app/Helpers/Csv/Converter/AssetAccountNumber.php.
/sites/firefly-iii/app/Helpers/Csv/Converter/Description.phpUnexpected token: ??, line: 27, col: 51, file: /sites/firefly-iii/app/Helpers/Csv/Converter/Description.php.
/sites/firefly-iii/app/Helpers/Csv/Data.phpUnexpected token: ??, line: 70, col: 38, file: /sites/firefly-iii/app/Helpers/Csv/Data.php.
/sites/firefly-iii/app/Helpers/Csv/Importer.phpUnexpected token: ??, line: 185, col: 54, file: /sites/firefly-iii/app/Helpers/Csv/Importer.php.
/sites/firefly-iii/app/Helpers/Csv/Mapper/AssetAccount.phpUnexpected token: ??, line: 41, col: 36, file: /sites/firefly-iii/app/Helpers/Csv/Mapper/AssetAccount.php.
/sites/firefly-iii/app/Helpers/Csv/PostProcessing/Amount.phpUnexpected token: ??, line: 30, col: 55, file: /sites/firefly-iii/app/Helpers/Csv/PostProcessing/Amount.php.
/sites/firefly-iii/app/Helpers/Csv/PostProcessing/AssetAccount.phpUnexpected token: ??, line: 74, col: 62, file: /sites/firefly-iii/app/Helpers/Csv/PostProcessing/AssetAccount.php.
/sites/firefly-iii/app/Helpers/Csv/PostProcessing/Description.phpUnexpected token: ??, line: 29, col: 65, file: /sites/firefly-iii/app/Helpers/Csv/PostProcessing/Description.php.
/sites/firefly-iii/app/Helpers/Report/ReportHelper.phpUnexpected token: ??, line: 273, col: 59, file: /sites/firefly-iii/app/Helpers/Report/ReportHelper.php.
/sites/firefly-iii/app/Http/Controllers/AccountController.phpUnexpected token: ??, line: 169, col: 23, file: /sites/firefly-iii/app/Http/Controllers/AccountController.php.
/sites/firefly-iii/app/Http/Controllers/BudgetController.phpUnexpected token: DEFAULT, line: 187, col: 69, file: /sites/firefly-iii/app/Http/Controllers/BudgetController.php.
/sites/firefly-iii/app/Helpers/Csv/Importer.phpUnexpected token: ??, line: 193, col: 54, file: /sites/firefly-iii/app/Helpers/Csv/Importer.php.
/sites/firefly-iii/app/Helpers/Report/ReportHelper.phpUnexpected token: ??, line: 273, col: 59, file: /sites/firefly-iii/app/Helpers/Report/ReportHelper.php.
/sites/firefly-iii/app/Http/Controllers/AccountController.phpUnexpected token: ??, line: 169, col: 23, file: /sites/firefly-iii/app/Http/Controllers/AccountController.php.
/sites/firefly-iii/app/Http/Controllers/BudgetController.phpUnexpected token: DEFAULT, line: 189, col: 69, file: /sites/firefly-iii/app/Http/Controllers/BudgetController.php.
/sites/firefly-iii/app/Http/Controllers/CategoryController.phpUnexpected token: DEFAULT, line: 211, col: 70, file: /sites/firefly-iii/app/Http/Controllers/CategoryController.php.
/sites/firefly-iii/app/Http/Controllers/Chart/AccountController.phpUnexpected token: ??, line: 80, col: 60, file: /sites/firefly-iii/app/Http/Controllers/Chart/AccountController.php.
/sites/firefly-iii/app/Http/Controllers/CsvController.phpUnexpected token: DEFAULT, line: 202, col: 109, file: /sites/firefly-iii/app/Http/Controllers/CsvController.php.
/sites/firefly-iii/app/Http/Controllers/Chart/CategoryController.phpUnexpected token: DEFAULT, line: 68, col: 70, file: /sites/firefly-iii/app/Http/Controllers/Chart/CategoryController.php.
/sites/firefly-iii/app/Http/Controllers/ExportController.phpUnexpected token: DEFAULT, line: 107, col: 65, file: /sites/firefly-iii/app/Http/Controllers/ExportController.php.
/sites/firefly-iii/app/Http/Controllers/HomeController.phpUnexpected token: DEFAULT, line: 127, col: 73, file: /sites/firefly-iii/app/Http/Controllers/HomeController.php.
/sites/firefly-iii/app/Http/Controllers/HomeController.phpUnexpected token: DEFAULT, line: 134, col: 73, file: /sites/firefly-iii/app/Http/Controllers/HomeController.php.
/sites/firefly-iii/app/Http/Controllers/JsonController.phpUnexpected token: DEFAULT, line: 116, col: 60, file: /sites/firefly-iii/app/Http/Controllers/JsonController.php.
/sites/firefly-iii/app/Http/Controllers/PiggyBankController.phpUnexpected token: DEFAULT, line: 78, col: 93, file: /sites/firefly-iii/app/Http/Controllers/PiggyBankController.php.
/sites/firefly-iii/app/Http/Controllers/Popup/ReportController.phpUnexpected token: ??, line: 246, col: 59, file: /sites/firefly-iii/app/Http/Controllers/Popup/ReportController.php.
/sites/firefly-iii/app/Http/Controllers/PiggyBankController.phpUnexpected token: DEFAULT, line: 98, col: 93, file: /sites/firefly-iii/app/Http/Controllers/PiggyBankController.php.
/sites/firefly-iii/app/Http/Controllers/Popup/ReportController.phpUnexpected token: ??, line: 47, col: 51, file: /sites/firefly-iii/app/Http/Controllers/Popup/ReportController.php.
/sites/firefly-iii/app/Http/Controllers/PreferencesController.phpUnexpected token: DEFAULT, line: 77, col: 71, file: /sites/firefly-iii/app/Http/Controllers/PreferencesController.php.
/sites/firefly-iii/app/Http/Controllers/ReportController.phpUnexpected token: DEFAULT, line: 83, col: 60, file: /sites/firefly-iii/app/Http/Controllers/ReportController.php.
/sites/firefly-iii/app/Http/Controllers/RuleGroupController.phpUnexpected token: DEFAULT, line: 189, col: 67, file: /sites/firefly-iii/app/Http/Controllers/RuleGroupController.php.
/sites/firefly-iii/app/Http/Controllers/Transaction/MassController.phpUnexpected token: DEFAULT, line: 111, col: 92, file: /sites/firefly-iii/app/Http/Controllers/Transaction/MassController.php.
/sites/firefly-iii/app/Http/Controllers/Transaction/SplitController.phpUnexpected token: ??, line: 68, col: 67, file: /sites/firefly-iii/app/Http/Controllers/Transaction/SplitController.php.
/sites/firefly-iii/app/Http/Controllers/Transaction/SplitController.phpUnexpected token: ??, line: 72, col: 67, file: /sites/firefly-iii/app/Http/Controllers/Transaction/SplitController.php.
/sites/firefly-iii/app/Http/Controllers/TransactionController.phpUnexpected token: ??, line: 95, col: 64, file: /sites/firefly-iii/app/Http/Controllers/TransactionController.php.
/sites/firefly-iii/app/Http/Requests/JournalFormRequest.phpUnexpected token: ??, line: 43, col: 36, file: /sites/firefly-iii/app/Http/Requests/JournalFormRequest.php.
/sites/firefly-iii/app/Http/Requests/SplitJournalFormRequest.phpUnexpected token: ??, line: 40, col: 68, file: /sites/firefly-iii/app/Http/Requests/SplitJournalFormRequest.php.
/sites/firefly-iii/app/Http/Requests/TagFormRequest.phpUnexpected token: ??, line: 49, col: 36, file: /sites/firefly-iii/app/Http/Requests/TagFormRequest.php.
/sites/firefly-iii/app/Http/breadcrumbs.phpUnexpected token: ??, line: 594, col: 56, file: /sites/firefly-iii/app/Http/breadcrumbs.php.
/sites/firefly-iii/app/Models/AccountType.phpUnexpected token: DEFAULT, line: 35, col: 11, file: /sites/firefly-iii/app/Models/AccountType.php.
/sites/firefly-iii/app/Models/Tag.phpUnexpected token: ??, line: 81, col: 57, file: /sites/firefly-iii/app/Models/Tag.php.
/sites/firefly-iii/app/Repositories/Bill/BillRepository.phpUnexpected token: ??, line: 212, col: 48, file: /sites/firefly-iii/app/Repositories/Bill/BillRepository.php.
/sites/firefly-iii/app/Rules/Triggers/AmountExactly.phpUnexpected token: ??, line: 57, col: 49, file: /sites/firefly-iii/app/Rules/Triggers/AmountExactly.php.
/sites/firefly-iii/app/Rules/Triggers/AmountLess.phpUnexpected token: ??, line: 57, col: 49, file: /sites/firefly-iii/app/Rules/Triggers/AmountLess.php.
/sites/firefly-iii/app/Rules/Triggers/AmountMore.phpUnexpected token: ??, line: 57, col: 49, file: /sites/firefly-iii/app/Rules/Triggers/AmountMore.php.
/sites/firefly-iii/app/Support/Amount.phpUnexpected token: ??, line: 87, col: 61, file: /sites/firefly-iii/app/Support/Amount.php.
/sites/firefly-iii/app/Support/Migration/TestData.phpUnexpected token: ??, line: 267, col: 77, file: /sites/firefly-iii/app/Support/Migration/TestData.php.
/sites/firefly-iii/app/Support/Models/TransactionJournalSupport.phpUnexpected token: ??, line: 286, col: 52, file: /sites/firefly-iii/app/Support/Models/TransactionJournalSupport.php.
/sites/firefly-iii/app/Support/Twig/General.phpUnexpected token: ??, line: 112, col: 44, file: /sites/firefly-iii/app/Support/Twig/General.php.
/sites/firefly-iii/app/Validation/FireflyValidator.phpUnexpected token: ??, line: 84, col: 33, file: /sites/firefly-iii/app/Validation/FireflyValidator.php.
/sites/firefly-iii/app/Http/breadcrumbs.phpUnexpected token: ??, line: 573, col: 56, file: /sites/firefly-iii/app/Http/breadcrumbs.php.
/sites/firefly-iii/app/Import/Importer/CsvImporter.phpUnexpected token: DEFAULT, line: 82, col: 62, file: /sites/firefly-iii/app/Import/Importer/CsvImporter.php.
/sites/firefly-iii/app/Import/Mapper/AssetAccountIbans.phpUnexpected token: DEFAULT, line: 33, col: 59, file: /sites/firefly-iii/app/Import/Mapper/AssetAccountIbans.php.
/sites/firefly-iii/app/Import/Mapper/AssetAccounts.phpUnexpected token: DEFAULT, line: 33, col: 56, file: /sites/firefly-iii/app/Import/Mapper/AssetAccounts.php.
/sites/firefly-iii/app/Import/Mapper/OpposingAccountIbans.phpUnexpected token: DEFAULT, line: 35, col: 30, file: /sites/firefly-iii/app/Import/Mapper/OpposingAccountIbans.php.
/sites/firefly-iii/app/Import/Mapper/OpposingAccounts.phpUnexpected token: DEFAULT, line: 35, col: 30, file: /sites/firefly-iii/app/Import/Mapper/OpposingAccounts.php.
/sites/firefly-iii/app/Models/AccountType.phpUnexpected token: DEFAULT, line: 33, col: 11, file: /sites/firefly-iii/app/Models/AccountType.php.
/sites/firefly-iii/app/Models/Tag.phpUnexpected token: ??, line: 81, col: 57, file: /sites/firefly-iii/app/Models/Tag.php.
/sites/firefly-iii/app/Repositories/Bill/BillRepository.phpUnexpected token: ??, line: 233, col: 48, file: /sites/firefly-iii/app/Repositories/Bill/BillRepository.php.
/sites/firefly-iii/app/Rules/Triggers/AmountExactly.phpUnexpected token: ??, line: 57, col: 49, file: /sites/firefly-iii/app/Rules/Triggers/AmountExactly.php.
/sites/firefly-iii/app/Rules/Triggers/AmountLess.phpUnexpected token: ??, line: 57, col: 49, file: /sites/firefly-iii/app/Rules/Triggers/AmountLess.php.
/sites/firefly-iii/app/Rules/Triggers/AmountMore.phpUnexpected token: ??, line: 57, col: 49, file: /sites/firefly-iii/app/Rules/Triggers/AmountMore.php.
/sites/firefly-iii/app/Support/Amount.phpUnexpected token: ??, line: 87, col: 61, file: /sites/firefly-iii/app/Support/Amount.php.
/sites/firefly-iii/app/Support/Migration/TestData.phpUnexpected token: ??, line: 267, col: 77, file: /sites/firefly-iii/app/Support/Migration/TestData.php.
/sites/firefly-iii/app/Support/Models/TransactionJournalSupport.phpUnexpected token: ??, line: 286, col: 52, file: /sites/firefly-iii/app/Support/Models/TransactionJournalSupport.php.
/sites/firefly-iii/app/Support/Twig/General.phpUnexpected token: ??, line: 90, col: 58, file: /sites/firefly-iii/app/Support/Twig/General.php.
/sites/firefly-iii/app/Validation/FireflyValidator.phpUnexpected token: ??, line: 82, col: 33, file: /sites/firefly-iii/app/Validation/FireflyValidator.php.
\ No newline at end of file