kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-13 16:00:13 +00:00
Code Issues Projects Releases Wiki Activity

Start with level 6. [skip ci]

Browse Source
This commit is contained in:
James Cole
2025-01-04 09:34:17 +01:00
parent f4bc313d0b
commit 54d0433dd4
4 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.ci/phpstan.neon
View File

@@ -16,6 +16,8 @@ parameters:
- '#Dynamic call to static method#' # all the Laravel ORM things depend on this. - '#Dynamic call to static method#' # all the Laravel ORM things depend on this.
- identifier: varTag.nativeType - identifier: varTag.nativeType
- identifier: varTag.type - identifier: varTag.type
- identifier: missingType.iterableValue # not interesting enough to fix.
- identifier: missingType.generics # not interesting enough to fix.
# phpstan can't handle this so we ignore them. # phpstan can't handle this so we ignore them.
- '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::before#' - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::before#'
@@ -69,5 +71,5 @@ parameters:
# The level 8 is the highest level. original was 5 # The level 8 is the highest level. original was 5
# 7 is more than enough, higher just leaves NULL things. # 7 is more than enough, higher just leaves NULL things.
level: 5 level: 6

6
app/Notifications/User/UserRegistration.php
View File

@@ -41,7 +41,7 @@ class UserRegistration extends Notification
/** /**
* @SuppressWarnings("PHPMD.UnusedFormalParameter") * @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/ */
public function toArray(User $notifiable) public function toArray(User $notifiable): array
{ {
return [ return [
]; ];
@@ -50,7 +50,7 @@ class UserRegistration extends Notification
/** /**
* @SuppressWarnings("PHPMD.UnusedFormalParameter") * @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/ */
public function toMail(User $notifiable) public function toMail(User $notifiable): MailMessage
{ {
return (new MailMessage()) return (new MailMessage())
->markdown('emails.registered', ['address' => route('index')]) ->markdown('emails.registered', ['address' => route('index')])
@@ -61,7 +61,7 @@ class UserRegistration extends Notification
/** /**
* @SuppressWarnings("PHPMD.UnusedFormalParameter") * @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/ */
public function via(User $notifiable) public function via(User $notifiable): array
{ {
// other settings will not be available at this point anyway. // other settings will not be available at this point anyway.
return ['mail']; return ['mail'];

9
app/Support/FireflyConfig.php
View File

@@ -49,7 +49,7 @@ class FireflyConfig
return 1 === Configuration::where('name', $name)->count(); return 1 === Configuration::where('name', $name)->count();
} }
public function getEncrypted(string $name, $default = null): ?Configuration public function getEncrypted(string $name, mixed $default = null): ?Configuration
{ {
$result = $this->get($name, $default); $result = $this->get($name, $default);
if (null === $result) { if (null === $result) {
@@ -77,7 +77,7 @@ class FireflyConfig
* *
* @throws FireflyException * @throws FireflyException
*/ */
public function get(string $name, $default = null): ?Configuration public function get(string $name, mixed $default = null): ?Configuration
{ {
$fullName = 'ff-config-'.$name; $fullName = 'ff-config-'.$name;
if (\Cache::has($fullName)) { if (\Cache::has($fullName)) {
@@ -133,10 +133,7 @@ class FireflyConfig
return $config; return $config;
} }
/** public function getFresh(string $name, mixed $default = null): ?Configuration
* @param mixed $default
*/
public function getFresh(string $name, $default = null): ?Configuration
{ {
$config = Configuration::where('name', $name)->first(['id', 'name', 'data']); $config = Configuration::where('name', $name)->first(['id', 'name', 'data']);
if (null !== $config) { if (null !== $config) {

2
app/Support/Form/FormSupport.php
View File

@@ -34,7 +34,7 @@ use Illuminate\Support\MessageBag;
*/ */
trait FormSupport trait FormSupport
{ {
public function multiSelect(string $name, ?array $list = null, $selected = null, ?array $options = null): string public function multiSelect(string $name, ?array $list = null, mixed $selected = null, ?array $options = null): string
{ {
$list ??= []; $list ??= [];
$label = $this->label($name, $options); $label = $this->label($name, $options);