kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-04 11:43:02 +00:00
Code Issues Projects Releases Wiki Activity

Currency exchange rate will not be saved when rate is 0.

Browse Source
This commit is contained in:
James Cole
2018-03-30 06:33:04 +02:00
parent 7e51d57d21
commit 55b6d711f3
10 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Services/Currency/FixerIOv2.php
View File

@@ -92,11 +92,13 @@ class FixerIOv2 implements ExchangeRateInterface
} }
if (null !== $content) { if (null !== $content) {
$code = $toCurrency->code; $code = $toCurrency->code;
$rate = isset($content['rates'][$code]) ? $content['rates'][$code] : '0'; $rate = $content['rates'][$code] ?? 0;
} }
Log::debug('Got the following rates from Fixer: ', $content['rates'] ?? []); Log::debug('Got the following rates from Fixer: ', $content['rates'] ?? []);
$exchangeRate->rate = $rate; $exchangeRate->rate = $rate;
if ($rate !== 0) {
$exchangeRate->save(); $exchangeRate->save();
}
return $exchangeRate; return $exchangeRate;
} }

1
database/migrations/2018_03_19_141348_changes_for_v472.php
View File

@@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
use Illuminate\Database\Migrations\Migration; use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint; use Illuminate\Database\Schema\Blueprint;