mirror of
				https://github.com/firefly-iii/firefly-iii.git
				synced 2025-10-22 20:16:22 +00:00 
			
		
		
		
	Code cleanup
This commit is contained in:
		| @@ -30,19 +30,16 @@ use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| class AccountPolicy | ||||
| { | ||||
|     /** | ||||
|      * TODO needs better authentication, also for group. | ||||
|      */ | ||||
|     public function view(User $user, Account $account): bool | ||||
|     { | ||||
|         return auth()->check() && $user->id === $account->user_id; | ||||
|     } | ||||
| 
 | ||||
|     public function create(): bool | ||||
|     { | ||||
|         return auth()->check(); | ||||
|     } | ||||
| 
 | ||||
|     public function viewAccountBalances(User $user, Account $account): bool | ||||
|     { | ||||
|         return $this->view($user, $account); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Everybody can do this, but selection should limit to user. | ||||
|      * | ||||
| @@ -65,8 +62,11 @@ class AccountPolicy | ||||
|         return $this->view($user, $account); | ||||
|     } | ||||
| 
 | ||||
|     public function viewAccountBalances(User $user, Account $account): bool | ||||
|     /** | ||||
|      * TODO needs better authentication, also for group. | ||||
|      */ | ||||
|     public function view(User $user, Account $account): bool | ||||
|     { | ||||
|         return $this->view($user, $account); | ||||
|         return auth()->check() && $user->id === $account->user_id; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -38,6 +38,13 @@ class UserPolicy | ||||
|         return auth()->check() && $user->id === $account->user_id; | ||||
|     } | ||||
| 
 | ||||
|     public function viewAccounts(User $user): bool | ||||
|     { | ||||
|         return true; | ||||
| 
 | ||||
|         return auth()->check(); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Everybody can do this, but selection should limit to user. | ||||
|      * | ||||
| @@ -49,11 +56,4 @@ class UserPolicy | ||||
| 
 | ||||
|         return auth()->check(); | ||||
|     } | ||||
| 
 | ||||
|     public function viewAccounts(User $user): bool | ||||
|     { | ||||
|         return true; | ||||
| 
 | ||||
|         return auth()->check(); | ||||
|     } | ||||
| } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user