mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-11-16 22:58:09 +00:00
Improve code quality.
This commit is contained in:
@@ -60,12 +60,9 @@ class LoginController extends Controller
|
||||
}
|
||||
|
||||
/**
|
||||
* Handle a login request to the application.
|
||||
*
|
||||
* @param Request $request
|
||||
*
|
||||
* @return \Illuminate\Http\Response|\Symfony\Component\HttpFoundation\Response
|
||||
*
|
||||
* @return \Illuminate\Http\Response|\Symfony\Component\HttpFoundation\Response|void
|
||||
* @throws \Illuminate\Validation\ValidationException
|
||||
*/
|
||||
public function login(Request $request)
|
||||
@@ -78,6 +75,8 @@ class LoginController extends Controller
|
||||
if ($this->hasTooManyLoginAttempts($request)) {
|
||||
$this->fireLockoutEvent($request);
|
||||
|
||||
/** @noinspection PhpInconsistentReturnPointsInspection */
|
||||
/** @noinspection PhpVoidFunctionResultUsedInspection */
|
||||
return $this->sendLockoutResponse($request);
|
||||
}
|
||||
|
||||
@@ -85,6 +84,8 @@ class LoginController extends Controller
|
||||
// user is logged in. Save in session if the user requested session to be remembered:
|
||||
$request->session()->put('remember_login', $request->filled('remember'));
|
||||
|
||||
/** @noinspection PhpInconsistentReturnPointsInspection */
|
||||
/** @noinspection PhpVoidFunctionResultUsedInspection */
|
||||
return $this->sendLoginResponse($request);
|
||||
}
|
||||
|
||||
@@ -93,6 +94,8 @@ class LoginController extends Controller
|
||||
// user surpasses their maximum number of attempts they will get locked out.
|
||||
$this->incrementLoginAttempts($request);
|
||||
|
||||
/** @noinspection PhpInconsistentReturnPointsInspection */
|
||||
/** @noinspection PhpVoidFunctionResultUsedInspection */
|
||||
return $this->sendFailedLoginResponse($request);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user