From 58d175444b4d89471183dcdf67444b48322499f5 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 10 Sep 2025 06:43:24 +0200 Subject: [PATCH] Fix #10883 --- app/Helpers/Collector/Extensions/MetaCollection.php | 3 +++ app/Helpers/Collector/GroupCollector.php | 3 --- changelog.md | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/Helpers/Collector/Extensions/MetaCollection.php b/app/Helpers/Collector/Extensions/MetaCollection.php index f13a55dc9c..257ecc4cd2 100644 --- a/app/Helpers/Collector/Extensions/MetaCollection.php +++ b/app/Helpers/Collector/Extensions/MetaCollection.php @@ -24,6 +24,7 @@ declare(strict_types=1); namespace FireflyIII\Helpers\Collector\Extensions; +use FireflyIII\Enums\TransactionTypeEnum; use FireflyIII\Helpers\Collector\GroupCollectorInterface; use FireflyIII\Models\Bill; use FireflyIII\Models\Budget; @@ -919,6 +920,8 @@ trait MetaCollection { $this->withCategoryInformation(); $this->query->whereNull('category_transaction_journal.category_id'); + // better fix for #10507 + $this->query->whereNotIn('transaction_types.type', [ TransactionTypeEnum::OPENING_BALANCE->value]); return $this; } diff --git a/app/Helpers/Collector/GroupCollector.php b/app/Helpers/Collector/GroupCollector.php index f66ab6160d..8c3195b4c2 100644 --- a/app/Helpers/Collector/GroupCollector.php +++ b/app/Helpers/Collector/GroupCollector.php @@ -1095,9 +1095,6 @@ class GroupCollector implements GroupCollectorInterface ->whereNull('transaction_groups.deleted_at') ->whereNull('transaction_journals.deleted_at') ->whereNull('source.deleted_at') - - // #10507 ignore opening balance. - ->where('transaction_types.type', '!=', TransactionTypeEnum::OPENING_BALANCE->value) ->whereNotNull('transaction_groups.id') ->whereNull('destination.deleted_at') ->orderBy('transaction_journals.date', 'DESC') diff --git a/changelog.md b/changelog.md index f38af6dc52..0e00112877 100644 --- a/changelog.md +++ b/changelog.md @@ -29,6 +29,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - [Discussion 10846](https://github.com/orgs/firefly-iii/discussions/10846) (Add support for WebP format in attachments) started by @Idestius - [Issue 10853](https://github.com/firefly-iii/firefly-iii/issues/10853) (Failed to Send Discord Notification) reported by @pimonteiro - [Issue 10854](https://github.com/firefly-iii/firefly-iii/issues/10854) (string / null in budget causes budget page to not render) reported by @4e868df3 +- #10883 ### API