kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-22 20:16:22 +00:00
Code Issues Projects Releases Wiki Activity

Remove JSON exceptions that are not thrown anyway.

Browse Source
This commit is contained in:
James Cole
2023-12-22 07:47:13 +01:00
parent 34e22e0747
commit 58dea55d38
52 changed files with 105 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/Services/Internal/Support/AccountServiceTrait.php
View File

@@ -188,8 +188,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*
* *
* @deprecated
*/
protected function createOBGroup(Account $account, array $data): TransactionGroup
@@ -337,8 +336,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function getCurrency(int $currencyId, string $currencyCode): TransactionCurrency
{
// find currency, or use default currency instead.
@@ -362,8 +360,7 @@ trait AccountServiceTrait
* Create the opposing "credit liability" transaction for credit liabilities.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function updateCreditTransaction(Account $account, string $direction, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug(sprintf('Now in %s', __METHOD__));
@@ -419,8 +416,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function createCreditTransaction(Account $account, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug('Now going to create an createCreditTransaction.');
@@ -514,8 +510,7 @@ trait AccountServiceTrait
* Since opening balance and date can still be empty strings, it may fail.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function updateOBGroupV2(Account $account, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug(sprintf('Now in %s', __METHOD__));
@@ -571,8 +566,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function createOBGroupV2(Account $account, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug('Now going to create an OB group.');

6
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@@ -87,8 +87,7 @@ trait RecurringTransactionTrait
* Store transactions of a recurring transactions. It's complex but readable.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function createTransactions(Recurrence $recurrence, array $transactions): void
{
app('log')->debug('Now in createTransactions()');
@@ -164,8 +163,7 @@ trait RecurringTransactionTrait
}
/**
* @throws \JsonException
*/
* */
protected function findAccount(array $expectedTypes, ?int $accountId, ?string $accountName): Account
{
$result = null;