Clean up tests, test only the important things.

This commit is contained in:
James Cole
2019-04-12 04:53:18 +02:00
parent 6f063a134f
commit 5ac39dbdef
65 changed files with 464 additions and 4016 deletions

View File

@@ -51,34 +51,6 @@ class PreferencesControllerTest extends TestCase
/**
* @covers \FireflyIII\Api\V1\Controllers\PreferenceController
*/
public function testIndex(): void
{
$transformer = $this->mock(PreferenceTransformer::class);
$available = ['language', 'customFiscalYear', 'fiscalYearStart', 'currencyPreference', 'transaction_journal_optional_fields', 'frontPageAccounts',
'viewRange', 'listPageSize, twoFactorAuthEnabled',];
foreach ($available as $pref) {
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), $pref])->once();
}
// extra call for frontpage preference
$pref = new Preference;
$pref->data = [1];
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'frontPageAccounts', []])->once()
->andReturn($pref);
// mock calls to transformer:
$transformer->shouldReceive('setParameters')->withAnyArgs()->atLeast()->once();
// call API
$response = $this->get('/api/v1/preferences');
$response->assertStatus(200);
}
/**
* @covers \FireflyIII\Api\V1\Controllers\PreferenceController
* @covers \FireflyIII\Api\V1\Requests\PreferenceRequest
*/
public function testUpdateArray(): void
{
$transformer = $this->mock(PreferenceTransformer::class);
@@ -100,7 +72,6 @@ class PreferencesControllerTest extends TestCase
/**
* @covers \FireflyIII\Api\V1\Controllers\PreferenceController
* @covers \FireflyIII\Api\V1\Requests\PreferenceRequest
*/
public function testUpdateBoolean(): void
{
@@ -123,7 +94,6 @@ class PreferencesControllerTest extends TestCase
/**
* @covers \FireflyIII\Api\V1\Controllers\PreferenceController
* @covers \FireflyIII\Api\V1\Requests\PreferenceRequest
*/
public function testUpdateDefault(): void
{
@@ -146,7 +116,6 @@ class PreferencesControllerTest extends TestCase
/**
* @covers \FireflyIII\Api\V1\Controllers\PreferenceController
* @covers \FireflyIII\Api\V1\Requests\PreferenceRequest
*/
public function testUpdateInteger(): void
{