kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-20 08:30:06 +00:00
Code Issues Projects Releases Wiki Activity

Clean up tests, test only the important things.

Browse Source
This commit is contained in:
James Cole
2019-04-12 04:53:18 +02:00
parent 6f063a134f
commit 5ac39dbdef
65 changed files with 464 additions and 4016 deletions
Download Patch File Download Diff File Expand all files Collapse all files

104
tests/Api/V1/Controllers/UserControllerTest.php
View File

@@ -50,110 +50,6 @@ class UserControllerTest extends TestCase
}
/**
* Delete a user.
*
* @covers \FireflyIII\Api\V1\Controllers\UserController
* @covers \FireflyIII\Api\V1\Requests\UserRequest
*/
public function testDelete(): void
{
$userRepository = $this->mock(UserRepositoryInterface::class);
$userRepository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'owner'])->atLeast()->once()->andReturn(true);
$userRepository->shouldReceive('destroy')->once();
// call API
$response = $this->delete('/api/v1/users/2');
$response->assertStatus(204);
}
/**
* Delete a user as non admin
*
* @covers \FireflyIII\Api\V1\Controllers\UserController
* @covers \FireflyIII\Api\V1\Requests\UserRequest
*/
public function testDeleteNoAdmin(): void
{
$userRepository = $this->mock(UserRepositoryInterface::class);
$userRepository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'owner'])->atLeast()->once()->andReturn(false);
Passport::actingAs($this->emptyUser());
// create a user first:
$user = User::create(['email' => 'some@newu' . random_int(1, 10000) . 'ser.nl', 'password' => 'hello', 'blocked' => 0]);
// call API
$response = $this->delete('/api/v1/users/' . $user->id, [], ['Accept' => 'application/json']);
$response->assertStatus(302);
$this->assertDatabaseHas('users', ['id' => $user->id]);
}
/**
* Cannot delete yourself.
*
* @covers \FireflyIII\Api\V1\Controllers\UserController
* @covers \FireflyIII\Api\V1\Requests\UserRequest
*/
public function testDeleteYourself(): void
{
$userRepository = $this->mock(UserRepositoryInterface::class);
$userRepository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'owner'])->atLeast()->once()->andReturn(true);
// create a user first:
// call API
$response = $this->delete('/api/v1/users/' . $this->user()->id, [], ['Accept' => 'application/json']);
$response->assertStatus(500);
$response->assertSee('No access to method.');
}
/**
* Show list of users.
*
* @covers \FireflyIII\Api\V1\Controllers\UserController
*/
public function testIndex(): void
{
// mock stuff:
$repository = $this->mock(UserRepositoryInterface::class);
$transformer = $this->mock(UserTransformer::class);
$repository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'owner'])->once()->andReturn(true);
$repository->shouldReceive('all')->withAnyArgs()->andReturn(new Collection)->once();
$transformer->shouldReceive('setParameters')->atLeast()->once();
// test API
$response = $this->get('/api/v1/users', ['Accept' => 'application/json']);
$response->assertStatus(200);
$response->assertJson(['data' => [],]);
$response->assertJson(['meta' => ['pagination' => ['total' => 0, 'count' => 0, 'current_page' => 1, 'total_pages' => 1]],]);
$response->assertJson(['links' => ['self' => true, 'first' => true, 'last' => true,],]);
$response->assertHeader('Content-Type', 'application/vnd.api+json');
}
/**
* Show single user.
*
* @covers \FireflyIII\Api\V1\Controllers\UserController
*/
public function testShow(): void
{
$user = User::first();
$repository = $this->mock(UserRepositoryInterface::class);
$transformer = $this->mock(UserTransformer::class);
$repository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'owner'])->once()->andReturn(true);
// mock transformer
$transformer->shouldReceive('setParameters')->withAnyArgs()->atLeast()->once();
$transformer->shouldReceive('setCurrentScope')->withAnyArgs()->atLeast()->once()->andReturnSelf();
$transformer->shouldReceive('getDefaultIncludes')->withAnyArgs()->atLeast()->once()->andReturn([]);
$transformer->shouldReceive('getAvailableIncludes')->withAnyArgs()->atLeast()->once()->andReturn([]);
$transformer->shouldReceive('transform')->atLeast()->once()->andReturn(['id' => 5]);
// test API
$response = $this->get('/api/v1/users/' . $user->id, ['Accept' => 'application/json']);
$response->assertStatus(200);
}
/**
* Store new user.
*