Various PSR12 code cleanup

This commit is contained in:
James Cole
2022-12-29 19:43:43 +01:00
parent 56b9b66352
commit 5b8e01fbfb
240 changed files with 8059 additions and 7895 deletions

View File

@@ -22,6 +22,7 @@
declare(strict_types=1);
namespace Tests\Api\Models\Account;
use Laravel\Passport\Passport;
use Log;
use Tests\Objects\Field;
@@ -30,12 +31,14 @@ use Tests\Objects\TestConfiguration;
use Tests\TestCase;
use Tests\Traits\CollectsValues;
use Tests\Traits\TestHelpers;
/**
* Class UpdateControllerTest
*/
class UpdateControllerTest extends TestCase
{
use TestHelpers, CollectsValues;
use TestHelpers;
use CollectsValues;
/**
* Only create optional sets.
@@ -44,54 +47,54 @@ class UpdateControllerTest extends TestCase
*/
public function newUpdateDataProvider(): array
{
$configuration = new TestConfiguration;
$configuration = new TestConfiguration();
// optional field sets (for all test configs)
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('name', 'uuid'));
$configuration->addOptionalFieldSet('name', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('active', 'boolean'));
$configuration->addOptionalFieldSet('active', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('iban', 'iban'));
$configuration->addOptionalFieldSet('iban', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('bic', 'bic'));
$configuration->addOptionalFieldSet('bic', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('account_number', 'iban'));
$configuration->addOptionalFieldSet('account_number', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('order', 'order'));
$configuration->addOptionalFieldSet('order', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('include_net_worth', 'boolean'));
$configuration->addOptionalFieldSet('include_net_worth', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$field = Field::createBasic('virtual_balance', 'random-amount');
$field->ignorableFields = ['current_balance'];
$fieldSet->addField($field);
$configuration->addOptionalFieldSet('virtual_balance', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$field = new Field;
$field = new Field();
$field->fieldTitle = 'currency_id';
$field->fieldType = 'random-currency-id';
$field->ignorableFields = ['currency_code', 'currency_symbol', 'current_balance'];
@@ -99,9 +102,9 @@ class UpdateControllerTest extends TestCase
$fieldSet->addField($field);
$configuration->addOptionalFieldSet('currency_id', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$field = new Field;
$field = new Field();
$field->fieldTitle = 'currency_code';
$field->fieldType = 'random-currency-code';
$field->ignorableFields = ['currency_id', 'currency_symbol', 'current_balance'];
@@ -109,24 +112,24 @@ class UpdateControllerTest extends TestCase
$fieldSet->addField($field);
$configuration->addOptionalFieldSet('currency_code', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('account_role', 'random-asset-accountRole'));
$configuration->addOptionalFieldSet('account_role', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('notes', 'uuid'));
$configuration->addOptionalFieldSet('notes', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$fieldSet->addField(Field::createBasic('latitude', 'latitude'));
$fieldSet->addField(Field::createBasic('longitude', 'longitude'));
$fieldSet->addField(Field::createBasic('zoom_level', 'random-zoom_level'));
$configuration->addOptionalFieldSet('notes', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [1];
$field = Field::createBasic('opening_balance', 'random-amount');
$field->ignorableFields = ['current_balance'];
@@ -134,16 +137,16 @@ class UpdateControllerTest extends TestCase
$fieldSet->addField(Field::createBasic('opening_balance_date', 'random-past-date'));
$configuration->addOptionalFieldSet('ob', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [7];
$fieldSet->addField(Field::createBasic('account_role', 'static-ccAsset'));
$fieldSet->addField(Field::createBasic('credit_card_type', 'static-monthlyFull'));
$fieldSet->addField(Field::createBasic('monthly_payment_date', 'random-past-date'));
$configuration->addOptionalFieldSet('cc1', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [13];
$field = new Field;
$field = new Field();
$field->fieldTitle = 'liability_type';
$field->fieldType = 'random-liability-type';
$field->ignorableFields = ['account_role'];
@@ -154,10 +157,10 @@ class UpdateControllerTest extends TestCase
$fieldSet->addField(Field::createBasic('monthly_payment_date', 'null'));
$configuration->addOptionalFieldSet('liability-1', $fieldSet);
$fieldSet = new FieldSet;
$fieldSet = new FieldSet();
$fieldSet->parameters = [13];
$fieldSet->addField(Field::createBasic('interest', 'random-percentage'));
$field = new Field;
$field = new Field();
$field->fieldTitle = 'interest_period';
$field->fieldType = 'random-interest-period';
$field->ignorableFields = ['account_role'];