kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-20 19:35:16 +00:00
Code Issues Projects Releases Wiki Activity

Split controller tests.

Browse Source
This commit is contained in:
James Cole
2016-12-11 11:04:53 +01:00
parent b4eac84097
commit 5c02eaa66c
3 changed files with 39 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Http/Controllers/Transaction/SplitController.php
View File

@@ -131,6 +131,7 @@ class SplitController extends Controller
*/ */
public function update(Request $request, JournalRepositoryInterface $repository, TransactionJournal $journal) public function update(Request $request, JournalRepositoryInterface $repository, TransactionJournal $journal)
{ {
if ($this->isOpeningBalance($journal)) { if ($this->isOpeningBalance($journal)) {
return $this->redirectToAccount($journal); return $this->redirectToAccount($journal);
} }

11
app/Http/breadcrumbs.php
View File

@@ -681,15 +681,8 @@ Breadcrumbs::register(
* SPLIT * SPLIT
*/ */
Breadcrumbs::register( Breadcrumbs::register(
'transactions.edit-split', function (BreadCrumbGenerator $breadcrumbs, TransactionJournal $journal) { 'transactions.split.edit', function (BreadCrumbGenerator $breadcrumbs, TransactionJournal $journal) {
$breadcrumbs->parent('transactions.show', $journal); $breadcrumbs->parent('transactions.show', $journal);
$breadcrumbs->push(trans('breadcrumbs.edit_journal', ['description' => $journal->description]), route('transactions.edit-split', [$journal->id])); $breadcrumbs->push(trans('breadcrumbs.edit_journal', ['description' => $journal->description]), route('transactions.split.edit', [$journal->id]));
}
);
Breadcrumbs::register(
'split.journal.create', function (BreadCrumbGenerator $breadcrumbs, string $what) {
$breadcrumbs->parent('transactions.index', $what);
$breadcrumbs->push(trans('breadcrumbs.create_' . e($what)), route('split.journal.create', [$what]));
} }
); );

51
tests/acceptance/Controllers/Transaction/SplitControllerTest.php
View File

@@ -35,10 +35,11 @@ class SplitControllerTest extends TestCase
*/ */
public function testEdit() public function testEdit()
{ {
// Remove the following lines when you implement this test. $this->be($this->user());
$this->markTestIncomplete( $this->call('get', route('transactions.split.edit', [18]));
'This test has not been implemented yet.' $this->assertResponseStatus(200);
); // has bread crumb
$this->see('<ol class="breadcrumb">');
} }
/** /**
@@ -47,17 +48,37 @@ class SplitControllerTest extends TestCase
*/ */
public function testUpdate() public function testUpdate()
{ {
// Remove the following lines when you implement this test. $this->session(['transactions.edit-split.url' => 'http://localhost']);
$this->markTestIncomplete(
'This test has not been implemented yet.' $data = [
); 'id' => 18,
'what' => 'deposit',
'journal_description' => 'Updated salary',
'currency_id' => 1,
'journal_destination_account_id' => 1,
'journal_amount' => 1591,
'date' => '2014-01-24',
'tags' => '',
'transactions' => [
[
'description' => 'Split #1',
'source_account_name' => 'Job',
'amount' => 1591,
'category' => '',
],
],
];
$this->be($this->user());
$this->call('post', route('transactions.split.update', [18]), $data);
$this->assertResponseStatus(302);
$this->assertSessionHas('success');
// journal is updated?
$this->call('get', route('transactions.show', [18]));
$this->assertResponseStatus(200);
$this->see('Updated salary');
// has bread crumb
$this->see('<ol class="breadcrumb">');
} }
/**
* Tears down the fixture, for example, closes a network connection.
* This method is called after a test is executed.
*/
protected function tearDown()
{
}
} }