kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-30 10:33:30 +00:00
Code Issues Projects Releases Wiki Activity

Fix budget limit test, and a bug in the other currencies corrector.

Browse Source
This commit is contained in:
James Cole
2019-06-11 21:21:50 +02:00
parent b632405a11
commit 5f768a0525
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php
View File

@@ -205,7 +205,7 @@ class OtherCurrenciesCorrections extends Command
if (null === $transaction->transaction_currency_id) { if (null === $transaction->transaction_currency_id) {
$transaction->transaction_currency_id = $currency->id; $transaction->transaction_currency_id = $currency->id;
$transaction->save(); $transaction->save();
$this->count++; //$this->count++;
} }
// when mismatch in transaction: // when mismatch in transaction:
@@ -214,7 +214,7 @@ class OtherCurrenciesCorrections extends Command
$transaction->foreign_amount = $transaction->amount; $transaction->foreign_amount = $transaction->amount;
$transaction->transaction_currency_id = $currency->id; $transaction->transaction_currency_id = $currency->id;
$transaction->save(); $transaction->save();
$this->count++; //$this->count++;
} }
} }
); );

3
tests/Unit/Console/Commands/Upgrade/BudgetLimitCurrencyTest.php
View File

@@ -47,7 +47,10 @@ class BudgetLimitCurrencyTest extends TestCase
*/ */
public function testHandle(): void public function testHandle(): void
{ {
BudgetLimit::whereNull('transaction_currency_id')->forceDelete();
$this->artisan('firefly-iii:bl-currency') $this->artisan('firefly-iii:bl-currency')
->expectsOutput('All budget limits are correct.')
->assertExitCode(0); ->assertExitCode(0);
} }