From 5fb7635100ccddab57ac874e371bb621fc96b445 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 28 Aug 2019 16:28:14 +0200 Subject: [PATCH] Remove double lines from code. --- app/Api/V1/Controllers/AccountController.php | 1 - app/Api/V1/Controllers/AttachmentController.php | 1 - app/Api/V1/Controllers/AvailableBudgetController.php | 1 - app/Api/V1/Controllers/BillController.php | 1 - app/Api/V1/Controllers/BudgetController.php | 1 - app/Api/V1/Controllers/BudgetLimitController.php | 1 - app/Api/V1/Controllers/CategoryController.php | 1 - app/Api/V1/Controllers/CurrencyController.php | 1 - app/Api/V1/Controllers/LinkTypeController.php | 1 - app/Api/V1/Controllers/PiggyBankController.php | 1 - app/Api/V1/Controllers/UserController.php | 1 - app/Api/V1/Requests/TransactionUpdateRequest.php | 1 - app/Exceptions/GracefulNotFoundHandler.php | 1 - app/Exceptions/Handler.php | 1 - app/Generator/Chart/Basic/ChartJsGenerator.php | 1 - app/Generator/Chart/Basic/GeneratorInterface.php | 1 - app/Generator/Report/Support.php | 1 - app/Handlers/Events/VersionCheckEventHandler.php | 1 - app/Http/Controllers/Account/ShowController.php | 1 - app/Http/Controllers/BillController.php | 1 - app/Http/Controllers/Category/ShowController.php | 1 - app/Http/Controllers/Chart/AccountController.php | 3 --- app/Http/Controllers/Chart/BudgetController.php | 3 --- app/Http/Controllers/Chart/BudgetReportController.php | 1 - app/Http/Controllers/Chart/CategoryReportController.php | 1 - app/Http/Controllers/Chart/ExpenseReportController.php | 1 - app/Http/Controllers/Chart/TagReportController.php | 1 - app/Http/Controllers/Controller.php | 1 - app/Http/Controllers/DebugController.php | 1 - app/Http/Controllers/Json/AutoCompleteController.php | 1 - app/Http/Controllers/PiggyBankController.php | 2 -- app/Http/Controllers/Popup/ReportController.php | 1 - app/Http/Controllers/ProfileController.php | 1 - app/Http/Controllers/ReportController.php | 2 -- app/Http/Controllers/Rule/SelectController.php | 1 - app/Http/Controllers/Transaction/MassController.php | 1 - app/Http/Middleware/Installer.php | 1 - app/Http/Requests/RecurrenceFormRequest.php | 1 - app/Http/Requests/Request.php | 1 - app/Import/Converter/Amount.php | 3 --- app/Import/JobConfiguration/FakeJobConfiguration.php | 2 -- app/Import/JobConfiguration/FileJobConfiguration.php | 2 -- app/Import/JobConfiguration/SpectreJobConfiguration.php | 1 - app/Import/JobConfiguration/YnabJobConfiguration.php | 1 - app/Import/Routine/FakeRoutine.php | 2 -- app/Import/Routine/SpectreRoutine.php | 2 -- app/Import/Specifics/AbnAmroDescription.php | 5 ----- app/Import/Specifics/Belfius.php | 1 - app/Import/Specifics/IngBelgium.php | 1 - app/Import/Specifics/IngDescription.php | 1 - app/Import/Specifics/RabobankDescription.php | 1 - app/Import/Storage/ImportArrayStorage.php | 6 ------ app/Jobs/CreateRecurringTransactions.php | 2 -- app/Providers/FireflyServiceProvider.php | 1 - app/Repositories/Account/AccountRepository.php | 2 -- app/Repositories/Budget/BudgetRepository.php | 8 -------- app/Repositories/Category/CategoryRepository.php | 1 - app/Repositories/ImportJob/ImportJobRepository.php | 1 - app/Repositories/LinkType/LinkTypeRepository.php | 2 -- app/Repositories/PiggyBank/PiggyBankRepository.php | 2 -- app/Repositories/Rule/RuleRepository.php | 1 - app/Repositories/Tag/TagRepository.php | 1 - app/Repositories/User/UserRepository.php | 1 - app/Rules/BelongsUser.php | 3 --- app/Rules/UniqueIban.php | 1 - app/Rules/ValidRecurrenceRepetitionType.php | 1 - app/Rules/ValidRecurrenceRepetitionValue.php | 2 -- app/Services/Internal/Support/JournalServiceTrait.php | 1 - .../Internal/Support/RecurringTransactionTrait.php | 1 - app/Support/Binder/ImportProvider.php | 1 - app/Support/Http/Controllers/AugumentData.php | 8 -------- app/Support/Http/Controllers/ChartGeneration.php | 2 -- app/Support/Http/Controllers/RequestInformation.php | 1 - app/Support/Http/Controllers/UserNavigation.php | 1 - .../Import/JobConfiguration/Ynab/SelectBudgetHandler.php | 1 - app/Support/Import/Routine/Bunq/StageNewHandler.php | 1 - app/Support/Import/Routine/File/OFXProcessor.php | 1 - app/Support/Repositories/Recurring/FiltersWeekends.php | 1 - tests/Feature/Controllers/CurrencyControllerTest.php | 2 -- tests/Feature/Controllers/JavascriptControllerTest.php | 1 - .../Controllers/Transaction/BulkControllerTest.php | 1 - tests/Unit/Factory/RecurrenceFactoryTest.php | 1 - .../Import/Routine/Bunq/StageImportDataHandlerTest.php | 3 --- 83 files changed, 129 deletions(-) diff --git a/app/Api/V1/Controllers/AccountController.php b/app/Api/V1/Controllers/AccountController.php index 567c86a594..9b5d947da7 100644 --- a/app/Api/V1/Controllers/AccountController.php +++ b/app/Api/V1/Controllers/AccountController.php @@ -47,7 +47,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class AccountController. * - * */ class AccountController extends Controller { diff --git a/app/Api/V1/Controllers/AttachmentController.php b/app/Api/V1/Controllers/AttachmentController.php index 214aa2780b..9d0a1e0edf 100644 --- a/app/Api/V1/Controllers/AttachmentController.php +++ b/app/Api/V1/Controllers/AttachmentController.php @@ -45,7 +45,6 @@ use function strlen; /** * Class AttachmentController. * - * */ class AttachmentController extends Controller { diff --git a/app/Api/V1/Controllers/AvailableBudgetController.php b/app/Api/V1/Controllers/AvailableBudgetController.php index ccb7f4e398..78a922aace 100644 --- a/app/Api/V1/Controllers/AvailableBudgetController.php +++ b/app/Api/V1/Controllers/AvailableBudgetController.php @@ -42,7 +42,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class AvailableBudgetController. * - * */ class AvailableBudgetController extends Controller { diff --git a/app/Api/V1/Controllers/BillController.php b/app/Api/V1/Controllers/BillController.php index db07b34943..4988856d20 100644 --- a/app/Api/V1/Controllers/BillController.php +++ b/app/Api/V1/Controllers/BillController.php @@ -47,7 +47,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class BillController. * - * */ class BillController extends Controller { diff --git a/app/Api/V1/Controllers/BudgetController.php b/app/Api/V1/Controllers/BudgetController.php index 7b488c3472..eac5923d7a 100644 --- a/app/Api/V1/Controllers/BudgetController.php +++ b/app/Api/V1/Controllers/BudgetController.php @@ -47,7 +47,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class BudgetController. * - * */ class BudgetController extends Controller { diff --git a/app/Api/V1/Controllers/BudgetLimitController.php b/app/Api/V1/Controllers/BudgetLimitController.php index 49d1f5edfb..b212ab5472 100644 --- a/app/Api/V1/Controllers/BudgetLimitController.php +++ b/app/Api/V1/Controllers/BudgetLimitController.php @@ -46,7 +46,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class BudgetLimitController. * - * */ class BudgetLimitController extends Controller { diff --git a/app/Api/V1/Controllers/CategoryController.php b/app/Api/V1/Controllers/CategoryController.php index 56d541b38a..6270c6eaf3 100644 --- a/app/Api/V1/Controllers/CategoryController.php +++ b/app/Api/V1/Controllers/CategoryController.php @@ -44,7 +44,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class CategoryController. * - * */ class CategoryController extends Controller { diff --git a/app/Api/V1/Controllers/CurrencyController.php b/app/Api/V1/Controllers/CurrencyController.php index 28a4f96a7f..5e7f61b8a1 100644 --- a/app/Api/V1/Controllers/CurrencyController.php +++ b/app/Api/V1/Controllers/CurrencyController.php @@ -66,7 +66,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class CurrencyController. * - * */ class CurrencyController extends Controller { diff --git a/app/Api/V1/Controllers/LinkTypeController.php b/app/Api/V1/Controllers/LinkTypeController.php index 47a73122b7..8d9f915f98 100644 --- a/app/Api/V1/Controllers/LinkTypeController.php +++ b/app/Api/V1/Controllers/LinkTypeController.php @@ -45,7 +45,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class LinkTypeController. * - * */ class LinkTypeController extends Controller { diff --git a/app/Api/V1/Controllers/PiggyBankController.php b/app/Api/V1/Controllers/PiggyBankController.php index 724972bdaf..7ad2d8a6e5 100644 --- a/app/Api/V1/Controllers/PiggyBankController.php +++ b/app/Api/V1/Controllers/PiggyBankController.php @@ -42,7 +42,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class PiggyBankController. * - * */ class PiggyBankController extends Controller { diff --git a/app/Api/V1/Controllers/UserController.php b/app/Api/V1/Controllers/UserController.php index f2b4c1f96b..2cba83621b 100644 --- a/app/Api/V1/Controllers/UserController.php +++ b/app/Api/V1/Controllers/UserController.php @@ -43,7 +43,6 @@ use League\Fractal\Serializer\JsonApiSerializer; /** * Class UserController. * - * */ class UserController extends Controller { diff --git a/app/Api/V1/Requests/TransactionUpdateRequest.php b/app/Api/V1/Requests/TransactionUpdateRequest.php index 128124737e..3002ebb7a3 100644 --- a/app/Api/V1/Requests/TransactionUpdateRequest.php +++ b/app/Api/V1/Requests/TransactionUpdateRequest.php @@ -256,7 +256,6 @@ class TransactionUpdateRequest extends Request // // validate foreign currency info // $this->validateForeignCurrencyInformation($validator); // - // // // // make sure all splits have valid source + dest info diff --git a/app/Exceptions/GracefulNotFoundHandler.php b/app/Exceptions/GracefulNotFoundHandler.php index 0c863e1b9f..fc047ee06e 100644 --- a/app/Exceptions/GracefulNotFoundHandler.php +++ b/app/Exceptions/GracefulNotFoundHandler.php @@ -45,7 +45,6 @@ class GracefulNotFoundHandler extends ExceptionHandler * @param Request $request * @param Exception $exception * - * * @return mixed */ public function render($request, Exception $exception) diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php index 711e1a86b4..12f642643a 100644 --- a/app/Exceptions/Handler.php +++ b/app/Exceptions/Handler.php @@ -49,7 +49,6 @@ class Handler extends ExceptionHandler * @param Request $request * @param Exception $exception * - * * @return mixed */ public function render($request, Exception $exception) diff --git a/app/Generator/Chart/Basic/ChartJsGenerator.php b/app/Generator/Chart/Basic/ChartJsGenerator.php index c0a4e0a39c..1242272dfb 100644 --- a/app/Generator/Chart/Basic/ChartJsGenerator.php +++ b/app/Generator/Chart/Basic/ChartJsGenerator.php @@ -196,7 +196,6 @@ class ChartJsGenerator implements GeneratorInterface * Will generate a (ChartJS) compatible array from the given input. Expects this format:. * * 'label-of-entry' => value - * 'label-of-entry' => value * * @param string $setLabel * @param array $data diff --git a/app/Generator/Chart/Basic/GeneratorInterface.php b/app/Generator/Chart/Basic/GeneratorInterface.php index 75fa3e63ff..347dd7da7b 100644 --- a/app/Generator/Chart/Basic/GeneratorInterface.php +++ b/app/Generator/Chart/Basic/GeneratorInterface.php @@ -83,7 +83,6 @@ interface GeneratorInterface * Will generate a (ChartJS) compatible array from the given input. Expects this format:. * * 'label-of-entry' => value - * 'label-of-entry' => value * * @param string $setLabel * @param array $data diff --git a/app/Generator/Report/Support.php b/app/Generator/Report/Support.php index d004291fc9..1bde7afdbf 100644 --- a/app/Generator/Report/Support.php +++ b/app/Generator/Report/Support.php @@ -19,7 +19,6 @@ * along with Firefly III. If not, see . */ /** @noinspection PhpUndefinedMethodInspection */ -/** @noinspection PhpUndefinedMethodInspection */ declare(strict_types=1); namespace FireflyIII\Generator\Report; diff --git a/app/Handlers/Events/VersionCheckEventHandler.php b/app/Handlers/Events/VersionCheckEventHandler.php index 2316d040dc..58d9877afe 100644 --- a/app/Handlers/Events/VersionCheckEventHandler.php +++ b/app/Handlers/Events/VersionCheckEventHandler.php @@ -43,7 +43,6 @@ class VersionCheckEventHandler /** * Checks with GitHub to see if there is a new version. * - * * @param RequestedVersionCheckStatus $event */ public function checkForUpdates(RequestedVersionCheckStatus $event): void diff --git a/app/Http/Controllers/Account/ShowController.php b/app/Http/Controllers/Account/ShowController.php index 1413258a59..d349f6a818 100644 --- a/app/Http/Controllers/Account/ShowController.php +++ b/app/Http/Controllers/Account/ShowController.php @@ -39,7 +39,6 @@ use View; /** * Class ShowController * - * */ class ShowController extends Controller { diff --git a/app/Http/Controllers/BillController.php b/app/Http/Controllers/BillController.php index 51ee610ca0..ea42c54ff2 100644 --- a/app/Http/Controllers/BillController.php +++ b/app/Http/Controllers/BillController.php @@ -44,7 +44,6 @@ use Symfony\Component\HttpFoundation\ParameterBag; /** * Class BillController. * - * */ class BillController extends Controller { diff --git a/app/Http/Controllers/Category/ShowController.php b/app/Http/Controllers/Category/ShowController.php index 2e27a8c2eb..2c48b9d429 100644 --- a/app/Http/Controllers/Category/ShowController.php +++ b/app/Http/Controllers/Category/ShowController.php @@ -36,7 +36,6 @@ use Illuminate\Support\Collection; * * Class ShowController * - * */ class ShowController extends Controller { diff --git a/app/Http/Controllers/Chart/AccountController.php b/app/Http/Controllers/Chart/AccountController.php index ecac9a7c21..569271cbf7 100644 --- a/app/Http/Controllers/Chart/AccountController.php +++ b/app/Http/Controllers/Chart/AccountController.php @@ -43,9 +43,6 @@ use Log; /** * Class AccountController. * - * - * - * */ class AccountController extends Controller { diff --git a/app/Http/Controllers/Chart/BudgetController.php b/app/Http/Controllers/Chart/BudgetController.php index bd0dc63791..19cbbb363f 100644 --- a/app/Http/Controllers/Chart/BudgetController.php +++ b/app/Http/Controllers/Chart/BudgetController.php @@ -40,9 +40,6 @@ use Illuminate\Support\Collection; /** * Class BudgetController. * - * - * - * */ class BudgetController extends Controller { diff --git a/app/Http/Controllers/Chart/BudgetReportController.php b/app/Http/Controllers/Chart/BudgetReportController.php index 18186d2a25..641a98a138 100644 --- a/app/Http/Controllers/Chart/BudgetReportController.php +++ b/app/Http/Controllers/Chart/BudgetReportController.php @@ -39,7 +39,6 @@ use Illuminate\Support\Collection; * * Class BudgetReportController * - * */ class BudgetReportController extends Controller { diff --git a/app/Http/Controllers/Chart/CategoryReportController.php b/app/Http/Controllers/Chart/CategoryReportController.php index 6e55c7dd63..58f89dd1b6 100644 --- a/app/Http/Controllers/Chart/CategoryReportController.php +++ b/app/Http/Controllers/Chart/CategoryReportController.php @@ -189,7 +189,6 @@ class CategoryReportController extends Controller * * @return JsonResponse * - * */ public function mainChart(Collection $accounts, Collection $categories, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/ExpenseReportController.php b/app/Http/Controllers/Chart/ExpenseReportController.php index 9872ebe8e3..125c9319c3 100644 --- a/app/Http/Controllers/Chart/ExpenseReportController.php +++ b/app/Http/Controllers/Chart/ExpenseReportController.php @@ -77,7 +77,6 @@ class ExpenseReportController extends Controller * * @return JsonResponse * - * */ public function mainChart(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/TagReportController.php b/app/Http/Controllers/Chart/TagReportController.php index 3ef5b78928..72cc61a6b4 100644 --- a/app/Http/Controllers/Chart/TagReportController.php +++ b/app/Http/Controllers/Chart/TagReportController.php @@ -180,7 +180,6 @@ class TagReportController extends Controller * * @return JsonResponse * - * */ public function mainChart(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Controller.php b/app/Http/Controllers/Controller.php index 46408b0a93..269b21e90b 100644 --- a/app/Http/Controllers/Controller.php +++ b/app/Http/Controllers/Controller.php @@ -33,7 +33,6 @@ use Route; /** * Class Controller. * - * */ class Controller extends BaseController { diff --git a/app/Http/Controllers/DebugController.php b/app/Http/Controllers/DebugController.php index f95d22aec9..0ce7447027 100644 --- a/app/Http/Controllers/DebugController.php +++ b/app/Http/Controllers/DebugController.php @@ -39,7 +39,6 @@ use Route as RouteFacade; /** * Class DebugController * - * */ class DebugController extends Controller { diff --git a/app/Http/Controllers/Json/AutoCompleteController.php b/app/Http/Controllers/Json/AutoCompleteController.php index 6f6827b3db..17b1115417 100644 --- a/app/Http/Controllers/Json/AutoCompleteController.php +++ b/app/Http/Controllers/Json/AutoCompleteController.php @@ -44,7 +44,6 @@ use Log; * * TODO autocomplete for transaction types. * - * */ class AutoCompleteController extends Controller { diff --git a/app/Http/Controllers/PiggyBankController.php b/app/Http/Controllers/PiggyBankController.php index 5d4aab08b6..518d9e74dd 100644 --- a/app/Http/Controllers/PiggyBankController.php +++ b/app/Http/Controllers/PiggyBankController.php @@ -41,8 +41,6 @@ use Symfony\Component\HttpFoundation\ParameterBag; /** * Class PiggyBankController. * - * - * */ class PiggyBankController extends Controller { diff --git a/app/Http/Controllers/Popup/ReportController.php b/app/Http/Controllers/Popup/ReportController.php index 22b5c32f40..69405f6d00 100644 --- a/app/Http/Controllers/Popup/ReportController.php +++ b/app/Http/Controllers/Popup/ReportController.php @@ -31,7 +31,6 @@ use Illuminate\Http\Request; /** * Class ReportController. * - * */ class ReportController extends Controller { diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php index 37e161cd58..49c70704f8 100644 --- a/app/Http/Controllers/ProfileController.php +++ b/app/Http/Controllers/ProfileController.php @@ -52,7 +52,6 @@ use PragmaRX\Recovery\Recovery; * * @method Guard guard() * - * */ class ProfileController extends Controller { diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php index 9a1c9b2272..215cf69537 100644 --- a/app/Http/Controllers/ReportController.php +++ b/app/Http/Controllers/ReportController.php @@ -38,7 +38,6 @@ use Log; /** * Class ReportController. * - * */ class ReportController extends Controller { @@ -310,7 +309,6 @@ class ReportController extends Controller * * @throws \FireflyIII\Exceptions\FireflyException * - * */ public function postIndex(ReportFormRequest $request) { diff --git a/app/Http/Controllers/Rule/SelectController.php b/app/Http/Controllers/Rule/SelectController.php index a37b526533..0ce060de02 100644 --- a/app/Http/Controllers/Rule/SelectController.php +++ b/app/Http/Controllers/Rule/SelectController.php @@ -47,7 +47,6 @@ use Throwable; /** * Class SelectController. * - * */ class SelectController extends Controller { diff --git a/app/Http/Controllers/Transaction/MassController.php b/app/Http/Controllers/Transaction/MassController.php index 7fb91b005e..6d8ef459ca 100644 --- a/app/Http/Controllers/Transaction/MassController.php +++ b/app/Http/Controllers/Transaction/MassController.php @@ -42,7 +42,6 @@ use Log; /** * Class MassController. * - * */ class MassController extends Controller { diff --git a/app/Http/Middleware/Installer.php b/app/Http/Middleware/Installer.php index 808ff6ccc9..c0eb2a8ec9 100644 --- a/app/Http/Middleware/Installer.php +++ b/app/Http/Middleware/Installer.php @@ -46,7 +46,6 @@ class Installer * * @return mixed * - * * @throws FireflyException * */ diff --git a/app/Http/Requests/RecurrenceFormRequest.php b/app/Http/Requests/RecurrenceFormRequest.php index 8893aaeee8..572cefdc9b 100644 --- a/app/Http/Requests/RecurrenceFormRequest.php +++ b/app/Http/Requests/RecurrenceFormRequest.php @@ -139,7 +139,6 @@ class RecurrenceFormRequest extends Request * @return array * @throws FireflyException * - * */ public function rules(): array { diff --git a/app/Http/Requests/Request.php b/app/Http/Requests/Request.php index f68da39153..2cd541c3da 100644 --- a/app/Http/Requests/Request.php +++ b/app/Http/Requests/Request.php @@ -33,7 +33,6 @@ use Log; * * @codeCoverageIgnore * - * */ class Request extends FormRequest { diff --git a/app/Import/Converter/Amount.php b/app/Import/Converter/Amount.php index c87fa7cd95..5df450e838 100644 --- a/app/Import/Converter/Amount.php +++ b/app/Import/Converter/Amount.php @@ -33,9 +33,6 @@ class Amount implements ConverterInterface * Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems. * - Jamie Zawinski. * - * - * - * * @param $value * * @return string diff --git a/app/Import/JobConfiguration/FakeJobConfiguration.php b/app/Import/JobConfiguration/FakeJobConfiguration.php index a515270a03..818aba3c18 100644 --- a/app/Import/JobConfiguration/FakeJobConfiguration.php +++ b/app/Import/JobConfiguration/FakeJobConfiguration.php @@ -70,7 +70,6 @@ class FakeJobConfiguration implements JobConfigurationInterface * * @return MessageBag * - * */ public function configureJob(array $data): MessageBag { @@ -128,7 +127,6 @@ class FakeJobConfiguration implements JobConfigurationInterface * * @return string * - * */ public function getNextView(): string { diff --git a/app/Import/JobConfiguration/FileJobConfiguration.php b/app/Import/JobConfiguration/FileJobConfiguration.php index 9eb1aa4f75..1a871ee5ca 100644 --- a/app/Import/JobConfiguration/FileJobConfiguration.php +++ b/app/Import/JobConfiguration/FileJobConfiguration.php @@ -91,7 +91,6 @@ class FileJobConfiguration implements JobConfigurationInterface * * @return string * - * *@throws FireflyException */ public function getNextView(): string @@ -132,7 +131,6 @@ class FileJobConfiguration implements JobConfigurationInterface * @return FileConfigurationInterface * @throws FireflyException * - * */ private function getConfigurationObject(): FileConfigurationInterface { diff --git a/app/Import/JobConfiguration/SpectreJobConfiguration.php b/app/Import/JobConfiguration/SpectreJobConfiguration.php index 7f9bf1dea3..c0a3ebc0a2 100644 --- a/app/Import/JobConfiguration/SpectreJobConfiguration.php +++ b/app/Import/JobConfiguration/SpectreJobConfiguration.php @@ -111,7 +111,6 @@ class SpectreJobConfiguration implements JobConfigurationInterface * @return SpectreJobConfigurationInterface * @throws FireflyException * - * */ private function getHandler(): SpectreJobConfigurationInterface { diff --git a/app/Import/JobConfiguration/YnabJobConfiguration.php b/app/Import/JobConfiguration/YnabJobConfiguration.php index 803867e397..8bf63dcbbe 100644 --- a/app/Import/JobConfiguration/YnabJobConfiguration.php +++ b/app/Import/JobConfiguration/YnabJobConfiguration.php @@ -109,7 +109,6 @@ class YnabJobConfiguration implements JobConfigurationInterface * @return YnabJobConfigurationInterface * @throws FireflyException * - * */ private function getHandler(): YnabJobConfigurationInterface { diff --git a/app/Import/Routine/FakeRoutine.php b/app/Import/Routine/FakeRoutine.php index e271a4b1d2..75ecc04011 100644 --- a/app/Import/Routine/FakeRoutine.php +++ b/app/Import/Routine/FakeRoutine.php @@ -52,8 +52,6 @@ class FakeRoutine implements RoutineInterface * @return void * @throws FireflyException * - * - * */ public function run(): void { diff --git a/app/Import/Routine/SpectreRoutine.php b/app/Import/Routine/SpectreRoutine.php index 1171ff5e5e..334d78f6f3 100644 --- a/app/Import/Routine/SpectreRoutine.php +++ b/app/Import/Routine/SpectreRoutine.php @@ -49,8 +49,6 @@ class SpectreRoutine implements RoutineInterface * * @throws FireflyException * - * - * */ public function run(): void { diff --git a/app/Import/Specifics/AbnAmroDescription.php b/app/Import/Specifics/AbnAmroDescription.php index 68b1b1e318..2773023e01 100644 --- a/app/Import/Specifics/AbnAmroDescription.php +++ b/app/Import/Specifics/AbnAmroDescription.php @@ -64,7 +64,6 @@ class AbnAmroDescription implements SpecificInterface * * @return array * - * */ public function run(array $row): array { @@ -132,8 +131,6 @@ class AbnAmroDescription implements SpecificInterface * * @return bool true if the description is SEPA format, false otherwise * - * - * */ protected function parseSepaDescription(): bool { @@ -189,8 +186,6 @@ class AbnAmroDescription implements SpecificInterface * * @return bool true if the description is TRTP format, false otherwise * - * - * */ protected function parseTRTPDescription(): bool { diff --git a/app/Import/Specifics/Belfius.php b/app/Import/Specifics/Belfius.php index 1a57f03bdd..82c662b706 100644 --- a/app/Import/Specifics/Belfius.php +++ b/app/Import/Specifics/Belfius.php @@ -61,7 +61,6 @@ class Belfius implements SpecificInterface * * @return array * - * */ public function run(array $row): array { diff --git a/app/Import/Specifics/IngBelgium.php b/app/Import/Specifics/IngBelgium.php index c284e33518..1525a7699e 100644 --- a/app/Import/Specifics/IngBelgium.php +++ b/app/Import/Specifics/IngBelgium.php @@ -59,7 +59,6 @@ class IngBelgium implements SpecificInterface * * @return array * - * */ public function run(array $row): array { diff --git a/app/Import/Specifics/IngDescription.php b/app/Import/Specifics/IngDescription.php index 122437ba89..83966d76c8 100644 --- a/app/Import/Specifics/IngDescription.php +++ b/app/Import/Specifics/IngDescription.php @@ -66,7 +66,6 @@ class IngDescription implements SpecificInterface * * @return array * - * */ public function run(array $row): array { diff --git a/app/Import/Specifics/RabobankDescription.php b/app/Import/Specifics/RabobankDescription.php index 6ef8a99560..27cbdcaa78 100644 --- a/app/Import/Specifics/RabobankDescription.php +++ b/app/Import/Specifics/RabobankDescription.php @@ -59,7 +59,6 @@ class RabobankDescription implements SpecificInterface * * @return array * - * */ public function run(array $row): array { diff --git a/app/Import/Storage/ImportArrayStorage.php b/app/Import/Storage/ImportArrayStorage.php index 9ca1c863af..211b075e2b 100644 --- a/app/Import/Storage/ImportArrayStorage.php +++ b/app/Import/Storage/ImportArrayStorage.php @@ -51,7 +51,6 @@ use Log; * * Class ImportArrayStorage * - * */ class ImportArrayStorage { @@ -201,8 +200,6 @@ class ImportArrayStorage * @return Collection * @throws FireflyException * - * - * */ private function storeGroupArray(): Collection { @@ -388,9 +385,6 @@ class ImportArrayStorage * * @return bool * - * - * - * */ private function transferExists(array $transaction): bool { diff --git a/app/Jobs/CreateRecurringTransactions.php b/app/Jobs/CreateRecurringTransactions.php index cb8dc4f88e..50548cf8ec 100644 --- a/app/Jobs/CreateRecurringTransactions.php +++ b/app/Jobs/CreateRecurringTransactions.php @@ -68,7 +68,6 @@ use Log; /** * Class CreateRecurringTransactions. * - * */ class CreateRecurringTransactions implements ShouldQueue { @@ -442,7 +441,6 @@ class CreateRecurringTransactions implements ShouldQueue * * @return bool * - * */ private function validRecurrence(Recurrence $recurrence): bool { diff --git a/app/Providers/FireflyServiceProvider.php b/app/Providers/FireflyServiceProvider.php index 8d15def23d..96b8356bd3 100644 --- a/app/Providers/FireflyServiceProvider.php +++ b/app/Providers/FireflyServiceProvider.php @@ -108,7 +108,6 @@ class FireflyServiceProvider extends ServiceProvider /** * Register stuff. * - * */ public function register(): void { diff --git a/app/Repositories/Account/AccountRepository.php b/app/Repositories/Account/AccountRepository.php index ee7af4f3a6..caf385c9f2 100644 --- a/app/Repositories/Account/AccountRepository.php +++ b/app/Repositories/Account/AccountRepository.php @@ -560,8 +560,6 @@ class AccountRepository implements AccountRepositoryInterface * * @return Account * @throws FireflyException - * @throws FireflyException - * @throws FireflyException */ public function update(Account $account, array $data): Account { diff --git a/app/Repositories/Budget/BudgetRepository.php b/app/Repositories/Budget/BudgetRepository.php index 08c4af14a1..c314db8ced 100644 --- a/app/Repositories/Budget/BudgetRepository.php +++ b/app/Repositories/Budget/BudgetRepository.php @@ -46,9 +46,6 @@ use Navigation; /** * Class BudgetRepository. * - * - * - * */ class BudgetRepository implements BudgetRepositoryInterface { @@ -139,7 +136,6 @@ class BudgetRepository implements BudgetRepositoryInterface * * @return array * - * */ public function collectBudgetInformation(Collection $budgets, Carbon $start, Carbon $end): array { @@ -281,7 +277,6 @@ class BudgetRepository implements BudgetRepositoryInterface * * @return Carbon * - * */ public function firstUseDate(Budget $budget): ?Carbon { @@ -323,7 +318,6 @@ class BudgetRepository implements BudgetRepositoryInterface * * @return Collection * - * */ public function getAllBudgetLimits(Carbon $start = null, Carbon $end = null): Collection { @@ -491,7 +485,6 @@ class BudgetRepository implements BudgetRepositoryInterface * * @return Collection * - * */ public function getBudgetLimits(Budget $budget, Carbon $start = null, Carbon $end = null): Collection { @@ -1056,7 +1049,6 @@ class BudgetRepository implements BudgetRepositoryInterface * * @return BudgetLimit|null * - * */ public function updateLimitAmount(Budget $budget, Carbon $start, Carbon $end, string $amount): ?BudgetLimit { diff --git a/app/Repositories/Category/CategoryRepository.php b/app/Repositories/Category/CategoryRepository.php index aa6cd8981e..47d909ba00 100644 --- a/app/Repositories/Category/CategoryRepository.php +++ b/app/Repositories/Category/CategoryRepository.php @@ -185,7 +185,6 @@ class CategoryRepository implements CategoryRepositoryInterface * * @return Carbon|null * - * */ public function lastUseDate(Category $category, Collection $accounts): ?Carbon { diff --git a/app/Repositories/ImportJob/ImportJobRepository.php b/app/Repositories/ImportJob/ImportJobRepository.php index b3c70e3409..c17a4cd4f2 100644 --- a/app/Repositories/ImportJob/ImportJobRepository.php +++ b/app/Repositories/ImportJob/ImportJobRepository.php @@ -38,7 +38,6 @@ use Symfony\Component\HttpFoundation\File\UploadedFile; /** * Class ImportJobRepository. * - * */ class ImportJobRepository implements ImportJobRepositoryInterface { diff --git a/app/Repositories/LinkType/LinkTypeRepository.php b/app/Repositories/LinkType/LinkTypeRepository.php index 1804d4aac9..14daa155dd 100644 --- a/app/Repositories/LinkType/LinkTypeRepository.php +++ b/app/Repositories/LinkType/LinkTypeRepository.php @@ -35,7 +35,6 @@ use Log; /** * Class LinkTypeRepository. * - * */ class LinkTypeRepository implements LinkTypeRepositoryInterface { @@ -348,7 +347,6 @@ class LinkTypeRepository implements LinkTypeRepositoryInterface * @param TransactionJournalLink $link * @param string $text * - * * @throws \Exception */ private function setNoteText(TransactionJournalLink $link, string $text): void diff --git a/app/Repositories/PiggyBank/PiggyBankRepository.php b/app/Repositories/PiggyBank/PiggyBankRepository.php index 0b4dfa3e2c..a69ef887f3 100644 --- a/app/Repositories/PiggyBank/PiggyBankRepository.php +++ b/app/Repositories/PiggyBank/PiggyBankRepository.php @@ -37,8 +37,6 @@ use Log; /** * Class PiggyBankRepository. * - * - * */ class PiggyBankRepository implements PiggyBankRepositoryInterface { diff --git a/app/Repositories/Rule/RuleRepository.php b/app/Repositories/Rule/RuleRepository.php index 432e4d8b5e..459657b814 100644 --- a/app/Repositories/Rule/RuleRepository.php +++ b/app/Repositories/Rule/RuleRepository.php @@ -34,7 +34,6 @@ use Log; /** * Class RuleRepository. * - * */ class RuleRepository implements RuleRepositoryInterface { diff --git a/app/Repositories/Tag/TagRepository.php b/app/Repositories/Tag/TagRepository.php index 7ebe7ab8f1..49d550688d 100644 --- a/app/Repositories/Tag/TagRepository.php +++ b/app/Repositories/Tag/TagRepository.php @@ -36,7 +36,6 @@ use Log; /** * Class TagRepository. * - * */ class TagRepository implements TagRepositoryInterface { diff --git a/app/Repositories/User/UserRepository.php b/app/Repositories/User/UserRepository.php index c8da37a8b3..7b035c8f6b 100644 --- a/app/Repositories/User/UserRepository.php +++ b/app/Repositories/User/UserRepository.php @@ -32,7 +32,6 @@ use Log; /** * Class UserRepository. * - * */ class UserRepository implements UserRepositoryInterface { diff --git a/app/Rules/BelongsUser.php b/app/Rules/BelongsUser.php index 9faa949ffd..85854cd73b 100644 --- a/app/Rules/BelongsUser.php +++ b/app/Rules/BelongsUser.php @@ -69,8 +69,6 @@ class BelongsUser implements Rule * @return bool * @throws FireflyException * - * - * */ public function passes($attribute, $value): bool { @@ -110,7 +108,6 @@ class BelongsUser implements Rule * * @return int * - * */ protected function countField(string $class, string $field, string $value): int { diff --git a/app/Rules/UniqueIban.php b/app/Rules/UniqueIban.php index e7ed37c61c..3f1b178704 100644 --- a/app/Rules/UniqueIban.php +++ b/app/Rules/UniqueIban.php @@ -73,7 +73,6 @@ class UniqueIban implements Rule * * @return bool * - * */ public function passes($attribute, $value): bool { diff --git a/app/Rules/ValidRecurrenceRepetitionType.php b/app/Rules/ValidRecurrenceRepetitionType.php index 858bef0b47..00e66ff56b 100644 --- a/app/Rules/ValidRecurrenceRepetitionType.php +++ b/app/Rules/ValidRecurrenceRepetitionType.php @@ -50,7 +50,6 @@ class ValidRecurrenceRepetitionType implements Rule * * @return bool * - * */ public function passes($attribute, $value): bool { diff --git a/app/Rules/ValidRecurrenceRepetitionValue.php b/app/Rules/ValidRecurrenceRepetitionValue.php index bd0d59dfab..18e207c328 100644 --- a/app/Rules/ValidRecurrenceRepetitionValue.php +++ b/app/Rules/ValidRecurrenceRepetitionValue.php @@ -54,7 +54,6 @@ class ValidRecurrenceRepetitionValue implements Rule * * @return bool * - * */ public function passes($attribute, $value): bool { @@ -104,7 +103,6 @@ class ValidRecurrenceRepetitionValue implements Rule * * @return bool * - * */ private function validateNdom(string $value): bool { diff --git a/app/Services/Internal/Support/JournalServiceTrait.php b/app/Services/Internal/Support/JournalServiceTrait.php index 1e15c4634f..4764ec1874 100644 --- a/app/Services/Internal/Support/JournalServiceTrait.php +++ b/app/Services/Internal/Support/JournalServiceTrait.php @@ -264,7 +264,6 @@ trait JournalServiceTrait * @param TransactionJournal $journal * @param array $tags * - * * @codeCoverageIgnore */ protected function storeTags(TransactionJournal $journal, ?array $tags): void diff --git a/app/Services/Internal/Support/RecurringTransactionTrait.php b/app/Services/Internal/Support/RecurringTransactionTrait.php index 3aac8aef65..e29a44b658 100644 --- a/app/Services/Internal/Support/RecurringTransactionTrait.php +++ b/app/Services/Internal/Support/RecurringTransactionTrait.php @@ -254,7 +254,6 @@ trait RecurringTransactionTrait // $piggyName = $data['meta']['piggy_bank_name'] ?? ''; // $this->updatePiggyBank($recurrence, $piggyId, $piggyName); // - // // $tags = $data['meta']['tags'] ?? []; // $this->updateTags($recurrence, $tags); // diff --git a/app/Support/Binder/ImportProvider.php b/app/Support/Binder/ImportProvider.php index 517d8c2095..98d39a4122 100644 --- a/app/Support/Binder/ImportProvider.php +++ b/app/Support/Binder/ImportProvider.php @@ -37,7 +37,6 @@ class ImportProvider implements BinderInterface /** * @return array * - * */ public static function getProviders(): array { diff --git a/app/Support/Http/Controllers/AugumentData.php b/app/Support/Http/Controllers/AugumentData.php index 996159535e..085f0d2f85 100644 --- a/app/Support/Http/Controllers/AugumentData.php +++ b/app/Support/Http/Controllers/AugumentData.php @@ -79,8 +79,6 @@ trait AugumentData * * @return array * - * - * */ protected function earnedByCategory(Collection $assets, Collection $opposing, Carbon $start, Carbon $end): array // get data + augment with info { @@ -352,7 +350,6 @@ trait AugumentData * * @return array * - * */ protected function getExpensesForBudget(Collection $limits, Budget $budget, Carbon $start, Carbon $end): array // get data + augment with info { @@ -397,8 +394,6 @@ trait AugumentData * * @return array * - * - * */ protected function spentInPeriodMulti(Budget $budget, Collection $limits): array // get data + augment with info { @@ -587,7 +582,6 @@ trait AugumentData * * @return array * - * */ protected function spentByBudget(Collection $assets, Collection $opposing, Carbon $start, Carbon $end): array // get data + augment with info { @@ -647,8 +641,6 @@ trait AugumentData * * @return array * - * - * */ protected function spentByCategory(Collection $assets, Collection $opposing, Carbon $start, Carbon $end): array // get data + augment with info { diff --git a/app/Support/Http/Controllers/ChartGeneration.php b/app/Support/Http/Controllers/ChartGeneration.php index 759c46d142..7a8bf436c7 100644 --- a/app/Support/Http/Controllers/ChartGeneration.php +++ b/app/Support/Http/Controllers/ChartGeneration.php @@ -47,8 +47,6 @@ trait ChartGeneration * * @return array * - * - * */ protected function accountBalanceChart(Collection $accounts, Carbon $start, Carbon $end): array // chart helper method. { diff --git a/app/Support/Http/Controllers/RequestInformation.php b/app/Support/Http/Controllers/RequestInformation.php index b30e530e63..c2dad6d4ec 100644 --- a/app/Support/Http/Controllers/RequestInformation.php +++ b/app/Support/Http/Controllers/RequestInformation.php @@ -66,7 +66,6 @@ trait RequestInformation * * @return string * - * */ protected function getHelpText(string $route, string $language): string // get from internet. { diff --git a/app/Support/Http/Controllers/UserNavigation.php b/app/Support/Http/Controllers/UserNavigation.php index 4575083844..cd920f738c 100644 --- a/app/Support/Http/Controllers/UserNavigation.php +++ b/app/Support/Http/Controllers/UserNavigation.php @@ -183,7 +183,6 @@ trait UserNavigation // return redirect(route('index')); // } // - // // $valid = [AccountType::DEFAULT, AccountType::ASSET]; // $transactions = $journal->transactions; // /** @var Transaction $transaction */ diff --git a/app/Support/Import/JobConfiguration/Ynab/SelectBudgetHandler.php b/app/Support/Import/JobConfiguration/Ynab/SelectBudgetHandler.php index cec0e7259b..1a40058833 100644 --- a/app/Support/Import/JobConfiguration/Ynab/SelectBudgetHandler.php +++ b/app/Support/Import/JobConfiguration/Ynab/SelectBudgetHandler.php @@ -150,7 +150,6 @@ class SelectBudgetHandler implements YnabJobConfigurationInterface $this->repository->setUser($importJob->user); $this->currencyRepository->setUser($importJob->user); $this->accountRepository->setUser($importJob->user); - $this->accountRepository->setUser($importJob->user); $this->accounts = $this->accountRepository->getAccountsByType([AccountType::ASSET, AccountType::DEFAULT]); } diff --git a/app/Support/Import/Routine/Bunq/StageNewHandler.php b/app/Support/Import/Routine/Bunq/StageNewHandler.php index e37fcd71c6..836c7f48d0 100644 --- a/app/Support/Import/Routine/Bunq/StageNewHandler.php +++ b/app/Support/Import/Routine/Bunq/StageNewHandler.php @@ -132,7 +132,6 @@ class StageNewHandler /** @var MonetaryAccountSavings $object */ $array = $this->processMas($object); break; - break; default: // @codeCoverageIgnoreStart throw new FireflyException(sprintf('Bunq import routine cannot handle account of type "%s".', get_class($object))); diff --git a/app/Support/Import/Routine/File/OFXProcessor.php b/app/Support/Import/Routine/File/OFXProcessor.php index 438f48f50d..4e14fb139f 100644 --- a/app/Support/Import/Routine/File/OFXProcessor.php +++ b/app/Support/Import/Routine/File/OFXProcessor.php @@ -92,7 +92,6 @@ class OFXProcessor implements FileProcessorInterface // var_dump($transaction); // } // - // // die('I am here.'); diff --git a/app/Support/Repositories/Recurring/FiltersWeekends.php b/app/Support/Repositories/Recurring/FiltersWeekends.php index 83d5be55cc..ace2b1bddc 100644 --- a/app/Support/Repositories/Recurring/FiltersWeekends.php +++ b/app/Support/Repositories/Recurring/FiltersWeekends.php @@ -43,7 +43,6 @@ trait FiltersWeekends * * @return array * - * */ protected function filterWeekends(RecurrenceRepetition $repetition, array $dates): array { diff --git a/tests/Feature/Controllers/CurrencyControllerTest.php b/tests/Feature/Controllers/CurrencyControllerTest.php index c9bc8b6001..354353a0a9 100644 --- a/tests/Feature/Controllers/CurrencyControllerTest.php +++ b/tests/Feature/Controllers/CurrencyControllerTest.php @@ -341,7 +341,6 @@ class CurrencyControllerTest extends TestCase } /** - * @covers \FireflyIII\Http\Controllers\CurrencyController * @covers \FireflyIII\Http\Controllers\CurrencyController */ public function testIndex(): void @@ -376,7 +375,6 @@ class CurrencyControllerTest extends TestCase } /** - * @covers \FireflyIII\Http\Controllers\CurrencyController * @covers \FireflyIII\Http\Controllers\CurrencyController */ public function testIndexNoRights(): void diff --git a/tests/Feature/Controllers/JavascriptControllerTest.php b/tests/Feature/Controllers/JavascriptControllerTest.php index d713a725e7..6df8e75fab 100644 --- a/tests/Feature/Controllers/JavascriptControllerTest.php +++ b/tests/Feature/Controllers/JavascriptControllerTest.php @@ -92,7 +92,6 @@ class JavascriptControllerTest extends TestCase } /** - * @covers \FireflyIII\Http\Controllers\JavascriptController * @covers \FireflyIII\Http\Controllers\JavascriptController * * @param string $range diff --git a/tests/Feature/Controllers/Transaction/BulkControllerTest.php b/tests/Feature/Controllers/Transaction/BulkControllerTest.php index 90c4d9173f..a23869549d 100644 --- a/tests/Feature/Controllers/Transaction/BulkControllerTest.php +++ b/tests/Feature/Controllers/Transaction/BulkControllerTest.php @@ -54,7 +54,6 @@ class BulkControllerTest extends TestCase /** - * @covers \FireflyIII\Http\Controllers\Transaction\BulkController * @covers \FireflyIII\Http\Controllers\Transaction\BulkController */ public function testEditWithdrawal(): void diff --git a/tests/Unit/Factory/RecurrenceFactoryTest.php b/tests/Unit/Factory/RecurrenceFactoryTest.php index 9899caa197..a88b2712f6 100644 --- a/tests/Unit/Factory/RecurrenceFactoryTest.php +++ b/tests/Unit/Factory/RecurrenceFactoryTest.php @@ -42,7 +42,6 @@ use Log; use Tests\TestCase; /** - * * * Test different combinations: * Transfer diff --git a/tests/Unit/Support/Import/Routine/Bunq/StageImportDataHandlerTest.php b/tests/Unit/Support/Import/Routine/Bunq/StageImportDataHandlerTest.php index 69618a2a49..93cc11dc9b 100644 --- a/tests/Unit/Support/Import/Routine/Bunq/StageImportDataHandlerTest.php +++ b/tests/Unit/Support/Import/Routine/Bunq/StageImportDataHandlerTest.php @@ -331,7 +331,6 @@ class StageImportDataHandlerTest extends TestCase // // todo: improve test thing: // Preferences::shouldReceive('setForUser'); // - // // // ignore the deprecated fields: // $amount->setValue('150'); // $amount->setCurrency('EUR'); @@ -410,7 +409,6 @@ class StageImportDataHandlerTest extends TestCase // $payment->shouldReceive('listing')->once()->andReturn($list); // $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturn($deposit); // - // // $handler = new StageImportDataHandler; // $handler->setImportJob($job); // try { @@ -547,7 +545,6 @@ class StageImportDataHandlerTest extends TestCase // $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturnNull(); // $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::ASSET]])->once()->andReturn($asset); // - // // // set new last transaction ID: // $lastPref = new Preference; // $lastPref->data = 0;