kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-24 22:48:18 +00:00
Code Issues Projects Releases Wiki Activity

This fixes the tests (must still upload test database).

Browse Source
This commit is contained in:
James Cole
2017-06-24 12:38:24 +02:00
parent 8e3ba7caf2
commit 5fbc319b20
8 changed files with 127 additions and 352 deletions
Download Patch File Download Diff File Expand all files Collapse all files

410
tests/Feature/Controllers/ImportControllerTest.php
View File

@@ -7,19 +7,14 @@
* See the LICENSE file for details.
*/
declare(strict_types = 1);
declare(strict_types=1);
namespace Tests\Feature\Controllers;
use FireflyIII\Import\ImportProcedureInterface;
use FireflyIII\Import\Setup\CsvSetup;
use FireflyIII\Import\Configurator\CsvConfigurator;
use FireflyIII\Import\Routine\ImportRoutine;
use FireflyIII\Models\ImportJob;
use FireflyIII\Models\Tag;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Repositories\Tag\TagRepositoryInterface;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use Illuminate\Http\UploadedFile;
use Tests\TestCase;
@@ -31,53 +26,20 @@ use Tests\TestCase;
class ImportControllerTest extends TestCase
{
/**
* @covers \FireflyIII\Http\Controllers\ImportController::complete
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testComplete()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.complete', ['complete']));
$response->assertStatus(200);
$response->assertSee('<ol class="breadcrumb">');
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::complete
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testCompleteWrongJob()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.complete', ['configure']));
$response->assertStatus(302);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::__construct
* @covers \FireflyIII\Http\Controllers\ImportController::configure
* @covers \FireflyIII\Http\Controllers\ImportController::makeImporter
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::makeConfigurator
*/
public function testConfigure()
{
$setup = $this->mock(CsvSetup::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
// mock stuff.
$configurator = $this->mock(CsvConfigurator::class);
$configurator->shouldReceive('setJob')->once();
$configurator->shouldReceive('isJobConfigured')->once()->andReturn(false);
$configurator->shouldReceive('getNextView')->once()->andReturn('import.csv.initial');
$configurator->shouldReceive('getNextData')->andReturn(['specifics' => [], 'delimiters' => [], 'accounts' => []])->once();
$setup->shouldReceive('setJob')->once();
$setup->shouldReceive('configure')->once();
$setup->shouldReceive('getConfigurationData')->andReturn(['specifics' => [], 'delimiters' => [], 'accounts' => []])->once();
$this->be($this->user());
$response = $this->get(route('import.configure', ['configure']));
@@ -86,86 +48,67 @@ class ImportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::__construct
* @covers \FireflyIII\Http\Controllers\ImportController::configure
* @covers \FireflyIII\Http\Controllers\ImportController::makeImporter
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::makeConfigurator
*/
public function testConfigureWrongJob()
public function testConfigured()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
// mock stuff.
$configurator = $this->mock(CsvConfigurator::class);
$configurator->shouldReceive('setJob')->once();
$configurator->shouldReceive('isJobConfigured')->once()->andReturn(true);
$this->be($this->user());
$response = $this->get(route('import.configure', ['settings']));
$response = $this->get(route('import.configure', ['configure']));
$response->assertStatus(302);
$response->assertRedirect(route('import.status', ['configure']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::download
*/
public function testDownload()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.download', ['configure']));
$response->assertStatus(200);
$response->assertJson(
[
'delimiter' => 'tab',
'column-roles-complete' => false,
'column-mapping-complete' => false,
]
);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::finished
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::index
*/
public function testFinished()
public function testIndex()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.finished', ['finished']));
$response = $this->get(route('import.index'));
$response->assertStatus(200);
$response->assertSee('<ol class="breadcrumb">');
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::finished
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::initialize
*/
public function testFinishedWrongJob()
public function testInitialize()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$repository = $this->mock(ImportJobRepositoryInterface::class);
$path = resource_path('stubs/csv.csv');
$file = new UploadedFile($path, 'upload.csv', filesize($path), 'text/csv', null, true);
$configPath = resource_path('stubs/demo-configuration.json');
$configFile = new UploadedFile($path, 'configuration.json', filesize($configPath), 'application/json', null, true);
$job = new ImportJob;
$job->key = 'hello';
$repository->shouldReceive('create')->once()->andReturn($job);
$repository->shouldReceive('processFile')->once();
$repository->shouldReceive('processConfiguration')->once();
$repository->shouldReceive('updateStatus')->once();
$this->be($this->user());
$response = $this->get(route('import.finished', ['configure']));
$response = $this->post(route('import.initialize'), ['import_file_type' => 'csv', 'import_file' => $file, 'configuration_file' => $configFile]);
$response->assertStatus(302);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::index
* @covers \FireflyIII\Http\Controllers\ImportController::__construct
*/
public function testIndex()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.index'));
$response->assertStatus(200);
$response->assertRedirect(route('import.configure', ['hello']));
}
/**
@@ -173,9 +116,6 @@ class ImportControllerTest extends TestCase
*/
public function testJson()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.json', ['configure']));
$response->assertStatus(200);
@@ -186,13 +126,6 @@ class ImportControllerTest extends TestCase
*/
public function testJsonFinished()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$tagRepos = $this->mock(TagRepositoryInterface::class);
$tag = factory(Tag::class)->make();
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$tagRepos->shouldReceive('find')->once()->andReturn($tag);
$this->be($this->user());
$response = $this->get(route('import.json', ['finished']));
$response->assertStatus(200);
@@ -203,9 +136,6 @@ class ImportControllerTest extends TestCase
*/
public function testJsonRunning()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.json', ['running']));
$response->assertStatus(200);
@@ -213,156 +143,35 @@ class ImportControllerTest extends TestCase
/**
* @covers \FireflyIII\Http\Controllers\ImportController::postConfigure
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testPostConfigure()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$configurator = $this->mock(CsvConfigurator::class);
$configurator->shouldReceive('setJob')->once();
$configurator->shouldReceive('isJobConfigured')->once()->andReturn(false);
$configurator->shouldReceive('configureJob')->once()->andReturn(false);
$importer = $this->mock(CsvSetup::class);
$importer->shouldReceive('setJob')->once();
$importer->shouldReceive('saveImportConfiguration')->once();
$repository->shouldReceive('updateStatus')->once();
$data = [];
$this->be($this->user());
$response = $this->post(route('import.process-configuration', ['p-configure']), $data);
$response = $this->post(route('import.process-configuration', ['running']));
$response->assertStatus(302);
$response->assertRedirect(route('import.settings', ['p-configure']));
$response->assertRedirect(route('import.configure', ['running']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::postConfigure
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testPostConfigureWrongJob()
public function testPostConfigured()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$configurator = $this->mock(CsvConfigurator::class);
$configurator->shouldReceive('setJob')->once();
$configurator->shouldReceive('isJobConfigured')->once()->andReturn(true);
$data = [];
$this->be($this->user());
$response = $this->post(route('import.process-configuration', ['finished']), $data);
$response = $this->post(route('import.process-configuration', ['running']));
$response->assertStatus(302);
$response->assertRedirect(route('import.finished', ['finished']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::postSettings
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testPostSettings()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$importer = $this->mock(CsvSetup::class);
$importer->shouldReceive('setJob')->once();
$importer->shouldReceive('storeSettings')->once();
$data = [];
$this->be($this->user());
$response = $this->post(route('import.post-settings', ['p-settings']), $data);
$response->assertStatus(302);
$response->assertRedirect(route('import.settings', ['p-settings']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::postSettings
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testPostSettingsWrongJob()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$data = [];
$this->be($this->user());
$response = $this->post(route('import.post-settings', ['configure']), $data);
$response->assertStatus(302);
$response->assertRedirect(route('import.configure', ['configure']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::settings
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testSettings()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$importer = $this->mock(CsvSetup::class);
$importer->shouldReceive('setJob')->once();
$importer->shouldReceive('requireUserSettings')->once()->andReturn(false);
$repository->shouldReceive('updateStatus')->once();
$this->be($this->user());
$response = $this->get(route('import.settings', ['settings']));
$response->assertStatus(302);
$response->assertRedirect(route('import.complete', ['settings']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::settings
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testSettingsUserSettings()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$importer = $this->mock(CsvSetup::class);
$importer->shouldReceive('setJob')->once();
$importer->shouldReceive('requireUserSettings')->once()->andReturn(true);
$importer->shouldReceive('getDataForSettings')->once()->andReturn([]);
$importer->shouldReceive('getViewForSettings')->once()->andReturn('error');
$this->be($this->user());
$response = $this->get(route('import.settings', ['settings']));
$response->assertStatus(200);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::settings
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testSettingsWrongJob()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.settings', ['configure']));
$response->assertStatus(302);
$response->assertRedirect(route('import.configure', ['configure']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::settings
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testSettingsWrongJobAgain()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$this->be($this->user());
$response = $this->get(route('import.settings', ['complete']));
$response->assertStatus(302);
$response->assertRedirect(route('import.complete', ['complete']));
$response->assertRedirect(route('import.status', ['running']));
}
/**
@@ -370,118 +179,51 @@ class ImportControllerTest extends TestCase
*/
public function testStart()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
$importer = $this->mock(ImportRoutine::class);
$importer->shouldReceive('setJob')->once();
$importer->shouldReceive('run')->once()->andReturn(true);
/** @var ImportProcedureInterface $procedure */
$procedure = $this->mock(ImportProcedureInterface::class);
$procedure->shouldReceive('runImport');
$this->be($this->user());
$response = $this->post(route('import.start', ['complete']));
$response = $this->post(route('import.start', ['running']));
$response->assertStatus(200);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::start
* @expectedExceptionMessage Job did not complete succesfully.
*/
public function testStartFailed()
{
$importer = $this->mock(ImportRoutine::class);
$importer->shouldReceive('setJob')->once();
$importer->shouldReceive('run')->once()->andReturn(false);
$this->be($this->user());
$response = $this->post(route('import.start', ['running']));
$response->assertStatus(500);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::status
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testStatus()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
// complete
$this->be($this->user());
$response = $this->get(route('import.status', ['complete']));
$response = $this->get(route('import.status', ['running']));
$response->assertStatus(200);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::status
* @covers \FireflyIII\Http\Controllers\ImportController::jobInCorrectStep
* @covers \FireflyIII\Http\Controllers\ImportController::redirectToCorrectStep
*/
public function testStatusWrongJob()
public function testStatusNew()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal);
// complete
$this->be($this->user());
$response = $this->get(route('import.status', ['configure']));
$response = $this->get(route('import.status', ['new']));
$response->assertStatus(302);
$response->assertRedirect(route('import.configure', ['configure']));
$response->assertRedirect(route('import.configure', ['new']));
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::upload
*/
public function testUpload()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$userRepos = $this->mock(UserRepositoryInterface::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
$job = factory(ImportJob::class)->make();
$journalRepos->shouldReceive('first')->andReturn(new TransactionJournal);
$userRepos->shouldReceive('hasRole')->andReturn(false);
$repository->shouldReceive('create')->andReturn($job);
$path = resource_path('stubs/csv.csv');
$file = new UploadedFile($path, 'upload.csv', filesize($path), 'text/csv', null, true);
$this->be($this->user());
$response = $this->post(route('import.upload'), ['import_file_type' => 'csv', 'import_file' => $file]);
$response->assertStatus(302);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::upload
*/
public function testUploadDemo()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$userRepos = $this->mock(UserRepositoryInterface::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
$job = factory(ImportJob::class)->make();
$journalRepos->shouldReceive('first')->andReturn(new TransactionJournal);
$userRepos->shouldReceive('hasRole')->andReturn(true);
$repository->shouldReceive('create')->andReturn($job);
$repository->shouldReceive('setConfiguration')->andReturn($job);
$path = resource_path('stubs/csv.csv');
$file = new UploadedFile($path, 'upload.csv', filesize($path), 'text/csv', null, true);
$this->be($this->user());
$response = $this->post(route('import.upload'), ['import_file_type' => 'csv', 'import_file' => $file]);
$response->assertStatus(302);
}
/**
* @covers \FireflyIII\Http\Controllers\ImportController::upload
*/
public function testUploadWithConfig()
{
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$userRepos = $this->mock(UserRepositoryInterface::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
$job = factory(ImportJob::class)->make();
$journalRepos->shouldReceive('first')->andReturn(new TransactionJournal);
$userRepos->shouldReceive('hasRole')->andReturn(false);
$repository->shouldReceive('create')->andReturn($job);
$path = resource_path('stubs/csv.csv');
$file = new UploadedFile($path, 'upload.csv', filesize($path), 'text/csv', null, true);
$configPath = resource_path('stubs/demo-configuration.json');
$configFile = new UploadedFile($path, 'configuration.json', filesize($configPath), 'application/json', null, true);
$this->be($this->user());
$response = $this->post(route('import.upload'), ['import_file_type' => 'csv', 'import_file' => $file, 'configuration_file' => $configFile]);
$response->assertStatus(302);
}
}