kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-17 15:18:05 +00:00
Code Issues Projects Releases Wiki Activity

Add some slack notifications and a todo to fix the rest

Browse Source
This commit is contained in:
James Cole
2023-08-12 20:57:51 +02:00
parent 53f1b0218c
commit 610bc108e7
26 changed files with 346 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/TransactionRules/Actions/SetSourceAccount.php
View File

@@ -64,7 +64,7 @@ class SetSourceAccount implements ActionInterface
$this->repository = app(AccountRepositoryInterface::class);
if (null === $object) {
Log::error('Could not find journal.');
// TODO introduce error
return false;
}
$type = $object->transactionType->type;
@@ -76,7 +76,7 @@ class SetSourceAccount implements ActionInterface
Log::error(
sprintf('Cant change source account of journal #%d because no asset account with name "%s" exists.', $object->id, $this->action->action_value)
);
// TODO introduce error
return false;
}
@@ -85,13 +85,13 @@ class SetSourceAccount implements ActionInterface
$destination = $object->transactions()->where('amount', '>', 0)->first();
if (null === $destination) {
Log::error('Could not find destination transaction.');
// TODO introduce error
return false;
}
// account must not be deleted (in the meantime):
if (null === $destination->account) {
Log::error('Could not find destination transaction account.');
// TODO introduce error
return false;
}
if (null !== $newAccount && (int)$newAccount->id === (int)$destination->account_id) {
@@ -102,7 +102,7 @@ class SetSourceAccount implements ActionInterface
$destination->account_id
)
);
// TODO introduce error
return false;
}