kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage, remove dead code.

Browse Source
This commit is contained in:
James Cole
2018-05-20 16:26:27 +02:00
parent c06fd12b07
commit 620c5f515e
18 changed files with 919 additions and 835 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Import/JobConfiguration/FakeJobConfiguration.php
View File

@@ -38,14 +38,6 @@ class FakeJobConfiguration implements JobConfigurationInterface
/** @var ImportJobRepositoryInterface */
private $repository;
/**
* ConfiguratorInterface constructor.
*/
public function __construct()
{
$this->repository = app(ImportJobRepositoryInterface::class);
}
/**
* Returns true when the initial configuration for this job is complete.
*
@@ -161,6 +153,7 @@ class FakeJobConfiguration implements JobConfigurationInterface
public function setImportJob(ImportJob $importJob): void
{
$this->importJob = $importJob;
$this->repository = app(ImportJobRepositoryInterface::class);
$this->repository->setUser($importJob->user);
}
}

9
app/Import/JobConfiguration/FileJobConfiguration.php
View File

@@ -45,14 +45,6 @@ class FileJobConfiguration implements JobConfigurationInterface
/** @var ImportJobRepositoryInterface */
private $repository;
/**
* ConfiguratorInterface constructor.
*/
public function __construct()
{
$this->repository = app(ImportJobRepositoryInterface::class);
}
/**
* Returns true when the initial configuration for this job is complete.
*
@@ -129,6 +121,7 @@ class FileJobConfiguration implements JobConfigurationInterface
public function setImportJob(ImportJob $importJob): void
{
$this->importJob = $importJob;
$this->repository = app(ImportJobRepositoryInterface::class);
$this->repository->setUser($importJob->user);
}

5
app/Import/JobConfiguration/JobConfigurationInterface.php
View File

@@ -30,11 +30,6 @@ use Illuminate\Support\MessageBag;
*/
interface JobConfigurationInterface
{
/**
* ConfiguratorInterface constructor.
*/
public function __construct();
/**
* Returns true when the initial configuration for this job is complete.
*

10
app/Import/JobConfiguration/SpectreJobConfiguration.php
View File

@@ -49,13 +49,6 @@ class SpectreJobConfiguration implements JobConfigurationInterface
/** @var ImportJobRepositoryInterface */
private $repository;
/**
* ConfiguratorInterface constructor.
*/
public function __construct()
{
}
/**
* Returns true when the initial configuration for this job is complete.
*
@@ -146,8 +139,9 @@ class SpectreJobConfiguration implements JobConfigurationInterface
$handler->setImportJob($this->importJob);
break;
default:
// @codeCoverageIgnoreStart
throw new FireflyException(sprintf('Firefly III cannot create a configuration handler for stage "%s"', $this->importJob->stage));
// @codeCoverageIgnoreEnd
}
return $handler;