From 62e41f19977459a78d6121d2019b20826db2d821 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 26 Nov 2016 09:07:16 +0100 Subject: [PATCH] Remove TODO annotations --- app/Http/Controllers/Chart/CategoryReportController.php | 6 ------ app/Repositories/Budget/BudgetRepositoryInterface.php | 1 - tests/acceptance/Controllers/AccountControllerTest.php | 3 --- 3 files changed, 10 deletions(-) diff --git a/app/Http/Controllers/Chart/CategoryReportController.php b/app/Http/Controllers/Chart/CategoryReportController.php index 3fa10a8b07..0cabf7ad52 100644 --- a/app/Http/Controllers/Chart/CategoryReportController.php +++ b/app/Http/Controllers/Chart/CategoryReportController.php @@ -32,8 +32,6 @@ use Response; /** * Separate controller because many helper functions are shared. * - * TODO much of this code is actually repeated. First for the object (category, account), then for the direction (in / out). - * * Class CategoryReportController * * @package FireflyIII\Http\Controllers\Chart @@ -98,7 +96,6 @@ class CategoryReportController extends Controller } // also collect all transactions NOT in these categories. - // TODO include transfers if ($others) { $collector = new JournalCollector(auth()->user()); $collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::WITHDRAWAL]); @@ -147,7 +144,6 @@ class CategoryReportController extends Controller } // also collect others? - // TODO include transfers if ($others) { $collector = new JournalCollector(auth()->user()); $collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::DEPOSIT]); @@ -196,7 +192,6 @@ class CategoryReportController extends Controller } // also collect all transactions NOT in these categories. - // TODO include transfers if ($others) { $collector = new JournalCollector(auth()->user()); $collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::WITHDRAWAL]); @@ -245,7 +240,6 @@ class CategoryReportController extends Controller } // also collect others? - // TODO include transfers if ($others) { $collector = new JournalCollector(auth()->user()); $collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::DEPOSIT]); diff --git a/app/Repositories/Budget/BudgetRepositoryInterface.php b/app/Repositories/Budget/BudgetRepositoryInterface.php index c346debdac..f81788a435 100644 --- a/app/Repositories/Budget/BudgetRepositoryInterface.php +++ b/app/Repositories/Budget/BudgetRepositoryInterface.php @@ -92,7 +92,6 @@ interface BudgetRepositoryInterface /** * - * todo always collects without budget info * @param Collection $budgets * @param Collection $accounts * @param Carbon $start diff --git a/tests/acceptance/Controllers/AccountControllerTest.php b/tests/acceptance/Controllers/AccountControllerTest.php index f790c2ae24..b7c59f0868 100644 --- a/tests/acceptance/Controllers/AccountControllerTest.php +++ b/tests/acceptance/Controllers/AccountControllerTest.php @@ -39,7 +39,6 @@ class AccountControllerTest extends TestCase /** * @covers FireflyIII\Http\Controllers\AccountController::destroy - * @todo Implement testDestroy(). */ public function testDestroy() { @@ -108,7 +107,6 @@ class AccountControllerTest extends TestCase /** * @covers FireflyIII\Http\Controllers\AccountController::store - * @todo Implement testStore(). */ public function testStore() { @@ -120,7 +118,6 @@ class AccountControllerTest extends TestCase /** * @covers FireflyIII\Http\Controllers\AccountController::update - * @todo Implement testUpdate(). */ public function testUpdate() {