Merge branch 'develop' into v480

* develop: Fix #2204 CSV file fix for Belfius
2025-10-12 15:35:15 +00:00 · 2019-04-09 07:51:11 +02:00
parent 13afd4582f b3e48ede70
commit 63070bffc3
5 changed files with 186 additions and 1 deletions
--- a/app/Import/Specifics/Belfius.php
+++ b/app/Import/Specifics/Belfius.php
@@ -0,0 +1,94 @@
+<?php
+/**
+ * Belfius.php
+ * Copyright (c) 2019 Sander Kleykens <sander@kleykens.com>
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+declare(strict_types=1);
+
+namespace FireflyIII\Import\Specifics;
+
+/**
+ * Class Belfius.
+ *
+ * Fixes Belfius CSV files to:
+ *  - Correct descriptions for recurring transactions so doubles can be detected when the equivalent incoming
+ *    transaction is imported.
+ *
+ */
+class Belfius implements SpecificInterface
+{
+    /**
+     * Description of this specific fix.
+     *
+     * @return string
+     * @codeCoverageIgnore
+     */
+    public static function getDescription(): string
+    {
+        return 'import.specific_belfius_descr';
+    }
+
+    /**
+     * Name of specific fix.
+     *
+     * @return string
+     * @codeCoverageIgnore
+     */
+    public static function getName(): string
+    {
+        return 'import.specific_belfius_name';
+    }
+
+    /**
+     * Run the fix.
+     *
+     * @param array $row
+     *
+     * @return array
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     */
+    public function run(array $row): array
+    {
+        return Belfius::processRecurringTransactionDescription($row);
+    }
+
+    /**
+     * Fixes the description for outgoing recurring transactions so doubles can be detected when the equivalent incoming
+     * transaction is imported for another bank account.
+     *
+     * @return array the row containing the new description
+     */
+    protected static function processRecurringTransactionDescription(array $row): array
+    {
+        if (!isset($row[5]) || !isset($row[14])) {
+            return $row;
+        }
+
+        $opposingAccountName = $row[5];
+        $description = $row[14];
+
+        preg_match('/DOORLOPENDE OPDRACHT.*\s+' . preg_quote($opposingAccountName, '/') . '\s+(.+)\s+REF.\s*:/', $description, $matches);
+
+        if (isset($matches[1])) {
+            $row[14] = $matches[1];
+        }
+
+        return $row;
+    }
+}