Code clean up.

This commit is contained in:
James Cole
2017-11-15 10:52:29 +01:00
parent aee17221eb
commit 649dca77f5
305 changed files with 1200 additions and 1600 deletions

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\Tag;
use FireflyIII\Models\TransactionJournal;

View File

@@ -34,7 +34,6 @@ use Log;
*/
class AppendDescription implements ActionInterface
{
private $action;

View File

@@ -35,7 +35,6 @@ use Log;
*/
class AppendNotes implements ActionInterface
{
private $action;

View File

@@ -34,7 +34,6 @@ use Log;
*/
class ClearBudget implements ActionInterface
{
private $action;

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
use Log;
@@ -35,7 +34,6 @@ use Log;
*/
class ClearCategory implements ActionInterface
{
private $action;

View File

@@ -35,7 +35,6 @@ use Log;
*/
class ClearNotes implements ActionInterface
{
private $action;

View File

@@ -34,7 +34,6 @@ use Log;
*/
class PrependDescription implements ActionInterface
{
private $action;

View File

@@ -35,7 +35,6 @@ use Log;
*/
class PrependNotes implements ActionInterface
{
private $action;

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
use Log;
@@ -59,6 +58,5 @@ class RemoveAllTags implements ActionInterface
$journal->tags()->detach();
return true;
}
}

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\Tag;
use FireflyIII\Models\TransactionJournal;
@@ -36,7 +35,6 @@ use Log;
*/
class RemoveTag implements ActionInterface
{
private $action;

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\Budget;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
@@ -38,7 +37,6 @@ use Log;
*/
class SetBudget implements ActionInterface
{
private $action;
@@ -78,7 +76,9 @@ class SetBudget implements ActionInterface
if ($journal->transactionType->type !== TransactionType::WITHDRAWAL) {
Log::debug(
sprintf(
'RuleAction SetBudget could not set budget of journal #%d to "%s" because journal is a %s.', $journal->id, $search,
'RuleAction SetBudget could not set budget of journal #%d to "%s" because journal is a %s.',
$journal->id,
$search,
$journal->transactionType->type
)
);

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\Category;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
@@ -36,7 +35,6 @@ use Log;
*/
class SetCategory implements ActionInterface
{
private $action;

View File

@@ -34,7 +34,6 @@ use Log;
*/
class SetDescription implements ActionInterface
{
private $action;
@@ -61,7 +60,8 @@ class SetDescription implements ActionInterface
Log::debug(
sprintf(
'RuleAction SetDescription changed the description of journal #%d from "%s" to "%s".', $journal->id,
'RuleAction SetDescription changed the description of journal #%d from "%s" to "%s".',
$journal->id,
$oldDescription,
$this->action->action_value
)

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
use FireflyIII\Models\RuleAction;
@@ -39,7 +38,6 @@ use Log;
*/
class SetDestinationAccount implements ActionInterface
{
private $action;
/** @var TransactionJournal */
@@ -87,7 +85,8 @@ class SetDestinationAccount implements ActionInterface
Log::error(
sprintf(
'Cannot change destination account of journal #%d because no asset account with name "%s" exists.',
$journal->id, $this->action->action_value
$journal->id,
$this->action->action_value
)
);

View File

@@ -35,7 +35,6 @@ use Log;
*/
class SetNotes implements ActionInterface
{
private $action;

View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
use FireflyIII\Models\RuleAction;
@@ -39,7 +38,6 @@ use Log;
*/
class SetSourceAccount implements ActionInterface
{
private $action;
/** @var TransactionJournal */
@@ -86,7 +84,8 @@ class SetSourceAccount implements ActionInterface
Log::error(
sprintf(
'Cannot change source account of journal #%d because no asset account with name "%s" exists.',
$journal->id, $this->action->action_value
$journal->id,
$this->action->action_value
)
);