Code cleanup.

app/Api/V1/Controllers/Models/RuleGroup/DestroyController.php

@@ -38,8 +38,6 @@ class DestroyController extends Controller
 
     /**
      * RuleGroupController constructor.
-     *
-
      */
     public function __construct()
     {
@@ -62,10 +60,6 @@ class DestroyController extends Controller
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/deleteRuleGroup
      *
      * Delete the resource.
-     *
-     * @param RuleGroup $ruleGroup
-     *
-     * @return JsonResponse
      */
     public function destroy(RuleGroup $ruleGroup): JsonResponse
     {

app/Api/V1/Controllers/Models/RuleGroup/ListController.php

@@ -43,8 +43,6 @@ class ListController extends Controller
 
     /**
      * RuleGroupController constructor.
-     *
-
      */
     public function __construct()
     {
@@ -66,9 +64,6 @@ class ListController extends Controller
      * This endpoint is documented at:
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/listRuleByGroup
      *
-     * @param RuleGroup $group
-     *
-     * @return JsonResponse
      * @throws FireflyException
      */
     public function rules(RuleGroup $group): JsonResponse
@@ -84,7 +79,7 @@ class ListController extends Controller
 
         // make paginator:
         $paginator = new LengthAwarePaginator($rules, $count, $pageSize, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.rule-groups.rules', [$group->id]) . $this->buildParams());
+        $paginator->setPath(route('api.v1.rule-groups.rules', [$group->id]).$this->buildParams());
 
         /** @var RuleTransformer $transformer */
         $transformer = app(RuleTransformer::class);

app/Api/V1/Controllers/Models/RuleGroup/ShowController.php

@@ -44,8 +44,6 @@ class ShowController extends Controller
 
     /**
      * RuleGroupController constructor.
-     *
-
      */
     public function __construct()
     {
@@ -68,7 +66,6 @@ class ShowController extends Controller
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/listRuleGroup
      * List all of them.
      *
-     * @return JsonResponse
      * @throws FireflyException
      */
     public function index(): JsonResponse
@@ -84,7 +81,7 @@ class ShowController extends Controller
 
         // make paginator:
         $paginator = new LengthAwarePaginator($ruleGroups, $count, $pageSize, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.rule-groups.index') . $this->buildParams());
+        $paginator->setPath(route('api.v1.rule-groups.index').$this->buildParams());
 
         /** @var RuleGroupTransformer $transformer */
         $transformer = app(RuleGroupTransformer::class);
@@ -101,14 +98,11 @@ class ShowController extends Controller
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/getRuleGroup
      *
      * List single resource.
-     *
-     * @param RuleGroup $ruleGroup
-     *
-     * @return JsonResponse
      */
     public function show(RuleGroup $ruleGroup): JsonResponse
     {
         $manager = $this->getManager();
+
         /** @var RuleGroupTransformer $transformer */
         $transformer = app(RuleGroupTransformer::class);
         $transformer->setParameters($this->parameters);

app/Api/V1/Controllers/Models/RuleGroup/StoreController.php

@@ -42,8 +42,6 @@ class StoreController extends Controller
 
     /**
      * RuleGroupController constructor.
-     *
-
      */
     public function __construct()
     {
@@ -69,10 +67,6 @@ class StoreController extends Controller
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/storeRuleGroup
      *
      * Store new object.
-     *
-     * @param StoreRequest $request
-     *
-     * @return JsonResponse
      */
     public function store(StoreRequest $request): JsonResponse
     {

app/Api/V1/Controllers/Models/RuleGroup/TriggerController.php

@@ -23,7 +23,6 @@ declare(strict_types=1);
 
 namespace FireflyIII\Api\V1\Controllers\Models\RuleGroup;
 
-use Exception;
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Models\RuleGroup\TestRequest;
 use FireflyIII\Api\V1\Requests\Models\RuleGroup\TriggerRequest;
@@ -47,8 +46,6 @@ class TriggerController extends Controller
 
     /**
      * RuleGroupController constructor.
-     *
-
      */
     public function __construct()
     {
@@ -70,12 +67,7 @@ class TriggerController extends Controller
      * This endpoint is documented at:
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/testRuleGroup
      *
-     * @param TestRequest $request
-     * @param RuleGroup   $group
-     *
-     * @return JsonResponse
      * @throws FireflyException
-     *
      */
     public function testGroup(TestRequest $request, RuleGroup $group): JsonResponse
     {
@@ -108,10 +100,11 @@ class TriggerController extends Controller
         $count        = $transactions->count();
 
         $paginator = new LengthAwarePaginator($transactions, $count, 31337, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.rule-groups.test', [$group->id]) . $this->buildParams());
+        $paginator->setPath(route('api.v1.rule-groups.test', [$group->id]).$this->buildParams());
 
         // resulting list is presented as JSON thing.
         $manager = $this->getManager();
+
         /** @var TransactionGroupTransformer $transformer */
         $transformer = app(TransactionGroupTransformer::class);
         $transformer->setParameters($this->parameters);
@@ -128,11 +121,7 @@ class TriggerController extends Controller
      *
      * Execute the given rule group on a set of existing transactions.
      *
-     * @param TriggerRequest $request
-     * @param RuleGroup      $group
-     *
-     * @return JsonResponse
-     * @throws Exception
+     * @throws \Exception
      */
     public function triggerGroup(TriggerRequest $request, RuleGroup $group): JsonResponse
     {

app/Api/V1/Controllers/Models/RuleGroup/UpdateController.php

@@ -41,8 +41,6 @@ class UpdateController extends Controller
 
     /**
      * RuleGroupController constructor.
-     *
-
      */
     public function __construct()
     {
@@ -65,11 +63,6 @@ class UpdateController extends Controller
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rule_groups/updateRuleGroup
      *
      * Update a rule group.
-     *
-     * @param UpdateRequest $request
-     * @param RuleGroup     $ruleGroup
-     *
-     * @return JsonResponse
      */
     public function update(UpdateRequest $request, RuleGroup $ruleGroup): JsonResponse
     {