Code cleanup.

This commit is contained in:
James Cole
2023-12-20 19:35:52 +01:00
parent c4f6366642
commit 64ec0cf62e
997 changed files with 12908 additions and 28136 deletions

View File

@@ -44,8 +44,6 @@ class AttemptController extends Controller
public const string RESOURCE_KEY = 'webhook_attempts';
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -63,10 +61,6 @@ class AttemptController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/getWebhookMessageAttempts
*
* @param Webhook $webhook
* @param WebhookMessage $message
*
* @return JsonResponse
* @throws FireflyException
*/
public function index(Webhook $webhook, WebhookMessage $message): JsonResponse
@@ -83,7 +77,7 @@ class AttemptController extends Controller
// make paginator:
$paginator = new LengthAwarePaginator($attempts, $count, $pageSize, $this->parameters->get('page'));
$paginator->setPath(route('api.v1.webhooks.attempts.index', [$webhook->id, $message->id]) . $this->buildParams());
$paginator->setPath(route('api.v1.webhooks.attempts.index', [$webhook->id, $message->id]).$this->buildParams());
/** @var WebhookAttemptTransformer $transformer */
$transformer = app(WebhookAttemptTransformer::class);
@@ -101,11 +95,6 @@ class AttemptController extends Controller
*
* Show single instance.
*
* @param Webhook $webhook
* @param WebhookMessage $message
* @param WebhookAttempt $attempt
*
* @return JsonResponse
* @throws FireflyException
*/
public function show(Webhook $webhook, WebhookMessage $message, WebhookAttempt $attempt): JsonResponse

View File

@@ -39,8 +39,6 @@ class DestroyController extends Controller
{
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -59,10 +57,6 @@ class DestroyController extends Controller
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/deleteWebhook
*
* Remove the specified resource from storage.
*
* @param Webhook $webhook
*
* @return JsonResponse
*/
public function destroy(Webhook $webhook): JsonResponse
{
@@ -78,11 +72,6 @@ class DestroyController extends Controller
*
* Remove the specified resource from storage.
*
* @param Webhook $webhook
* @param WebhookMessage $message
* @param WebhookAttempt $attempt
*
* @return JsonResponse
* @throws FireflyException
*/
public function destroyAttempt(Webhook $webhook, WebhookMessage $message, WebhookAttempt $attempt): JsonResponse
@@ -106,10 +95,6 @@ class DestroyController extends Controller
*
* Remove the specified resource from storage.
*
* @param Webhook $webhook
* @param WebhookMessage $message
*
* @return JsonResponse
* @throws FireflyException
*/
public function destroyMessage(Webhook $webhook, WebhookMessage $message): JsonResponse

View File

@@ -43,8 +43,6 @@ class MessageController extends Controller
public const string RESOURCE_KEY = 'webhook_messages';
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -62,9 +60,6 @@ class MessageController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/getWebhookMessages
*
* @param Webhook $webhook
*
* @return JsonResponse
* @throws FireflyException
*/
public function index(Webhook $webhook): JsonResponse
@@ -78,7 +73,7 @@ class MessageController extends Controller
// make paginator:
$paginator = new LengthAwarePaginator($messages, $count, $pageSize, $this->parameters->get('page'));
$paginator->setPath(route('api.v1.webhooks.messages.index', [$webhook->id]) . $this->buildParams());
$paginator->setPath(route('api.v1.webhooks.messages.index', [$webhook->id]).$this->buildParams());
/** @var WebhookMessageTransformer $transformer */
$transformer = app(WebhookMessageTransformer::class);
@@ -96,10 +91,6 @@ class MessageController extends Controller
*
* Show single instance.
*
* @param Webhook $webhook
* @param WebhookMessage $message
*
* @return JsonResponse
* @throws FireflyException
*/
public function show(Webhook $webhook, WebhookMessage $message): JsonResponse

View File

@@ -46,8 +46,6 @@ class ShowController extends Controller
public const string RESOURCE_KEY = 'webhooks';
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -67,7 +65,6 @@ class ShowController extends Controller
*
* Display a listing of the webhooks of the user.
*
* @return JsonResponse
* @throws FireflyException
*/
public function index(): JsonResponse
@@ -80,7 +77,7 @@ class ShowController extends Controller
// make paginator:
$paginator = new LengthAwarePaginator($webhooks, $count, $pageSize, $this->parameters->get('page'));
$paginator->setPath(route('api.v1.webhooks.index') . $this->buildParams());
$paginator->setPath(route('api.v1.webhooks.index').$this->buildParams());
/** @var WebhookTransformer $transformer */
$transformer = app(WebhookTransformer::class);
@@ -97,10 +94,6 @@ class ShowController extends Controller
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/getWebhook
*
* Show single instance.
*
* @param Webhook $webhook
*
* @return JsonResponse
*/
public function show(Webhook $webhook): JsonResponse
{
@@ -119,15 +112,11 @@ class ShowController extends Controller
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/triggerWebhookTransaction
*
* This method recycles part of the code of the StoredGroupEventHandler.
*
* @param Webhook $webhook
* @param TransactionGroup $group
*
* @return JsonResponse
*/
public function triggerTransaction(Webhook $webhook, TransactionGroup $group): JsonResponse
{
app('log')->debug(sprintf('Now in triggerTransaction(%d, %d)', $webhook->id, $group->id));
/** @var MessageGeneratorInterface $engine */
$engine = app(MessageGeneratorInterface::class);
$engine->setUser(auth()->user());

View File

@@ -38,8 +38,6 @@ class StoreController extends Controller
public const string RESOURCE_KEY = 'webhooks';
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -56,16 +54,13 @@ class StoreController extends Controller
/**
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/storeWebhook
*
* @param CreateRequest $request
*
* @return JsonResponse
*/
public function store(CreateRequest $request): JsonResponse
{
$data = $request->getData();
$webhook = $this->repository->store($data);
$manager = $this->getManager();
/** @var WebhookTransformer $transformer */
$transformer = app(WebhookTransformer::class);
$transformer->setParameters($this->parameters);

View File

@@ -36,8 +36,6 @@ class SubmitController extends Controller
{
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -54,10 +52,6 @@ class SubmitController extends Controller
/**
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/submitWebook
*
* @param Webhook $webhook
*
* @return JsonResponse
*/
public function submit(Webhook $webhook): JsonResponse
{

View File

@@ -38,8 +38,6 @@ class UpdateController extends Controller
{
private WebhookRepositoryInterface $repository;
/**
*/
public function __construct()
{
parent::__construct();
@@ -56,17 +54,13 @@ class UpdateController extends Controller
/**
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/webhooks/updateWebhook
*
* @param Webhook $webhook
* @param UpdateRequest $request
*
* @return JsonResponse
*/
public function update(Webhook $webhook, UpdateRequest $request): JsonResponse
{
$data = $request->getData();
$webhook = $this->repository->update($webhook, $data);
$manager = $this->getManager();
/** @var WebhookTransformer $transformer */
$transformer = app(WebhookTransformer::class);
$transformer->setParameters($this->parameters);