Code cleanup.

This commit is contained in:
James Cole
2023-12-20 19:35:52 +01:00
parent c4f6366642
commit 64ec0cf62e
997 changed files with 12908 additions and 28136 deletions

View File

@@ -32,10 +32,6 @@ class AccountObserver
{
/**
* Also delete related objects.
*
* @param Account $account
*
* @return void
*/
public function deleting(Account $account): void
{
@@ -52,7 +48,5 @@ class AccountObserver
}
$account->notes()->delete();
$account->locations()->delete();
}
}

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\Bill;
*/
class BillObserver
{
/**
* @param Bill $bill
*
* @return void
*/
public function deleting(Bill $bill): void
{
app('log')->debug('Observe "deleting" of a bill.');
@@ -43,5 +38,4 @@ class BillObserver
}
$bill->notes()->delete();
}
}

View File

@@ -31,11 +31,6 @@ use FireflyIII\Models\BudgetLimit;
*/
class BudgetObserver
{
/**
* @param Budget $budget
*
* @return void
*/
public function deleting(Budget $budget): void
{
app('log')->debug('Observe "deleting" of a budget.');
@@ -43,6 +38,7 @@ class BudgetObserver
$attachment->delete();
}
$budgetLimits = $budget->budgetlimits()->get();
/** @var BudgetLimit $budgetLimit */
foreach($budgetLimits as $budgetLimit) {
// this loop exists so several events are fired.
@@ -53,7 +49,5 @@ class BudgetObserver
$budget->autoBudgets()->delete();
// recalculate available budgets.
}
}

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\Category;
*/
class CategoryObserver
{
/**
* @param Category $category
*
* @return void
*/
public function deleting(Category $category): void
{
app('log')->debug('Observe "deleting" of a category.');
@@ -43,5 +38,4 @@ class CategoryObserver
}
$category->notes()->delete();
}
}

View File

@@ -31,11 +31,6 @@ use FireflyIII\Models\PiggyBankRepetition;
*/
class PiggyBankObserver
{
/**
* @param PiggyBank $piggyBank
*
* @return void
*/
public function created(PiggyBank $piggyBank): void
{
app('log')->debug('Observe "created" of a piggy bank.');
@@ -49,10 +44,6 @@ class PiggyBankObserver
/**
* Also delete related objects.
*
* @param PiggyBank $piggyBank
*
* @return void
*/
public function deleting(PiggyBank $piggyBank): void
{
@@ -67,5 +58,4 @@ class PiggyBankObserver
$piggyBank->notes()->delete();
}
}

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\Recurrence;
*/
class RecurrenceObserver
{
/**
* @param Recurrence $recurrence
*
* @return void
*/
public function deleting(Recurrence $recurrence): void
{
app('log')->debug('Observe "deleting" of a recurrence.');
@@ -48,7 +43,5 @@ class RecurrenceObserver
$transaction->delete();
}
$recurrence->notes()->delete();
}
}

View File

@@ -30,15 +30,9 @@ use FireflyIII\Models\RecurrenceTransaction;
*/
class RecurrenceTransactionObserver
{
/**
* @param RecurrenceTransaction $transaction
*
* @return void
*/
public function deleting(RecurrenceTransaction $transaction): void
{
app('log')->debug('Observe "deleting" of a recurrence transaction.');
$transaction->recurrenceTransactionMeta()->delete();
}
}

View File

@@ -30,18 +30,11 @@ use FireflyIII\Models\RuleGroup;
*/
class RuleGroupObserver
{
/**
* @param RuleGroup $ruleGroup
*
* @return void
*/
public function deleting(RuleGroup $ruleGroup): void
{
app('log')->debug('Observe "deleting" of a rule group.');
foreach ($ruleGroup->rules()->get() as $rule) {
$rule->delete();
}
}
}

View File

@@ -30,16 +30,10 @@ use FireflyIII\Models\Rule;
*/
class RuleObserver
{
/**
* @param Rule $rule
*
* @return void
*/
public function deleting(Rule $rule): void
{
app('log')->debug('Observe "deleting" of a rule.');
$rule->ruleActions()->delete();
$rule->ruleTriggers()->delete();
}
}

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\Tag;
*/
class TagObserver
{
/**
* @param Tag $tag
*
* @return void
*/
public function deleting(Tag $tag): void
{
app('log')->debug('Observe "deleting" of a tag.');
@@ -44,7 +39,5 @@ class TagObserver
}
$tag->locations()->delete();
}
}

View File

@@ -37,5 +37,4 @@ class TransactionGroupObserver
$journal->delete();
}
}
}

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\TransactionJournal;
*/
class TransactionJournalObserver
{
/**
* @param TransactionJournal $transactionJournal
*
* @return void
*/
public function deleting(TransactionJournal $transactionJournal): void
{
app('log')->debug('Observe "deleting" of a transaction journal.');
@@ -53,5 +48,4 @@ class TransactionJournalObserver
$transactionJournal->destJournalLinks()->delete();
$transactionJournal->auditLogEntries()->delete();
}
}

View File

@@ -30,15 +30,9 @@ use FireflyIII\Models\Transaction;
*/
class TransactionObserver
{
/**
* @param Transaction|null $transaction
*
* @return void
*/
public function deleting(?Transaction $transaction): void
{
app('log')->debug('Observe "deleting" of a transaction.');
$transaction?->transactionJournal?->delete();
}
}

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\WebhookMessage;
*/
class WebhookMessageObserver
{
/**
* @param WebhookMessage $webhookMessage
*
* @return void
*/
public function deleting(WebhookMessage $webhookMessage): void
{
app('log')->debug('Observe "deleting" of a webhook message.');

View File

@@ -30,11 +30,6 @@ use FireflyIII\Models\Webhook;
*/
class WebhookObserver
{
/**
* @param Webhook $webhook
*
* @return void
*/
public function deleting(Webhook $webhook): void
{
app('log')->debug('Observe "deleting" of a webhook.');
@@ -42,5 +37,4 @@ class WebhookObserver
$message->delete();
}
}
}