kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-24 22:48:18 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup.

Browse Source
This commit is contained in:
James Cole
2023-12-20 19:35:52 +01:00
parent c4f6366642
commit 64ec0cf62e
997 changed files with 12908 additions and 28136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
app/Http/Controllers/ReportController.php
View File

@@ -44,7 +44,6 @@ use Psr\Container\NotFoundExceptionInterface;
/**
* Class ReportController.
*
*/
class ReportController extends Controller
{
@@ -76,11 +75,7 @@ class ReportController extends Controller
/**
* Show audit report.
*
* @param Collection $accounts
* @param Carbon $start
* @param Carbon $end
*
* @return Factory|View|string
* @return Factory|string|View
*
* @throws FireflyException
*/
@@ -111,12 +106,7 @@ class ReportController extends Controller
/**
* Show budget report.
*
* @param Collection $accounts
* @param Collection $budgets
* @param Carbon $start
* @param Carbon $end
*
* @return Factory|View|string
* @return Factory|string|View
*
* @throws FireflyException
*/
@@ -148,12 +138,7 @@ class ReportController extends Controller
/**
* Show category report.
*
* @param Collection $accounts
* @param Collection $categories
* @param Carbon $start
* @param Carbon $end
*
* @return Factory|View|string
* @return Factory|string|View
*
* @throws FireflyException
*/
@@ -185,11 +170,7 @@ class ReportController extends Controller
/**
* Show default report.
*
* @param Collection $accounts
* @param Carbon $start
* @param Carbon $end
*
* @return Factory|View|string
* @return Factory|string|View
*
* @throws FireflyException
*/
@@ -221,12 +202,8 @@ class ReportController extends Controller
/**
* Show account report.
*
* @param Collection $accounts
* @param Collection $expense
* @param Carbon $start
* @param Carbon $end
*
* @return string
*
* @throws FireflyException
*/
public function doubleReport(Collection $accounts, Collection $expense, Carbon $start, Carbon $end)
@@ -258,9 +235,8 @@ class ReportController extends Controller
/**
* Show index.
*
* @param AccountRepositoryInterface $repository
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
@@ -276,6 +252,7 @@ class ReportController extends Controller
// group accounts by role:
$groupedAccounts = [];
/** @var Account $account */
foreach ($accounts as $account) {
$type = $account->accountType->type;
@@ -301,9 +278,8 @@ class ReportController extends Controller
/**
* Show options for reports.
*
* @param string $reportType
*
* @return JsonResponse
*
* @throws FireflyException
*/
public function options(string $reportType)
@@ -322,14 +298,9 @@ class ReportController extends Controller
/**
* Process the submit of report.
*
* @param ReportFormRequest $request
*
* @return RedirectResponse|Redirector|View
*
* @throws FireflyException
*
*/
public function postIndex(ReportFormRequest $request): RedirectResponse | Redirector | View
public function postIndex(ReportFormRequest $request): Redirector|RedirectResponse|View
{
// report type:
$reportType = $request->get('report_type');
@@ -391,12 +362,8 @@ class ReportController extends Controller
/**
* Get a tag report.
*
* @param Collection $accounts
* @param Collection $tags
* @param Carbon $start
* @param Carbon $end
* @return Factory|string|View
*
* @return Factory|View|string
* @throws FireflyException
*/
public function tagReport(Collection $accounts, Collection $tags, Carbon $start, Carbon $end)