mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-10-12 15:35:15 +00:00
Code cleanup.
This commit is contained in:
@@ -39,11 +39,6 @@ use FireflyIII\Models\TransactionJournalMeta;
|
||||
*/
|
||||
class GroupCloneService
|
||||
{
|
||||
/**
|
||||
* @param TransactionGroup $group
|
||||
*
|
||||
* @return TransactionGroup
|
||||
*/
|
||||
public function cloneGroup(TransactionGroup $group): TransactionGroup
|
||||
{
|
||||
$newGroup = $group->replicate();
|
||||
@@ -55,11 +50,6 @@ class GroupCloneService
|
||||
return $newGroup;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param TransactionJournal $journal
|
||||
* @param TransactionGroup $newGroup
|
||||
* @param int $originalGroup
|
||||
*/
|
||||
private function cloneJournal(TransactionJournal $journal, TransactionGroup $newGroup, int $originalGroup): void
|
||||
{
|
||||
$newJournal = $journal->replicate();
|
||||
@@ -83,6 +73,7 @@ class GroupCloneService
|
||||
foreach ($journal->transactionJournalMeta as $meta) {
|
||||
$this->cloneMeta($meta, $newJournal);
|
||||
}
|
||||
|
||||
// clone category
|
||||
/** @var Category $category */
|
||||
foreach ($journal->categories as $category) {
|
||||
@@ -105,7 +96,7 @@ class GroupCloneService
|
||||
|
||||
// add relation.
|
||||
// TODO clone ALL linked piggy banks
|
||||
/** @var PiggyBankEvent|null $event */
|
||||
/** @var null|PiggyBankEvent $event */
|
||||
$event = $journal->piggyBankEvents()->first();
|
||||
if (null !== $event) {
|
||||
$piggyBank = $event->piggyBank;
|
||||
@@ -114,10 +105,6 @@ class GroupCloneService
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @param Transaction $transaction
|
||||
* @param TransactionJournal $newJournal
|
||||
*/
|
||||
private function cloneTransaction(Transaction $transaction, TransactionJournal $newJournal): void
|
||||
{
|
||||
$newTransaction = $transaction->replicate();
|
||||
@@ -126,11 +113,6 @@ class GroupCloneService
|
||||
$newTransaction->save();
|
||||
}
|
||||
|
||||
/**
|
||||
* @param Note $note
|
||||
* @param TransactionJournal $newJournal
|
||||
* @param int $oldGroupId
|
||||
*/
|
||||
private function cloneNote(Note $note, TransactionJournal $newJournal, int $oldGroupId): void
|
||||
{
|
||||
$newNote = $note->replicate();
|
||||
@@ -142,10 +124,6 @@ class GroupCloneService
|
||||
$newNote->save();
|
||||
}
|
||||
|
||||
/**
|
||||
* @param TransactionJournalMeta $meta
|
||||
* @param TransactionJournal $newJournal
|
||||
*/
|
||||
private function cloneMeta(TransactionJournalMeta $meta, TransactionJournal $newJournal): void
|
||||
{
|
||||
$newMeta = $meta->replicate();
|
||||
|
Reference in New Issue
Block a user