diff --git a/app/Http/Controllers/Auth/AuthController.php b/app/Http/Controllers/Auth/AuthController.php index ab6e06a35e..c4f5ba4f9b 100644 --- a/app/Http/Controllers/Auth/AuthController.php +++ b/app/Http/Controllers/Auth/AuthController.php @@ -58,15 +58,7 @@ class AuthController extends Controller */ public function postLogin(Request $request) { - $this->validate( - $request, [ - $this->loginUsername() => 'required', 'password' => 'required', - ] - ); - - // If the class is using the ThrottlesLogins trait, we can automatically throttle - // the login attempts for this application. We'll key this by the username and - // the IP address of the client making these requests into this application. + $this->validate($request, [$this->loginUsername() => 'required', 'password' => 'required',]); $throttles = $this->isUsingThrottlesLoginsTrait(); if ($throttles && $this->hasTooManyLoginAttempts($request)) { @@ -80,10 +72,7 @@ class AuthController extends Controller return $this->handleUserWasAuthenticated($request, $throttles); } - // default error message: $message = $this->getFailedLoginMessage(); - - // try to find a blocked user with this email address. /** @var User $foundUser */ $foundUser = User::where('email', $credentials['email'])->where('blocked', 1)->first(); if (!is_null($foundUser)) { @@ -95,22 +84,13 @@ class AuthController extends Controller $message = trans('firefly.' . $code . '_error', ['email' => $credentials['email']]); } - // try - - // If the login attempt was unsuccessful we will increment the number of attempts - // to login and redirect the user back to the login form. Of course, when this - // user surpasses their maximum number of attempts they will get locked out. if ($throttles) { $this->incrementLoginAttempts($request); } return redirect($this->loginPath()) ->withInput($request->only($this->loginUsername(), 'remember')) - ->withErrors( - [ - $this->loginUsername() => $message, - ] - ); + ->withErrors([$this->loginUsername() => $message,]); } diff --git a/app/Http/Controllers/TransactionController.php b/app/Http/Controllers/TransactionController.php index 60712a986e..54e9b5fc2b 100644 --- a/app/Http/Controllers/TransactionController.php +++ b/app/Http/Controllers/TransactionController.php @@ -163,11 +163,7 @@ class TransactionController extends Controller 'piggy_bank_id' => 0 ]; // get tags: - $tags = []; - foreach ($journal->tags as $tag) { - $tags[] = $tag->tag; - } - $preFilled['tags'] = join(',', $tags); + $preFilled['tags'] = join(',', $journal->tags->pluck('tag')->toArray()); $category = $journal->categories()->first(); if (!is_null($category)) { @@ -354,7 +350,6 @@ class TransactionController extends Controller public function update(JournalFormRequest $request, JournalRepositoryInterface $repository, AttachmentHelperInterface $att, TransactionJournal $journal) { - // cannot edit opening balance if ($journal->isOpeningBalance()) { return view('error')->with('message', 'Cannot edit this transaction. Edit the account instead!'); } diff --git a/app/Repositories/Account/AccountRepository.php b/app/Repositories/Account/AccountRepository.php index dd18c01265..a034e4534f 100644 --- a/app/Repositories/Account/AccountRepository.php +++ b/app/Repositories/Account/AccountRepository.php @@ -14,7 +14,6 @@ use FireflyIII\Models\Preference; use FireflyIII\Models\Transaction; use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionType; -use FireflyIII\Support\CacheProperties; use Illuminate\Database\Eloquent\Relations\HasMany; use Illuminate\Pagination\LengthAwarePaginator; use Illuminate\Support\Collection; @@ -39,14 +38,7 @@ class AccountRepository implements AccountRepositoryInterface */ public function countAccounts(array $types) { - $cache = new CacheProperties; - $cache->addProperty('user-count-accounts'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $count = Auth::user()->accounts()->accountTypeIn($types)->count(); - $cache->store($count); return $count; } @@ -76,14 +68,6 @@ class AccountRepository implements AccountRepositoryInterface */ public function getAccounts(array $types) { - $cache = new CacheProperties(); - $cache->addProperty('get-accounts'); - $cache->addProperty($types); - - if ($cache->has()) { - return $cache->get(); - } - /** @var Collection $result */ $result = Auth::user()->accounts()->with( ['accountmeta' => function (HasMany $query) { @@ -96,9 +80,6 @@ class AccountRepository implements AccountRepositoryInterface return strtolower($account->name); } ); - - $cache->store($result); - return $result; } @@ -116,12 +97,6 @@ class AccountRepository implements AccountRepositoryInterface */ public function getCreditCards(Carbon $date) { - $cache = new CacheProperties(); - $cache->addProperty('user-credit-cards'); - if ($cache->has()) { - return $cache->get(); - } - $set = Auth::user()->accounts() ->hasMetaValue('accountRole', 'ccAsset') ->hasMetaValue('ccType', 'monthlyFull') @@ -138,8 +113,6 @@ class AccountRepository implements AccountRepositoryInterface DB::Raw('SUM(`transactions`.`amount`) AS `balance`') ] ); - $cache->store($set); - return $set; } @@ -151,16 +124,7 @@ class AccountRepository implements AccountRepositoryInterface */ public function getFirstTransaction(TransactionJournal $journal, Account $account) { - $cache = new CacheProperties(); - $cache->addProperty('first-transaction'); - $cache->addProperty($journal->id); - $cache->addProperty($account->id); - - if ($cache->has()) { - return $cache->get(); - } $transaction = $journal->transactions()->where('account_id', $account->id)->first(); - $cache->store($transaction); return $transaction; } @@ -172,11 +136,6 @@ class AccountRepository implements AccountRepositoryInterface */ public function getFrontpageAccounts(Preference $preference) { - $cache = new CacheProperties(); - $cache->addProperty('user-frontpage-accounts'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } $query = Auth::user()->accounts()->accountTypeIn(['Default account', 'Asset account']); if (count($preference->data) > 0) { @@ -184,9 +143,6 @@ class AccountRepository implements AccountRepositoryInterface } $result = $query->get(['accounts.*']); - - $cache->store($result); - return $result; } @@ -203,15 +159,6 @@ class AccountRepository implements AccountRepositoryInterface */ public function getFrontpageTransactions(Account $account, Carbon $start, Carbon $end) { - $cache = new CacheProperties(); - $cache->addProperty($account->id); - $cache->addProperty($start); - $cache->addProperty($end); - $cache->addProperty('frontpage-transactions'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $set = Auth::user() ->transactionjournals() ->with(['transactions']) @@ -226,8 +173,6 @@ class AccountRepository implements AccountRepositoryInterface ->orderBy('transaction_journals.id', 'DESC') ->take(10) ->get(['transaction_journals.*', 'transaction_currencies.symbol', 'transaction_types.type']); - $cache->store($set); - return $set; } @@ -271,13 +216,6 @@ class AccountRepository implements AccountRepositoryInterface $ids = $collection->pluck('account_id')->toArray(); $accounts = new Collection; - $cache = new CacheProperties; - $cache->addProperty($ids); - $cache->addProperty('user-piggy-bank-accounts'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $ids = array_unique($ids); if (count($ids) > 0) { $accounts = Auth::user()->accounts()->whereIn('id', $ids)->where('accounts.active', 1)->get(); @@ -303,8 +241,6 @@ class AccountRepository implements AccountRepositoryInterface } ); - $cache->store($accounts); - return $accounts; } @@ -381,21 +317,12 @@ class AccountRepository implements AccountRepositoryInterface */ public function openingBalanceTransaction(Account $account) { - $cache = new CacheProperties; - $cache->addProperty($account->id); - $cache->addProperty('opening-balance-journal'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - - $journal = TransactionJournal ::orderBy('transaction_journals.date', 'ASC') ->accountIs($account) ->transactionTypes([TransactionType::OPENING_BALANCE]) ->orderBy('created_at', 'ASC') ->first(['transaction_journals.*']); - $cache->store($journal); return $journal; } diff --git a/app/Repositories/Bill/BillRepository.php b/app/Repositories/Bill/BillRepository.php index 54bba39d9f..b07a37f45a 100644 --- a/app/Repositories/Bill/BillRepository.php +++ b/app/Repositories/Bill/BillRepository.php @@ -10,7 +10,6 @@ use FireflyIII\Models\Bill; use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionType; use FireflyIII\Repositories\Account\AccountRepositoryInterface; -use FireflyIII\Support\CacheProperties; use Illuminate\Database\Query\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; @@ -136,13 +135,6 @@ class BillRepository implements BillRepositoryInterface */ public function getJournals(Bill $bill) { - $cache = new CacheProperties; - $cache->addProperty($bill->id); - $cache->addProperty('journals-for-bill'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $set = $bill->transactionjournals() ->leftJoin( 'transactions', function (JoinClause $join) { @@ -154,8 +146,6 @@ class BillRepository implements BillRepositoryInterface ->orderBy('transaction_journals.order', 'ASC') ->orderBy('transaction_journals.id', 'DESC') ->get(['transaction_journals.*', 'transactions.amount as journalAmount']); - $cache->store($set); - return $set; } @@ -450,13 +440,6 @@ class BillRepository implements BillRepositoryInterface */ public function getBillsPaidInRange(Carbon $start, Carbon $end) { - $cache = new CacheProperties; - $cache->addProperty($start); - $cache->addProperty($end); - $cache->addProperty('bills-paid-in-range'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } $amount = '0'; $bills = $this->getActiveBills(); @@ -477,8 +460,6 @@ class BillRepository implements BillRepositoryInterface $amount = bcadd($amount, $paid->sum_amount); } } - $cache->store($amount); - return $amount; } @@ -511,13 +492,6 @@ class BillRepository implements BillRepositoryInterface */ public function getBillsUnpaidInRange(Carbon $start, Carbon $end) { - $cache = new CacheProperties; - $cache->addProperty($start); - $cache->addProperty($end); - $cache->addProperty('bills-unpaid-in-range'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } $amount = '0'; $bills = $this->getActiveBills(); @@ -541,8 +515,6 @@ class BillRepository implements BillRepositoryInterface $amount = bcadd($amount, $bill->expectedAmount); } } - $cache->store($amount); - return $amount; } @@ -558,13 +530,6 @@ class BillRepository implements BillRepositoryInterface public function getCreditCardBill(Carbon $start, Carbon $end) { - $cache = new CacheProperties; - $cache->addProperty($start); - $cache->addProperty($end); - $cache->addProperty('credit-card-bill'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } /** @var AccountRepositoryInterface $accountRepository */ $accountRepository = app('FireflyIII\Repositories\Account\AccountRepositoryInterface'); $amount = '0'; diff --git a/app/Repositories/Budget/BudgetRepository.php b/app/Repositories/Budget/BudgetRepository.php index 85ec767e52..2750dcfe6a 100644 --- a/app/Repositories/Budget/BudgetRepository.php +++ b/app/Repositories/Budget/BudgetRepository.php @@ -10,7 +10,6 @@ use FireflyIII\Models\BudgetLimit; use FireflyIII\Models\LimitRepetition; use FireflyIII\Models\TransactionType; use FireflyIII\Repositories\Shared\ComponentRepository; -use FireflyIII\Support\CacheProperties; use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\Builder as QueryBuilder; use Illuminate\Database\Query\JoinClause; @@ -262,21 +261,10 @@ class BudgetRepository extends ComponentRepository implements BudgetRepositoryIn */ public function getCurrentRepetition(Budget $budget, Carbon $start, Carbon $end) { - $cache = new CacheProperties; - $cache->addProperty($budget->id); - $cache->addProperty($start); - $cache->addProperty($end); - - $cache->addProperty('getCurrentRepetition'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } $data = $budget->limitrepetitions() ->where('limit_repetitions.startdate', $start->format('Y-m-d 00:00:00')) ->where('limit_repetitions.enddate', $end->format('Y-m-d 00:00:00')) ->first(['limit_repetitions.*']); - $cache->store($data); - return $data; } @@ -381,17 +369,6 @@ class BudgetRepository extends ComponentRepository implements BudgetRepositoryIn */ public function getJournals(Budget $budget, LimitRepetition $repetition = null, $take = 50) { - $cache = new CacheProperties; - $cache->addProperty($budget->id); - if ($repetition) { - $cache->addProperty($repetition->id); - } - $cache->addProperty($take); - $cache->addProperty('getJournals'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $offset = intval(Input::get('page')) > 0 ? intval(Input::get('page')) * $take : 0; $setQuery = $budget->transactionJournals()->withRelevantData()->take($take)->offset($offset) ->orderBy('transaction_journals.date', 'DESC') @@ -411,7 +388,6 @@ class BudgetRepository extends ComponentRepository implements BudgetRepositoryIn $paginator = new LengthAwarePaginator($set, $count, $take, $offset); - $cache->store($paginator); return $paginator; } diff --git a/app/Repositories/Journal/JournalRepository.php b/app/Repositories/Journal/JournalRepository.php index 061d9c39a3..c3d4d08c5e 100644 --- a/app/Repositories/Journal/JournalRepository.php +++ b/app/Repositories/Journal/JournalRepository.php @@ -13,7 +13,6 @@ use FireflyIII\Models\Tag; use FireflyIII\Models\Transaction; use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionType; -use FireflyIII\Support\CacheProperties; use Illuminate\Pagination\LengthAwarePaginator; use Illuminate\Support\Collection; use Log; @@ -45,14 +44,7 @@ class JournalRepository implements JournalRepositoryInterface */ public function first() { - $cache = new CacheProperties; - $cache->addProperty('user-first-journal'); - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $entry = Auth::user()->transactionjournals()->orderBy('date', 'ASC')->first(['transaction_journals.*']); - $cache->store($entry); return $entry; } diff --git a/app/Repositories/Shared/ComponentRepository.php b/app/Repositories/Shared/ComponentRepository.php index 7c976e8784..aa604b2859 100644 --- a/app/Repositories/Shared/ComponentRepository.php +++ b/app/Repositories/Shared/ComponentRepository.php @@ -5,7 +5,6 @@ namespace FireflyIII\Repositories\Shared; use Carbon\Carbon; use DB; use FireflyIII\Models\TransactionType; -use FireflyIII\Support\CacheProperties; use Illuminate\Support\Collection; /** @@ -26,18 +25,6 @@ class ComponentRepository */ protected function commonBalanceInPeriod($object, Carbon $start, Carbon $end, Collection $accounts) { - $cache = new CacheProperties; // we must cache this. - $cache->addProperty($object->id); - $cache->addProperty(get_class($object)); - $cache->addProperty($start); - $cache->addProperty($end); - $cache->addProperty($accounts); - $cache->addProperty('balanceInPeriodList'); - - if ($cache->has()) { - return $cache->get(); // @codeCoverageIgnore - } - $ids = $accounts->pluck('id')->toArray(); @@ -51,8 +38,6 @@ class ComponentRepository ->first([DB::Raw('SUM(`transactions`.`amount`) as `journalAmount`')]); $amount = $entry->journalAmount; - $cache->store($amount); - return $amount; } } diff --git a/app/Repositories/Tag/TagRepository.php b/app/Repositories/Tag/TagRepository.php index 59085824ad..ccdb2d9dae 100644 --- a/app/Repositories/Tag/TagRepository.php +++ b/app/Repositories/Tag/TagRepository.php @@ -10,7 +10,6 @@ use FireflyIII\Models\Account; use FireflyIII\Models\Tag; use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionType; -use FireflyIII\Support\CacheProperties; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; @@ -155,13 +154,6 @@ class TagRepository implements TagRepositoryInterface */ public function get() { - $cache = new CacheProperties; - $cache->addProperty('tags-list'); - - if ($cache->has()) { - return $cache->get(); - } - /** @var Collection $tags */ $tags = Auth::user()->tags()->get(); $tags = $tags->sortBy( @@ -170,8 +162,6 @@ class TagRepository implements TagRepositoryInterface } ); - $cache->store($tags); - return $tags; }