From 65a2e07d245117b114d5ac7c3904e305ca232019 Mon Sep 17 00:00:00 2001
From: Sander Dorigo <thegrumpydictator@gmail.com>
Date: Sun, 12 Oct 2014 09:45:57 +0200
Subject: [PATCH] Cleaned out most of the "reminders" code.

---
 ...14_08_23_113221_create_reminders_table.php | 14 -------
 app/models/PiggybankReminder.php              |  8 ----
 app/models/RecurringTransaction.php           |  9 ----
 app/models/RecurringTransactionReminder.php   | 42 -------------------
 app/models/TransactionJournal.php             |  8 ++++
 app/models/User.php                           | 16 -------
 6 files changed, 8 insertions(+), 89 deletions(-)
 delete mode 100644 app/models/PiggybankReminder.php
 delete mode 100644 app/models/RecurringTransactionReminder.php

diff --git a/app/database/migrations/2014_08_23_113221_create_reminders_table.php b/app/database/migrations/2014_08_23_113221_create_reminders_table.php
index 73e53ae084..24b654a35f 100644
--- a/app/database/migrations/2014_08_23_113221_create_reminders_table.php
+++ b/app/database/migrations/2014_08_23_113221_create_reminders_table.php
@@ -28,25 +28,11 @@ class CreateRemindersTable extends Migration
                 $table->increments('id');
                 $table->timestamps();
                 $table->string('class', 40);
-                $table->integer('piggybank_id')->unsigned()->nullable();
-                $table->integer('recurring_transaction_id')->unsigned()->nullable();
                 $table->integer('user_id')->unsigned();
                 $table->date('startdate');
                 $table->date('enddate')->nullable();
                 $table->boolean('active');
 
-
-                // connect reminders to piggy banks.
-                $table->foreign('piggybank_id')
-                    ->references('id')->on('piggybanks')
-                    ->onDelete('set null');
-
-                // connect reminders to recurring transactions.
-                $table->foreign('recurring_transaction_id')
-                    ->references('id')->on('recurring_transactions')
-                    ->onDelete('set null');
-
-
                 // connect reminders to users
                 $table->foreign('user_id')
                     ->references('id')->on('users')
diff --git a/app/models/PiggybankReminder.php b/app/models/PiggybankReminder.php
deleted file mode 100644
index 1910ad964c..0000000000
--- a/app/models/PiggybankReminder.php
+++ /dev/null
@@ -1,8 +0,0 @@
-<?php
-
-class PiggybankReminder extends Reminder
-{
-    protected $isSubclass = true;
-
-
-} 
\ No newline at end of file
diff --git a/app/models/RecurringTransaction.php b/app/models/RecurringTransaction.php
index 0e098cf17e..394b2e14a0 100644
--- a/app/models/RecurringTransaction.php
+++ b/app/models/RecurringTransaction.php
@@ -62,15 +62,6 @@ class RecurringTransaction extends Ardent
     }
 
 
-    /**
-     * @return \Illuminate\Database\Eloquent\Relations\HasMany
-     */
-    public function reminders()
-    {
-        return $this->hasMany('RecurringTransactionReminder');
-
-    }
-
     /**
      * @return Carbon
      */
diff --git a/app/models/RecurringTransactionReminder.php b/app/models/RecurringTransactionReminder.php
deleted file mode 100644
index 8d0d728419..0000000000
--- a/app/models/RecurringTransactionReminder.php
+++ /dev/null
@@ -1,42 +0,0 @@
-<?php
-
-/**
- * RecurringTransactionReminder
- *
- * @property integer $id
- * @property \Carbon\Carbon $created_at
- * @property \Carbon\Carbon $updated_at
- * @property string $class
- * @property integer $piggybank_id
- * @property integer $recurring_transaction_id
- * @property integer $user_id
- * @property \Carbon\Carbon $startdate
- * @property \Carbon\Carbon $enddate
- * @property boolean $active
- * @property-read \Piggybank $piggybank
- * @property-read \RecurringTransaction $recurringTransaction
- * @property-read \User $user
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereId($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereCreatedAt($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereUpdatedAt($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereClass($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder wherePiggybankId($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereRecurringTransactionId($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereUserId($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereStartdate($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereEnddate($value)
- * @method static \Illuminate\Database\Query\Builder|\RecurringTransactionReminder whereActive($value)
- * @method static \Reminder validOn($date)
- * @method static \Reminder validOnOrAfter($date)
- */
-class RecurringTransactionReminder extends Reminder
-{
-    protected $isSubclass = true;
-
-    public function render()
-    {
-        return '123';
-    }
-
-
-}
\ No newline at end of file
diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php
index 3a6e000df9..432ee0aa7f 100644
--- a/app/models/TransactionJournal.php
+++ b/app/models/TransactionJournal.php
@@ -215,6 +215,14 @@ use LaravelBook\Ardent\Builder;
  *                     'Budget[] $budgets
  * @property-read \Illuminate\Database\Eloquent\Collection|\
  *                     'Category[] $categories
+ * @property-read \Illuminate\Database\Eloquent\Collection|\
+ *                     'Budget[] $budgets
+ * @property-read \Illuminate\Database\Eloquent\Collection|\
+ *                     'Category[] $categories
+ * @property-read \Illuminate\Database\Eloquent\Collection|\
+ *                     'Budget[] $budgets
+ * @property-read \Illuminate\Database\Eloquent\Collection|\
+ *                     'Category[] $categories
  */
 class TransactionJournal extends Ardent
 {
diff --git a/app/models/User.php b/app/models/User.php
index 601e182517..23b201fce6 100644
--- a/app/models/User.php
+++ b/app/models/User.php
@@ -78,22 +78,6 @@ class User extends Ardent implements UserInterface, RemindableInterface
         return $this->hasMany('Budget');
     }
 
-    /**
-     * @return \Illuminate\Database\Eloquent\Relations\HasMany
-     */
-    public function reminders()
-    {
-        return $this->hasMany('Reminder');
-    }
-
-    /**
-     * @return \Illuminate\Database\Eloquent\Relations\HasMany
-     */
-    public function piggybankreminders()
-    {
-        return $this->hasMany('PiggybankReminder');
-    }
-
     /**
      * @return \Illuminate\Database\Eloquent\Relations\HasMany
      */