kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-13 07:53:16 +00:00
Code Issues Projects Releases Wiki Activity

Fix #2680

Browse Source
This commit is contained in:
James Cole
2019-10-05 06:48:57 +02:00
parent 6cb60d95bd
commit 65dc8e1c57
1 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
app/Console/Commands/Correction/DeleteEmptyGroups.php
View File

@@ -55,28 +55,19 @@ class DeleteEmptyGroups extends Command
public function handle(): int public function handle(): int
{ {
$start = microtime(true); $start = microtime(true);
$groups = array_unique(TransactionJournal::get(['transaction_group_id'])->pluck('transaction_group_id')->toArray()); $groupIds =
TransactionGroup
// make chunks so SQLite can take the strain: ::leftJoin('transaction_journals','transaction_groups.id','=','transaction_journals.transaction_group_id')
$chunks = array_chunk($groups, 500); ->whereNull('transaction_journals.id')->get(['transaction_groups.id'])->pluck('id')->toArray();
$total = 0;
foreach ($chunks as $chunk) {
$count = TransactionGroup::whereNull('deleted_at')->whereNotIn('id', $chunk)->count();
$total += $count;
}
if (0 === $total) {
$this->info('No empty transaction groups.');
}
unset($chunks, $chunk, $count);
$total = count($groupIds);
if ($total > 0) { if ($total > 0) {
$this->info(sprintf('Deleted %d empty transaction group(s).', $total)); $this->info(sprintf('Deleted %d empty transaction group(s).', $total));
// again, chunks for SQLite. // again, chunks for SQLite.
$chunks = array_chunk($groups, 500); $chunks = array_chunk($groupIds, 500);
foreach ($chunks as $chunk) { foreach ($chunks as $chunk) {
TransactionGroup::whereNull('deleted_at')->whereNotIn('id', $chunk)->delete(); TransactionGroup::whereNull('deleted_at')->whereIn('id', $chunk)->delete();
} }
} }
$end = round(microtime(true) - $start, 2); $end = round(microtime(true) - $start, 2);