Fix max amount.

This commit is contained in:
James Cole
2018-07-22 08:36:30 +02:00
parent aed7e6d289
commit 662b832274
4 changed files with 23 additions and 5 deletions

View File

@@ -161,11 +161,11 @@ class JournalFormRequest extends Request
'due_date' => 'date|nullable',
'payment_date' => 'date|nullable',
'invoice_date' => 'date|nullable',
'internal_reference' => 'min:1,max:255|nullable',
'notes' => 'min:1,max:50000|nullable',
'internal_reference' => 'min:1|max:255|nullable',
'notes' => 'min:1|max:50000|nullable',
// and then transaction rules:
'description' => 'required|between:1,255',
'amount' => 'numeric|required|more:0',
'amount' => 'numeric|required|more:0|less:10000000',//
'budget_id' => 'mustExist:budgets,id|belongsToUser:budgets,id|nullable',
'category' => 'between:1,255|nullable',
'source_id' => 'numeric|belongsToUser:accounts,id|nullable',

View File

@@ -840,7 +840,7 @@ class BudgetRepository implements BudgetRepositoryInterface
Log::debug(sprintf('Updated trigger %d: %s', $trigger->id, $trigger->trigger_value));
}
// find any rule actions related to budgets, with this budget name, and update them accordingly.
$types = [
'set_budget',

View File

@@ -203,6 +203,23 @@ class FireflyValidator extends Validator
return bccomp((string)$value, (string)$compare) > 0;
}
/**
* @param $attribute
* @param $value
* @param $parameters
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*
* @return bool
*/
public function validateLess($attribute, $value, $parameters): bool
{
/** @var mixed $compare */
$compare = $parameters[0] ?? '0';
return bccomp((string)$value, (string)$compare) < 0;
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*