Various code cleanup.

This commit is contained in:
James Cole
2017-09-09 07:03:43 +02:00
parent f2cb675267
commit 66c13f35e7
5 changed files with 21 additions and 26 deletions

View File

@@ -251,15 +251,13 @@ class UpgradeDatabase extends Command
*/
public function updateTransferCurrencies()
{
/** @var CurrencyRepositoryInterface $repository */
$repository = app(CurrencyRepositoryInterface::class);
$set = TransactionJournal
::leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id')
->where('transaction_types.type', TransactionType::TRANSFER)
->get(['transaction_journals.*']);
$set->each(
function (TransactionJournal $transfer) use ($repository) {
function (TransactionJournal $transfer) {
// select all "source" transactions:
/** @var Collection $transactions */
$transactions = $transfer->transactions()->where('amount', '<', 0)->get();