Various code cleanup [skip ci]

app/Http/Controllers/TransactionController.php

@@ -17,7 +17,6 @@ use Response;
 use Session;
 use URL;
 use View;
-use Log;
 
 /**
  * Class TransactionController
@@ -291,7 +290,6 @@ class TransactionController extends Controller
     }
 
 
-
     /**
      * @param JournalFormRequest         $request
      * @param JournalRepositoryInterface $repository

app/Http/routes.php

@@ -177,7 +177,7 @@ Route::get('/register', ['uses' => 'Auth\AuthController@getRegister', 'as' => 'r
 
 Route::controllers(
     [
-        'auth' => 'Auth\AuthController',
+        'auth'     => 'Auth\AuthController',
         'password' => 'Auth\PasswordController',
     ]
 );

app/Repositories/Reminder/ReminderRepositoryInterface.php

@@ -1,6 +1,7 @@
 <?php
 
 namespace FireflyIII\Repositories\Reminder;
+
 use Illuminate\Support\Collection;
 
 

app/Support/Amount.php

@@ -155,7 +155,7 @@ class Amount
 
         $currencyPreference = Prefs::get('currencyPreference', 'EUR');
 
-        $currency           = TransactionCurrency::whereCode($currencyPreference->data)->first();
+        $currency = TransactionCurrency::whereCode($currencyPreference->data)->first();
         if ($currency) {
 
             Cache::forever('FFCURRENCYCODE', $currency->code);

app/Validation/FireflyValidator.php

@@ -203,7 +203,7 @@ class FireflyValidator extends Validator
             $alwaysEncrypted = true;
         }
 
-        if(is_null(Auth::user())) {
+        if (is_null(Auth::user())) {
             // user is not logged in.. weird.
             return true;
         } else {

database/migrations/2014_12_13_190730_changes_for_v321.php

@@ -7,6 +7,7 @@ use FireflyIII\Models\Component;
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
+
 /**
  * @SuppressWarnings(PHPMD.ShortMethodName) // method names are mandated by laravel.
  * @SuppressWarnings("TooManyMethods") // I'm fine with this

database/migrations/2015_03_29_174140_changes_for_v336.php

@@ -134,7 +134,7 @@ class ChangesForV336 extends Migration
         // reinstate a long forgotten index:
         Schema::table(
             'budget_limits', function (Blueprint $table) {
-            $table->unique(['budget_id', 'startdate'],'unique_limit');
+            $table->unique(['budget_id', 'startdate'], 'unique_limit');
         }
         );
 

database/migrations/2015_04_26_054507_changes_for_v3310.php

@@ -57,7 +57,8 @@ class ChangesForV3310 extends Migration
         );
 
 
-        Schema::create('tag_transaction_journal',function (Blueprint $table) {
+        Schema::create(
+            'tag_transaction_journal', function (Blueprint $table) {
             $table->increments('id');
             $table->integer('tag_id')->unsigned();
             $table->integer('transaction_journal_id')->unsigned();
@@ -69,7 +70,8 @@ class ChangesForV3310 extends Migration
             // add unique.
             $table->unique(['tag_id', 'transaction_journal_id'], 'tag_t_joined');
 
-        });
+        }
+        );
     }
 
 }

database/migrations/2015_04_28_075317_changes_for_v3310b.php

@@ -1,32 +1,32 @@
 <?php
 
-use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Database\Migrations\Migration;
 
 /**
  * Class ChangesForV3310b
  */
-class ChangesForV3310b extends Migration {
+class ChangesForV3310b extends Migration
+{
 
-	/**
+    /**
-	 * Run the migrations.
+     * Reverse the migrations.
-	 *
+     *
-	 * @return void
+     * @return void
-	 */
+     */
-	public function up()
+    public function down()
-	{
+    {
+        //
+    }
+
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
         // set all current entries to be "balance"
         DB::table('transaction_groups')->update(['relation' => 'balance']);
-	}
+    }
-
-	/**
-	 * Reverse the migrations.
-	 *
-	 * @return void
-	 */
-	public function down()
-	{
-		//
-	}
 
 }

tests/TestCase.php

@@ -46,7 +46,7 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase
 
             // create EUR currency
             /** @var TransactionCurrency $currency */
-            $currency = FactoryMuffin::create('FireflyIII\Models\TransactionCurrency');
+            $currency       = FactoryMuffin::create('FireflyIII\Models\TransactionCurrency');
             $currency->code = 'EUR';
             $currency->save();
             Log::debug('Created new EUR currency.');
@@ -66,8 +66,6 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase
         );
 
 
-
-
     }
 
     /**

tests/controllers/BillControllerTest.php

@@ -191,7 +191,6 @@ class BillControllerTest extends TestCase
         Amount::shouldReceive('getCurrencyCode')->andReturn('XX');
 
 
-
         $this->call('GET', '/bills/show/' . $bill->id);
     }
 

tests/controllers/HelpControllerTest.php

@@ -84,7 +84,7 @@ class HelpControllerTest extends TestCase
     public function testGetHelpTextNoRoute()
     {
         // login
-        $user    = FactoryMuffin::create('FireflyIII\User');
+        $user = FactoryMuffin::create('FireflyIII\User');
 
         $this->be($user);
         // mock some stuff.

tests/controllers/JsonControllerTest.php

@@ -210,7 +210,7 @@ class JsonControllerTest extends TestCase
     public function testTransactionJournals()
     {
         $journal    = FactoryMuffin::create('FireflyIII\Models\TransactionJournal');
-        $type = FactoryMuffin::create('FireflyIII\Models\TransactionType');
+        $type       = FactoryMuffin::create('FireflyIII\Models\TransactionType');
         $collection = new Collection([$journal]);
         $user       = FactoryMuffin::create('FireflyIII\User');
         $this->be($user);

tests/controllers/PiggyBankControllerTest.php

@@ -6,6 +6,7 @@ use FireflyIII\Models\Preference;
 use FireflyIII\Models\TransactionCurrency;
 use Illuminate\Support\Collection;
 use League\FactoryMuffin\Facade as FactoryMuffin;
+
 /**
  * Class PiggyBankControllerTest
  */
@@ -110,7 +111,7 @@ class PiggyBankControllerTest extends TestCase
 
     public function testEdit()
     {
-        $piggyBank = FactoryMuffin::create('FireflyIII\Models\PiggyBank');
+        $piggyBank             = FactoryMuffin::create('FireflyIII\Models\PiggyBank');
         $piggyBank->targetdate = Carbon::now()->addYear();
         $piggyBank->save();
         $this->be($piggyBank->account->user);

tests/controllers/PreferencesControllerTest.php

@@ -65,7 +65,7 @@ class PreferencesControllerTest extends TestCase
 
     public function testPostIndex()
     {
-        $user     = FactoryMuffin::create('FireflyIII\User');
+        $user = FactoryMuffin::create('FireflyIII\User');
         $this->be($user);
 
         $data = [

tests/controllers/ReminderControllerTest.php

@@ -59,7 +59,7 @@ class ReminderControllerTest extends TestCase
 
     public function testIndex()
     {
-        $user       = FactoryMuffin::create('FireflyIII\User');
+        $user = FactoryMuffin::create('FireflyIII\User');
         $this->be($user);
         $reminder   = FactoryMuffin::create('FireflyIII\Models\Reminder');
         $collection = new Collection([$reminder]);
@@ -77,7 +77,7 @@ class ReminderControllerTest extends TestCase
 
     public function testShow()
     {
-        $reminder = FactoryMuffin::create('FireflyIII\Models\Reminder');
+        $reminder         = FactoryMuffin::create('FireflyIII\Models\Reminder');
         $reminder->notnow = false;
         $reminder->save();
         $this->be($reminder->remindersable->account->user);
@@ -88,7 +88,7 @@ class ReminderControllerTest extends TestCase
 
     public function testShowDismissed()
     {
-        $reminder = FactoryMuffin::create('FireflyIII\Models\Reminder');
+        $reminder         = FactoryMuffin::create('FireflyIII\Models\Reminder');
         $reminder->notnow = true;
         $reminder->save();
         $this->be($reminder->remindersable->account->user);

tests/controllers/SearchControllerTest.php

@@ -1,7 +1,5 @@
 <?php
 
-use Carbon\Carbon;
-use Illuminate\Support\Collection;
 use League\FactoryMuffin\Facade as FactoryMuffin;
 
 /**
@@ -38,7 +36,8 @@ class SearchControllerTest extends TestCase
         parent::tearDown();
     }
 
-    public function testSearch() {
+    public function testSearch()
+    {
         $user = FactoryMuffin::create('FireflyIII\User');
         $this->be($user);
         $words = ['Something'];
@@ -50,7 +49,7 @@ class SearchControllerTest extends TestCase
         $repository->shouldReceive('searchBudgets')->with($words)->once()->andReturn([]);
         $repository->shouldReceive('searchTags')->with($words)->once()->andReturn([]);
 
-        $this->call('GET','/search?q=Something');
+        $this->call('GET', '/search?q=Something');
         $this->assertResponseOk();
     }
 }