kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

chore: fix various qodana issues

Browse Source
This commit is contained in:
James Cole
2023-06-04 06:30:22 +02:00
parent 160c364d2a
commit 688ca8e374
20 changed files with 56 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/Services/Internal/Support/AccountServiceTrait.php
View File

@@ -151,7 +151,7 @@ trait AccountServiceTrait
if (is_bool($data[$field]) && false === $data[$field]) {
$data[$field] = 0;
}
if (is_bool($data[$field]) && true === $data[$field]) {
if (true === $data[$field]) {
$data[$field] = 1;
}
if ($data[$field] instanceof Carbon) {
@@ -171,15 +171,14 @@ trait AccountServiceTrait
*/
public function updateNote(Account $account, string $note): bool
{
$dbNote = $account->notes()->first();
if ('' === $note) {
$dbNote = $account->notes()->first();
if (null !== $dbNote) {
$dbNote->delete();
}
return true;
}
$dbNote = $account->notes()->first();
if (null === $dbNote) {
$dbNote = new Note();
$dbNote->noteable()->associate($account);