kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-25 05:03:13 +00:00
Code Issues Projects Releases Wiki Activity

Expand tests for account API.

Browse Source
This commit is contained in:
James Cole
2018-02-17 19:56:45 +01:00
parent ecd4a862ff
commit 6cda9f2900
2 changed files with 357 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Api/V1/Controllers/AccountController.php
View File

@@ -154,8 +154,8 @@ class AccountController extends Controller
$data = $request->getAll();
// if currency ID is 0, find the currency by the code:
if ($data['currency_id'] === 0) {
$currency = $this->currencyRepository->findByCode($data['currency_code']);
$data['currency_id'] = $currency->id;
$currency = $this->currencyRepository->findByCodeNull($data['currency_code']);
$data['currency_id'] = is_null($currency) ? 0 : $currency->id;
}
$account = $this->repository->store($data);
$manager = new Manager();
@@ -179,8 +179,8 @@ class AccountController extends Controller
$data = $request->getAll();
// if currency ID is 0, find the currency by the code:
if ($data['currency_id'] === 0) {
$currency = $this->currencyRepository->findByCode($data['currency_code']);
$data['currency_id'] = $currency->id;
$currency = $this->currencyRepository->findByCodeNull($data['currency_code']);
$data['currency_id'] = is_null($currency) ? 0 : $currency->id;
}
// set correct type:
$data['type'] = config('firefly.shortNamesByFullName.' . $account->accountType->type);
@@ -256,6 +256,6 @@ class AccountController extends Controller
return $types[$type];
}
return $types['all'];
return $types['all']; // @codeCoverageIgnore
}
}