From 6ed5be10b120c2a43c7821dcb74c3fb482d45589 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Fri, 1 Jun 2018 22:20:08 +0200
Subject: [PATCH] Expand test coverage.

---
 .../Controllers/System/InstallController.php  |  1 +
 .../Transaction/BulkControllerTest.php        | 68 ++++++++++++++++++-
 .../Routine/File/MappingConvergerTest.php     |  2 +-
 3 files changed, 68 insertions(+), 3 deletions(-)

diff --git a/app/Http/Controllers/System/InstallController.php b/app/Http/Controllers/System/InstallController.php
index a84a03b1e0..9945f9d4d9 100644
--- a/app/Http/Controllers/System/InstallController.php
+++ b/app/Http/Controllers/System/InstallController.php
@@ -33,6 +33,7 @@ use Log;
 use phpseclib\Crypt\RSA;
 
 /**
+ * @codeCoverageIgnore
  * Class InstallController
  */
 class InstallController extends Controller
diff --git a/tests/Feature/Controllers/Transaction/BulkControllerTest.php b/tests/Feature/Controllers/Transaction/BulkControllerTest.php
index 608e3944a3..d8133c1b41 100644
--- a/tests/Feature/Controllers/Transaction/BulkControllerTest.php
+++ b/tests/Feature/Controllers/Transaction/BulkControllerTest.php
@@ -50,8 +50,8 @@ class BulkControllerTest extends TestCase
 
 
     /**
-     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController::edit
-     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController::__construct
+     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController
+     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController
      */
     public function testEdit(): void
     {
@@ -75,6 +75,32 @@ class BulkControllerTest extends TestCase
         $response->assertSee('<ol class="breadcrumb">');
     }
 
+    /**
+     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController
+     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController
+     */
+    public function testEditNull(): void
+    {
+        // mock stuff:
+        $journalRepos = $this->mock(JournalRepositoryInterface::class);
+        $budgetRepos  = $this->mock(BudgetRepositoryInterface::class);
+        $budgetRepos->shouldReceive('getActiveBudgets')->andReturn(new Collection);
+        $journalRepos->shouldReceive('getJournalSourceAccounts')->andReturn(new Collection);
+        $journalRepos->shouldReceive('getJournalDestinationAccounts')->andReturn(new Collection);
+        $journalRepos->shouldReceive('firstNull')->andReturn(new TransactionJournal, null);
+        $journalRepos->shouldReceive('getTransactionType')->andReturn('Transfer');
+        $journalRepos->shouldReceive('isJournalReconciled')->andReturn(false);
+
+        $transfers = TransactionJournal::where('transaction_type_id', 3)->where('user_id', $this->user()->id)->take(4)->get()->pluck('id')->toArray();
+
+        $this->be($this->user());
+        $response = $this->get(route('transactions.bulk.edit', $transfers));
+        $response->assertStatus(200);
+        $response->assertSee('Bulk edit a number of transactions');
+        // has bread crumb
+        $response->assertSee('<ol class="breadcrumb">');
+    }
+
     /**
      * @covers \FireflyIII\Http\Controllers\Transaction\BulkController::edit
      */
@@ -141,6 +167,44 @@ class BulkControllerTest extends TestCase
                    ->withArgs([Mockery::any(), ['tags' => $tags]]);
 
 
+        $route = route('transactions.bulk.update');
+        $this->be($this->user());
+        $response = $this->post($route, $data);
+        $response->assertStatus(302);
+        $response->assertSessionHas('success');
+    }
+
+    /**
+     * @covers \FireflyIII\Http\Controllers\Transaction\BulkController
+     * @covers \FireflyIII\Http\Requests\BulkEditJournalRequest
+     */
+    public function testUpdateNull(): void
+    {
+        $tags       = ['a', 'b', 'c'];
+        $collection = TransactionJournal::where('transaction_type_id', 1)->where('user_id', $this->user()->id)->take(4)->get();
+        $allIds     = $collection->pluck('id')->toArray();
+
+        $data = [
+            'category'  => 'Some new category',
+            'budget_id' => 1,
+            'tags'      => 'a,b,c',
+            'journals'  => $allIds,
+        ];
+
+        $repository = $this->mock(JournalRepositoryInterface::class);
+        $repository->shouldReceive('firstNull')->once()->andReturn(new TransactionJournal);
+        $repository->shouldReceive('findNull')->times(4)->andReturn(new TransactionJournal, null);
+
+        $repository->shouldReceive('updateCategory')->times(1)->andReturn(new TransactionJournal())
+                   ->withArgs([Mockery::any(), $data['category']]);
+
+        $repository->shouldReceive('updateBudget')->times(1)->andReturn(new TransactionJournal())
+                   ->withArgs([Mockery::any(), $data['budget_id']]);
+
+        $repository->shouldReceive('updateTags')->times(1)->andReturn(new TransactionJournal())
+                   ->withArgs([Mockery::any(), ['tags' => $tags]]);
+
+
         $route = route('transactions.bulk.update');
         $this->be($this->user());
         $response = $this->post($route, $data);
diff --git a/tests/Unit/Support/Import/Routine/File/MappingConvergerTest.php b/tests/Unit/Support/Import/Routine/File/MappingConvergerTest.php
index 256ff75c85..e6a56968aa 100644
--- a/tests/Unit/Support/Import/Routine/File/MappingConvergerTest.php
+++ b/tests/Unit/Support/Import/Routine/File/MappingConvergerTest.php
@@ -120,7 +120,7 @@ class MappingConvergerTest extends TestCase
 
         $job                = new ImportJob;
         $job->user_id       = $this->user()->id;
-        $job->key           = 'linerA' . random_int(1, 1000);
+        $job->key           = 'linerB' . random_int(1, 1000);
         $job->status        = 'new';
         $job->stage         = 'new';
         $job->provider      = 'fake';