Refactor and rename test code.

This commit is contained in:
James Cole
2018-05-21 07:22:38 +02:00
parent 620c5f515e
commit 714b54ed06
37 changed files with 363 additions and 939 deletions

View File

@@ -24,13 +24,22 @@ declare(strict_types=1);
namespace tests\Unit\Support\Import\Routine\Spectre;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\ImportJob;
use FireflyIII\Models\Preference;
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
use FireflyIII\Services\Spectre\Object\Attempt;
use FireflyIII\Services\Spectre\Object\Customer;
use FireflyIII\Services\Spectre\Object\Holder;
use FireflyIII\Services\Spectre\Object\Login;
use FireflyIII\Services\Spectre\Request\ListCustomersRequest;
use FireflyIII\Services\Spectre\Request\ListLoginsRequest;
use FireflyIII\Support\Import\Information\GetSpectreCustomerTrait;
use FireflyIII\Services\Spectre\Request\NewCustomerRequest;
use FireflyIII\Support\Import\Routine\Spectre\StageNewHandler;
use Tests\TestCase;
use Mockery;
use Preferences;
use Tests\TestCase;
/**
* Class StageNewHandlerTest
*/
@@ -43,6 +52,7 @@ class StageNewHandlerTest extends TestCase
/**
* run() with zero logins and a non-existing customer (must be created by Spectre).
*
* @covers \FireflyIII\Support\Import\Information\GetSpectreCustomerTrait
* @covers \FireflyIII\Support\Import\Routine\Spectre\StageNewHandler
*/
public function testRunBasic(): void
@@ -57,24 +67,303 @@ class StageNewHandlerTest extends TestCase
$job->configuration = [];
$job->save();
// mock classes:
$trait = $this->mock(GetSpectreCustomerTrait::class);
$llRequest = $this->mock(ListLoginsRequest::class);
$lcRequest = $this->mock(ListCustomersRequest::class);
// fake Spectre customer:
$fakeCustomer = new Customer(
[
'id' => 1,
'identifier' => 'fake',
'secret' => 'Dumbledore dies',
]
);
// mock calls for list logins
// mock classes:
$llRequest = $this->mock(ListLoginsRequest::class);
$lcRequest = $this->mock(ListCustomersRequest::class);
$ncRequest = $this->mock(NewCustomerRequest::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
// mock calls for list logins (return empty list for now).
$llRequest->shouldReceive('setUser')->once();
$llRequest->shouldReceive('setCustomer')->once();
$llRequest->shouldReceive('call')->once();
$llRequest->shouldReceive('getLogins')->once()->andReturn([]);
// mock calls for list customers (return empty list).
$lcRequest->shouldReceive('setUser')->once();
$lcRequest->shouldReceive('call')->once();
$lcRequest->shouldReceive('getCustomers')->once()->andReturn([]);
// create new customer:
$ncRequest->shouldReceive('setUser')->once();
$ncRequest->shouldReceive('getCustomer')->once()->andReturn($fakeCustomer);
// mock calls for repository:
$repository->shouldReceive('setUser')->once();
$repository->shouldReceive('getConfiguration')->once()->withArgs([Mockery::any()])->andReturn([]);
// mock call for preferences
Preferences::shouldReceive('getForUser')->once()->withArgs([Mockery::any(), 'spectre_customer', null])->andReturnNull();
$handler = new StageNewHandler;
$handler->setImportJob($job);
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertTrue(false, $e->getMessage());
}
}
/**
* run() with zero logins and an existing customer (from preferences).
*
* @covers \FireflyIII\Support\Import\Information\GetSpectreCustomerTrait
* @covers \FireflyIII\Support\Import\Routine\Spectre\StageNewHandler
*/
public function testRunExistingCustomer(): void
{
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'sn_a_' . random_int(1, 1000);
$job->status = 'new';
$job->stage = 'new';
$job->provider = 'spectre';
$job->file_type = '';
$job->configuration = [];
$job->save();
$fakeCustomerPreference = new Preference;
$fakeCustomerPreference->name = 'spectre_customer';
$fakeCustomerPreference->data = [
'id' => 1,
'identifier' => 'fake',
'secret' => 'Dumbledore dies',
];
// mock classes:
$llRequest = $this->mock(ListLoginsRequest::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
// mock calls for list logins (return empty list for now).
$llRequest->shouldReceive('setUser')->once();
$llRequest->shouldReceive('setCustomer')->once();
$llRequest->shouldReceive('call')->once();
$llRequest->shouldReceive('getLogins')->once()->andReturn([]);
// mock call for preferences
// todo here we are
Preferences::shouldReceive('getForUser');
Preferences::shouldReceive('getForUser')->once()->withArgs([Mockery::any(), 'spectre_customer', null])->andReturn($fakeCustomerPreference);
// mock calls for repository:
$repository->shouldReceive('setUser')->once();
$repository->shouldReceive('getConfiguration')->once()->withArgs([Mockery::any()])->andReturn([]);
$handler = new StageNewHandler;
$handler->setImportJob($job);
$handler->run();
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertTrue(false, $e->getMessage());
}
}
/**
* run() with zero logins and multiple customers at Spectre (none in prefs)
*
* @covers \FireflyIII\Support\Import\Information\GetSpectreCustomerTrait
* @covers \FireflyIII\Support\Import\Routine\Spectre\StageNewHandler
*/
public function testRunMultiCustomer(): void
{
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'sn_a_' . random_int(1, 1000);
$job->status = 'new';
$job->stage = 'new';
$job->provider = 'spectre';
$job->file_type = '';
$job->configuration = [];
$job->save();
// fake Spectre customer:
$fakeCustomer = new Customer(
[
'id' => 1,
'identifier' => 'fake',
'secret' => 'Dumbledore dies',
]
);
$correctCustomer = new Customer(
[
'id' => 1,
'identifier' => 'default_ff3_customer',
'secret' => 'Firefly III',
]
);
// mock classes:
$llRequest = $this->mock(ListLoginsRequest::class);
$lcRequest = $this->mock(ListCustomersRequest::class);
$ncRequest = $this->mock(NewCustomerRequest::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
// mock calls for list logins (return empty list for now).
$llRequest->shouldReceive('setUser')->once();
$llRequest->shouldReceive('setCustomer')->once();
$llRequest->shouldReceive('call')->once();
$llRequest->shouldReceive('getLogins')->once()->andReturn([]);
// mock calls for list customers (return empty list).
$lcRequest->shouldReceive('setUser')->once();
$lcRequest->shouldReceive('call')->once();
$lcRequest->shouldReceive('getCustomers')->once()->andReturn([$fakeCustomer, $correctCustomer]);
// mock calls for repository:
$repository->shouldReceive('setUser')->once();
$repository->shouldReceive('getConfiguration')->once()->withArgs([Mockery::any()])->andReturn([]);
// mock call for preferences
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'spectre_customer', null])->andReturnNull()->once();
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'spectre_customer', $correctCustomer->toArray()])->once();
$handler = new StageNewHandler;
$handler->setImportJob($job);
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertTrue(false, $e->getMessage());
}
}
/**
* run() with one login and multiple customers at Spectre (none in prefs)
*
* @covers \FireflyIII\Support\Import\Information\GetSpectreCustomerTrait
* @covers \FireflyIII\Support\Import\Routine\Spectre\StageNewHandler
*/
public function testRunMultiCustomerLogin(): void
{
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'sn_a_' . random_int(1, 1000);
$job->status = 'new';
$job->stage = 'new';
$job->provider = 'spectre';
$job->file_type = '';
$job->configuration = [];
$job->save();
// fake Spectre customer:
$fakeCustomer = new Customer(
[
'id' => 1,
'identifier' => 'fake',
'secret' => 'Dumbledore dies',
]
);
$correctCustomer = new Customer(
[
'id' => 1,
'identifier' => 'default_ff3_customer',
'secret' => 'Firefly III',
]
);
// fake login:
$holder = new Holder([]);
$attempt = new Attempt(
[
'api_mode' => 'x',
'api_version' => 4,
'automatic_fetch' => true,
'categorize' => true,
'created_at' => '2018-05-21 12:00:00',
'consent_given_at' => '2018-05-21 12:00:00',
'consent_types' => ['transactions'],
'custom_fields' => [],
'daily_refresh' => true,
'device_type' => 'mobile',
'user_agent' => 'Mozilla/x',
'remote_ip' => '127.0.0.1',
'exclude_accounts' => [],
'fail_at' => '2018-05-21 12:00:00',
'fail_error_class' => 'err',
'fail_message' => 'message',
'fetch_scopes' => [],
'finished' => true,
'finished_recent' => true,
'from_date' => '2018-05-21 12:00:00',
'id' => 1,
'interactive' => true,
'locale' => 'en',
'partial' => true,
'show_consent_confirmation' => true,
'stages' => [],
'store_credentials' => true,
'success_at' => '2018-05-21 12:00:00',
'to_date' => '2018-05-21 12:00:00',
'updated_at' => '2018-05-21 12:00:00',
]
);
$login = new Login(
[
'consent_given_at' => '2018-05-21 12:00:00',
'consent_types' => ['transactions'],
'country_code' => 'NL',
'created_at' => '2018-05-21 12:00:00',
'updated_at' => '2018-05-21 12:00:00',
'customer_id' => '1',
'daily_refresh' => true,
'holder_info' => $holder->toArray(),
'id' => 123,
'last_attempt' => $attempt->toArray(),
'last_success_at' => '2018-05-21 12:00:00',
'next_refresh_possible_at' => '2018-05-21 12:00:00',
'provider_code' => 'XF',
'provider_id' => '123',
'provider_name' => 'Fake',
'show_consent_confirmation' => true,
'status' => 'active',
'store_credentials' => true,
]
);
// mock classes:
$llRequest = $this->mock(ListLoginsRequest::class);
$lcRequest = $this->mock(ListCustomersRequest::class);
$ncRequest = $this->mock(NewCustomerRequest::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
// mock calls for list logins (return empty list for now).
$llRequest->shouldReceive('setUser')->once();
$llRequest->shouldReceive('setCustomer')->once();
$llRequest->shouldReceive('call')->once();
$llRequest->shouldReceive('getLogins')->once()->andReturn([$login]);
// mock calls for list customers (return empty list).
$lcRequest->shouldReceive('setUser')->once();
$lcRequest->shouldReceive('call')->once();
$lcRequest->shouldReceive('getCustomers')->once()->andReturn([$fakeCustomer, $correctCustomer]);
// mock call for preferences
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'spectre_customer', null])->andReturnNull()->once();
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'spectre_customer', $correctCustomer->toArray()])->once();
// mock calls for repository:
$repository->shouldReceive('setUser')->once();
$repository->shouldReceive('getConfiguration')->once()->withArgs([Mockery::any()])->andReturn([]);
$repository->shouldReceive('setConfiguration')->once()
->withArgs([Mockery::any(), ['all-logins' => [$login->toArray()]]]);
$handler = new StageNewHandler;
$handler->setImportJob($job);
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertTrue(false, $e->getMessage());
}
}
}