kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-19 19:01:58 +00:00
Code Issues Projects Releases Wiki Activity

Removed TODO items in favour of issues, or actual fixes.

Browse Source
This commit is contained in:
James Cole
2016-01-28 21:05:26 +01:00
parent 111fcd77c4
commit 71bf054ab1
4 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Http/Controllers/Chart/BudgetController.php
View File

@@ -37,7 +37,6 @@ class BudgetController extends Controller
} }
/** /**
* TODO expand with no budget chart.
* *
* @param BudgetRepositoryInterface $repository * @param BudgetRepositoryInterface $repository
* @param $reportType * @param $reportType
@@ -147,7 +146,7 @@ class BudgetController extends Controller
$last = Navigation::endOfX($last, $range, $final); $last = Navigation::endOfX($last, $range, $final);
$entries = new Collection; $entries = new Collection;
// get all expenses: // get all expenses:
$set = $repository->getExpensesPerMonth($budget, $first, $last); // TODO $set = $repository->getExpensesPerMonth($budget, $first, $last);
while ($first < $last) { while ($first < $last) {
$monthFormatted = $first->format('Y-m'); $monthFormatted = $first->format('Y-m');
@@ -294,7 +293,6 @@ class BudgetController extends Controller
} }
/** /**
* TODO expand with no budget chart.
* *
* @param BudgetRepositoryInterface $repository * @param BudgetRepositoryInterface $repository
* @param $reportType * @param $reportType

1
app/Http/Controllers/RuleController.php
View File

@@ -250,6 +250,7 @@ class RuleController extends Controller
$data = [ $data = [
'rule_group_id' => $ruleGroup->id, 'rule_group_id' => $ruleGroup->id,
'title' => $request->get('title'), 'title' => $request->get('title'),
'user_id' => Auth::user()->id,
'trigger' => $request->get('trigger'), 'trigger' => $request->get('trigger'),
'description' => $request->get('description'), 'description' => $request->get('description'),
'rule-triggers' => $request->get('rule-trigger'), 'rule-triggers' => $request->get('rule-trigger'),

2
app/Repositories/Rule/RuleRepository.php
View File

@@ -194,7 +194,7 @@ class RuleRepository implements RuleRepositoryInterface
// start by creating a new rule: // start by creating a new rule:
$rule = new Rule; $rule = new Rule;
$rule->user()->associate(Auth::user()); // TODO must be $data['user'] $rule->user()->associate($data['user_id']);
$rule->rule_group_id = $data['rule_group_id']; $rule->rule_group_id = $data['rule_group_id'];
$rule->order = ($order + 1); $rule->order = ($order + 1);

2
app/Rules/Processor.php
View File

@@ -120,8 +120,6 @@ class Processor
} }
/** /**
* TODO stop when stop_processing is present.
*
* @return bool * @return bool
*/ */
protected function triggered() protected function triggered()