kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage and quality

Browse Source
This commit is contained in:
James Cole
2019-06-16 13:16:46 +02:00
parent 1ce1a84c9e
commit 72c0d7a874
34 changed files with 3211 additions and 2524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/Feature/Controllers/Account/CreateControllerTest.php
View File

@@ -101,7 +101,7 @@ class CreateControllerTest extends TestCase
$this->session(['accounts.create.uri' => 'http://localhost']);
$this->be($this->user());
$data = [
'name' => 'new account ' . random_int(1000, 9999),
'name' => 'new account ' . $this->randomInt(),
'what' => 'asset',
];
@@ -127,7 +127,7 @@ class CreateControllerTest extends TestCase
$this->session(['accounts.create.uri' => 'http://localhost']);
$this->be($this->user());
$data = [
'name' => 'new account ' . random_int(1000, 9999),
'name' => 'new account ' . $this->randomInt(),
'what' => 'asset',
'create_another' => 1,
];
@@ -157,7 +157,7 @@ class CreateControllerTest extends TestCase
$this->session(['accounts.create.uri' => 'http://localhost']);
$this->be($this->user());
$data = [
'name' => 'new liability account ' . random_int(1000, 9999),
'name' => 'new liability account ' . $this->randomInt(),
'what' => 'liabilities',
'liability_type_id' => AccountType::where('type', AccountType::LOAN)->first()->id,
'openingBalance' => '100',

4
tests/Feature/Controllers/Account/EditControllerTest.php
View File

@@ -205,7 +205,7 @@ class EditControllerTest extends TestCase
$this->session(['accounts.edit.uri' => 'http://localhost/javascript/account']);
$this->be($this->user());
$data = [
'name' => 'updated account ' . random_int(1000, 9999),
'name' => 'updated account ' . $this->randomInt(),
'active' => 1,
'what' => 'asset',
];
@@ -232,7 +232,7 @@ class EditControllerTest extends TestCase
$this->session(['accounts.edit.uri' => 'http://localhost']);
$this->be($this->user());
$data = [
'name' => 'updated account ' . random_int(1000, 9999),
'name' => 'updated account ' . $this->randomInt(),
'active' => 1,
'what' => 'asset',
'return_to_edit' => '1',

2
tests/Feature/Controllers/AttachmentControllerTest.php
View File

@@ -190,7 +190,7 @@ class AttachmentControllerTest extends TestCase
$this->session(['attachments.edit.uri' => 'http://localhost']);
$data = [
'title' => 'Some updated title ' . random_int(1000, 9999),
'title' => 'Some updated title ' . $this->randomInt(),
'notes' => 'A',
'description' => 'B',
];

10
tests/Feature/Controllers/BillControllerTest.php
View File

@@ -326,7 +326,7 @@ class BillControllerTest extends TestCase
$attachHelper->shouldReceive('getMessages')->andReturn(new MessageBag);
$data = [
'name' => 'New Bill ' . random_int(1000, 9999),
'name' => 'New Bill ' . $this->randomInt(),
'amount_min' => '100',
'transaction_currency_id' => 1,
'skip' => 0,
@@ -364,7 +364,7 @@ class BillControllerTest extends TestCase
$attachHelper->shouldReceive('getMessages')->andReturn(new MessageBag);
$data = [
'name' => 'New Bill ' . random_int(1000, 9999),
'name' => 'New Bill ' . $this->randomInt(),
'amount_min' => '100',
'transaction_currency_id' => 1,
'skip' => 0,
@@ -400,7 +400,7 @@ class BillControllerTest extends TestCase
$repository->shouldReceive('store')->andReturn(null);
$data = [
'name' => 'New Bill ' . random_int(1000, 9999),
'name' => 'New Bill ' . $this->randomInt(),
'amount_min' => '100',
'transaction_currency_id' => 1,
'skip' => 0,
@@ -437,7 +437,7 @@ class BillControllerTest extends TestCase
$attachHelper->shouldReceive('getMessages')->andReturn(new MessageBag);
$data = [
'name' => 'New Bill ' . random_int(1000, 9999),
'name' => 'New Bill ' . $this->randomInt(),
'amount_min' => '100',
'transaction_currency_id' => 1,
'skip' => 0,
@@ -476,7 +476,7 @@ class BillControllerTest extends TestCase
$data = [
'id' => 1,
'name' => 'Updated Bill ' . random_int(1000, 9999),
'name' => 'Updated Bill ' . $this->randomInt(),
'amount_min' => '100',
'transaction_currency_id' => 1,
'skip' => 0,

2
tests/Feature/Controllers/Budget/CreateControllerTest.php
View File

@@ -91,7 +91,7 @@ class CreateControllerTest extends TestCase
$this->session(['budgets.create.uri' => 'http://localhost']);
$data = [
'name' => 'New Budget ' . random_int(1000, 9999),
'name' => 'New Budget ' . $this->randomInt(),
];
$this->be($this->user());
$response = $this->post(route('budgets.store'), $data);

2
tests/Feature/Controllers/Budget/EditControllerTest.php
View File

@@ -90,7 +90,7 @@ class EditControllerTest extends TestCase
$this->session(['budgets.edit.uri' => 'http://localhost']);
$data = [
'name' => 'Updated Budget ' . random_int(1000, 9999),
'name' => 'Updated Budget ' . $this->randomInt(),
'active' => 1,
];
$this->be($this->user());

4
tests/Feature/Controllers/CategoryControllerTest.php
View File

@@ -184,7 +184,7 @@ class CategoryControllerTest extends TestCase
$this->session(['categories.create.uri' => 'http://localhost']);
$data = [
'name' => 'New Category ' . random_int(1000, 9999),
'name' => 'New Category ' . $this->randomInt(),
];
$this->be($this->user());
$response = $this->post(route('categories.store'), $data);
@@ -212,7 +212,7 @@ class CategoryControllerTest extends TestCase
$this->session(['categories.edit.uri' => 'http://localhost']);
$data = [
'name' => 'Updated Category ' . random_int(1000, 9999),
'name' => 'Updated Category ' . $this->randomInt(),
'active' => 1,
];
$this->be($this->user());