kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-18 15:39:50 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage and quality

Browse Source
This commit is contained in:
James Cole
2019-06-16 13:16:46 +02:00
parent 1ce1a84c9e
commit 72c0d7a874
34 changed files with 3211 additions and 2524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tests/Unit/Factory/PiggyBankEventFactoryTest.php
View File

@@ -27,7 +27,6 @@ namespace Tests\Unit\Factory;
use FireflyIII\Factory\PiggyBankEventFactory;
use FireflyIII\Models\PiggyBankEvent;
use FireflyIII\Models\PiggyBankRepetition;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
use Log;
use Tests\TestCase;
@@ -52,12 +51,8 @@ class PiggyBankEventFactoryTest extends TestCase
*/
public function testCreateAmountZero(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
/** @var TransactionJournal $transfer */
$transfer = $this->user()->transactionJournals()->where('transaction_type_id', 3)->first();
$piggy = $this->user()->piggyBanks()->first();
$transfer = $this->getRandomTransfer();
$piggy = $this->user()->piggyBanks()->inRandomOrder()->first();
$repetition = PiggyBankRepetition::first();
$repos = $this->mock(PiggyBankRepositoryInterface::class);
/** @var PiggyBankEventFactory $factory */
@@ -76,11 +71,8 @@ class PiggyBankEventFactoryTest extends TestCase
*/
public function testCreateNoPiggy(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
/** @var TransactionJournal $transfer */
$transfer = $this->user()->transactionJournals()->where('transaction_type_id', 3)->first();
$this->mock(PiggyBankRepositoryInterface::class);
$transfer = $this->getRandomTransfer();
/** @var PiggyBankEventFactory $factory */
$factory = app(PiggyBankEventFactory::class);
@@ -95,11 +87,7 @@ class PiggyBankEventFactoryTest extends TestCase
*/
public function testCreateNoRep(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
/** @var TransactionJournal $transfer */
$transfer = $this->user()->transactionJournals()->where('transaction_type_id', 3)->first();
$transfer = $this->getRandomTransfer();
$piggy = $this->user()->piggyBanks()->first();
$repos = $this->mock(PiggyBankRepositoryInterface::class);
/** @var PiggyBankEventFactory $factory */
@@ -118,12 +106,10 @@ class PiggyBankEventFactoryTest extends TestCase
*/
public function testCreateNotTransfer(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
$this->mock(PiggyBankRepositoryInterface::class);
$deposit = $this->getRandomDeposit();
return;
/** @var TransactionJournal $deposit */
$deposit = $this->user()->transactionJournals()->where('transaction_type_id', 2)->first();
$piggy = $this->user()->piggyBanks()->first();
$piggy = $this->user()->piggyBanks()->first();
/** @var PiggyBankEventFactory $factory */
$factory = app(PiggyBankEventFactory::class);
@@ -135,15 +121,12 @@ class PiggyBankEventFactoryTest extends TestCase
*/
public function testCreateSuccess(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
/** @var TransactionJournal $transfer */
$transfer = $this->user()->transactionJournals()->where('transaction_type_id', 3)->first();
$transfer = $this->getRandomTransfer();
$piggy = $this->user()->piggyBanks()->first();
$repetition = PiggyBankRepetition::first();
$event = PiggyBankEvent::first();
$repos = $this->mock(PiggyBankRepositoryInterface::class);
/** @var PiggyBankEventFactory $factory */
$factory = app(PiggyBankEventFactory::class);
@@ -155,8 +138,8 @@ class PiggyBankEventFactoryTest extends TestCase
$repos->shouldReceive('createEventWithJournal')->once()->andReturn($event);
$result = $factory->create($transfer, $piggy);
$this->assertNotnull($result);
$this->assertEquals($result->id, $event->id);
}
}